From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Alexander Shiyan <eagle.alexander923@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Marek Vasut <marex@denx.de>,
Martin Kepplinger <martin.kepplinger@puri.sm>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Tim Harvey <tharvey@gateworks.com>,
Purism Kernel Team <kernel@puri.sm>
Subject: Re: [PATCH 6/7] media: mc: Expand MUST_CONNECT flag to always require an enabled link
Date: Mon, 15 Jan 2024 12:59:00 +0200 [thread overview]
Message-ID: <20240115105900.GD5869@pendragon.ideasonboard.com> (raw)
In-Reply-To: <ZaUO0ygEoZ8EVMEB@valkosipuli.retiisi.eu>
On Mon, Jan 15, 2024 at 10:54:11AM +0000, Sakari Ailus wrote:
> Hi Laurent,
>
> A small addtional comment...
>
> On Mon, Jan 15, 2024 at 12:30:28PM +0200, Laurent Pinchart wrote:
> > + - If this flag, then at least one link connected to the pad must be
> > + enabled for the pad to be able to stream. There could be temporary
>
> How about, instead, to make the meaning clearer:
>
> - If this flag is set, then for this pad to be able to stream,
> it must be connected by at least one enabled link.
Works for me.
> > + reasons (e.g. device configuration dependent) for the pad to need
> > + enabled links even when this flag isn't set; the absence of the flag
> > + doesn't imply there is none.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-01-15 10:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 10:30 [PATCH 0/7] media: Fix mishandling of MEDIA_PAD_FL_MUST_CONNECT flag Laurent Pinchart
2024-01-15 10:30 ` [PATCH 1/7] media: mc: Add local pad to pipeline regardless of the link state Laurent Pinchart
2024-01-15 10:30 ` [PATCH 2/7] media: mc: Fix flags handling when creating pad links Laurent Pinchart
2024-01-15 10:30 ` [PATCH 3/7] media: nxp: imx8-isi: Check whether crossbar pad is non-NULL before access Laurent Pinchart
2024-01-15 10:30 ` [PATCH 4/7] media: mc: Add num_links flag to media_pad Laurent Pinchart
2024-01-15 10:30 ` [PATCH 5/7] media: mc: Rename pad variable to clarify intent Laurent Pinchart
2024-01-15 10:30 ` [PATCH 6/7] media: mc: Expand MUST_CONNECT flag to always require an enabled link Laurent Pinchart
2024-01-15 10:43 ` Sakari Ailus
2024-01-15 10:55 ` Laurent Pinchart
2024-01-15 10:59 ` Sakari Ailus
2024-01-15 11:10 ` Laurent Pinchart
2024-01-15 10:54 ` Sakari Ailus
2024-01-15 10:59 ` Laurent Pinchart [this message]
2024-01-15 10:30 ` [PATCH 7/7] media: nxp: imx8-isi: Mark all crossbar sink pads as MUST_CONNECT Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240115105900.GD5869@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=eagle.alexander923@gmail.com \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel@puri.sm \
--cc=linux-media@vger.kernel.org \
--cc=marex@denx.de \
--cc=martin.kepplinger@puri.sm \
--cc=rmfrfs@gmail.com \
--cc=sakari.ailus@iki.fi \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox