From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A4E5FEEF; Tue, 23 Jan 2024 15:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706023989; cv=none; b=j3bkJIm/hZKaaqIGcnlEUWGcY9Genr0ACEMHHnopqf8XEyGwztSUqmaRu5lR7DYmX5Xrk0NsWUVw+e3dwOwCe3xVQZO0g79w7xdM2nzHK0ezZsQdZvg5fV2T9ZUr3djvi/5SaDA+Wnd2zzdMqAPssMEisdtbTCB3jE5rJg7gqWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706023989; c=relaxed/simple; bh=LrTucT+QjT5J5+8Wh5ZTwgnyIrX3DAzExqgTQurNW7o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QUaDvezFXmE3aO0p3wJrA3jffkm7bpisP6/a7sKpjmIRDCXDbZb2bETQ0RBLKJ9bd8QGLvhHcrCvD2E6spjyyBZLikTU4LXDrGGv/YGpVfgHn995hBhzZE9MxvdRj5+x2dmBq95rJi2HXaW53tzta0V7j85EeBF8R0C00brNyTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=BKRqlDmU; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BKRqlDmU" Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DDBF1B9A; Tue, 23 Jan 2024 16:31:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1706023912; bh=LrTucT+QjT5J5+8Wh5ZTwgnyIrX3DAzExqgTQurNW7o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BKRqlDmUPVTV9yThehPicu4ZbsxfKurulSw2LfBOT/pHZr8yriD/PMCP2VeKCS3Sk tNWqWl4A3HGjXs4dCZgHXbbqTmMG2s7DgtZPKNbJ99K2R1yEohfXwRS2OlMyc5Mq55 Gm4P2n885LO9z42UkXQN/zkyvZqZMATROphR2cTc= Date: Tue, 23 Jan 2024 17:33:04 +0200 From: Laurent Pinchart To: Biju Das Cc: Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Rob Herring , Lad Prabhakar , linux-media@vger.kernel.org, Geert Uytterhoeven , Biju Das , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 3/4] media: platform: rzg2l-cru: rzg2l-video: Fix image processing initialization Message-ID: <20240123153304.GS10679@pendragon.ideasonboard.com> References: <20240123115821.292787-1-biju.das.jz@bp.renesas.com> <20240123115821.292787-4-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240123115821.292787-4-biju.das.jz@bp.renesas.com> Hi Biju, Thank you for the patch. On Tue, Jan 23, 2024 at 11:58:20AM +0000, Biju Das wrote: > As per section 35.3.1 Starting Reception for the MIPI CSI-2 Input on the > latest hardware manual(R01UH0914EJ0140 Rev.1.40) it is mentioned that s/manual/manual / > initialize the AXI master first and then initialize the image processing. > Fix the start procedure as per the hardware manual. > > Signed-off-by: Biju Das Reviewed-by: Laurent Pinchart > --- > .../media/platform/renesas/rzg2l-cru/rzg2l-video.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index d0ffa90bc656..a7d6fe831d54 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -430,13 +430,6 @@ int rzg2l_cru_start_image_processing(struct rzg2l_cru_dev *cru) > > spin_lock_irqsave(&cru->qlock, flags); > > - /* Initialize image convert */ > - ret = rzg2l_cru_initialize_image_conv(cru, fmt); > - if (ret) { > - spin_unlock_irqrestore(&cru->qlock, flags); > - return ret; > - } > - > /* Select a video input */ > rzg2l_cru_write(cru, CRUnCTRL, CRUnCTRL_VINSEL(0)); > > @@ -450,6 +443,13 @@ int rzg2l_cru_start_image_processing(struct rzg2l_cru_dev *cru) > /* Initialize the AXI master */ > rzg2l_cru_initialize_axi(cru); > > + /* Initialize image convert */ > + ret = rzg2l_cru_initialize_image_conv(cru, fmt); > + if (ret) { > + spin_unlock_irqrestore(&cru->qlock, flags); > + return ret; > + } > + > /* Enable interrupt */ > rzg2l_cru_write(cru, CRUnIE, CRUnIE_EFE); > -- Regards, Laurent Pinchart