From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F91C6A8AD for ; Fri, 1 Mar 2024 13:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709298927; cv=none; b=iCHp9ssvPg/Ma0RAJYmJhq9ydhLQaiWHc/bWo/4F1vC6upZWRkYu/Q902oWpRr5lrFi4F5ofoZzuFz9saU31ZZh16B19hJRxnt3yU+iVUVTONS1ssQ3RVP8cxVG/bsRHDIxiOdEwVQAGKxKTyPWvinxS6uZZi687Uj21+2hmPF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709298927; c=relaxed/simple; bh=ppxwsid024kYh+xIImopd5C7MqjcjcriC8usZ9HcFiA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=napXCdKzflNkbeX6YoG+reGKY3H9nBT57gYlas8PrmApiZBB4wUlwRcX+wKahnk6Xc5AUN46ow4gePqm4XkKyaSny30MIdozqsb6J/WYzJYq22p5JbmQ0FNL9aEzn//uXw2kwF7L0nt7YnOfa6VPacnBoBE9+t04Q5AKpU0Omcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iI8lTj7s; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iI8lTj7s" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709298925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j6JDdzMRW33EgNy8WVE2rwXJul+k7YILcoZp2XURKLI=; b=iI8lTj7syOyTuYUrra2JC9Ixh25zlm6lpJ5/XDSxvHHZ/6ckDatltHl+o0x+DBKt8i4e14 GWgGHG02FIHk3CvRUBtRNIt2Pb3jLghh+3m1ZOV1vVbydisna2iAiG8iA+MKLF1Y12RhUs cSNRD4SkeYAhCd1c/P3E/TVKYPX2EQo= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-vi_ExNF-NDmKQdSkljFk3g-1; Fri, 01 Mar 2024 08:15:24 -0500 X-MC-Unique: vi_ExNF-NDmKQdSkljFk3g-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5131aa087beso1635791e87.2 for ; Fri, 01 Mar 2024 05:15:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709298922; x=1709903722; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j6JDdzMRW33EgNy8WVE2rwXJul+k7YILcoZp2XURKLI=; b=l9dRmSd5Ub0Ebpbd20ylMf0Jja2T5W7b0yX5+HErGagJWtB3r8gQBKdUow0vlDbyNB +FB9p3jlZrf53sXdYdm/mgj+m4T7sxvWfY/lanJYeGYlWeUPDcbK03z+QBQy5fji9+rv vtarKEpYJ/imnN6eV08hFWDERyWUjwR1kigWOFbLij+y59N72o6ORT5TemQMYUKl0D55 Q9mUmSa7lnckVW2fIRfiaZK2w6oDvcSdVkFQcZEorgWqKqQpuii8DFhw7pCSvpSzaauP 4RUacEsv7ahlu/d1fDjIKp3/3Apv59gdTTS4s7vyMCoC5ypyZK7SJrNBDkc44WXR0nrK Wy0w== X-Forwarded-Encrypted: i=1; AJvYcCXDHeor6lDuImcTZp9bEHP4E0nI0kNLQgsZletZoifP9ELD/BxIJ+Emvh5o7AS0d0mHtIynSNw5cbBwzA/2BKwDZCa4p0s+CGnAerY= X-Gm-Message-State: AOJu0YwtkCjww7anYOu44/VPDVpdsIfj3tC7uMcmikPvtlSddpaPvW+r YBCQ6dp4YTUo0cMGOxQKhNrgEoBXs4SweCmK1t3my86XyWvNi0ZZdCWOHni2P55IN2CMxZqrnIg goPaZXit7cCzSQPC3UH//0AIpbVMJt5kYGrkg4BQV6Qg6HVbQFhYEEp3+cGTuzvzMChjxzTO0bw == X-Received: by 2002:ac2:599b:0:b0:512:f6d3:9998 with SMTP id w27-20020ac2599b000000b00512f6d39998mr1223716lfn.17.1709298922218; Fri, 01 Mar 2024 05:15:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwlzt5HlgK0WAcZyh2ZsOJe95EyGGHjhxje8QxMH4nFVP4Pvs9Hg/dbyzZ0Awcz9X/EGacJg== X-Received: by 2002:ac2:599b:0:b0:512:f6d3:9998 with SMTP id w27-20020ac2599b000000b00512f6d39998mr1223689lfn.17.1709298921881; Fri, 01 Mar 2024 05:15:21 -0800 (PST) Received: from toolbox ([2001:9e8:89a0:c500:c65:1f3a:8c08:2a1d]) by smtp.gmail.com with ESMTPSA id bw1-20020a0560001f8100b0033db0c866f7sm4639850wrb.11.2024.03.01.05.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 05:15:21 -0800 (PST) Date: Fri, 1 Mar 2024 14:15:19 +0100 From: Sebastian Wick To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jonathan Corbet , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Dave Stevenson Subject: Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property Message-ID: <20240301131519.GA10491@toolbox> References: <20240222-kms-hdmi-connector-state-v7-0-8f4af575fce2@kernel.org> <20240222-kms-hdmi-connector-state-v7-21-8f4af575fce2@kernel.org> <20240229194726.GB166694@toolbox> <20240301-light-impressive-grasshopper-adabeb@houat> <20240301112941.GE166694@toolbox> <20240301-loyal-cornflower-oxpecker-83ed59@houat> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240301-loyal-cornflower-oxpecker-83ed59@houat> On Fri, Mar 01, 2024 at 01:12:02PM +0100, Maxime Ripard wrote: > On Fri, Mar 01, 2024 at 12:29:41PM +0100, Sebastian Wick wrote: > > On Fri, Mar 01, 2024 at 11:30:56AM +0100, Maxime Ripard wrote: > > > On Thu, Feb 29, 2024 at 08:47:26PM +0100, Sebastian Wick wrote: > > > > > @@ -1708,6 +1731,39 @@ EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property); > > > > > /** > > > > > * DOC: HDMI connector properties > > > > > * > > > > > + * Broadcast RGB (HDMI specific) > > > > > + * Indicates the Quantization Range (Full vs Limited) used. The color > > > > > + * processing pipeline will be adjusted to match the value of the > > > > > + * property, and the Infoframes will be generated and sent accordingly. > > > > > + * > > > > > + * This property is only relevant if the HDMI output format is RGB. If > > > > > + * it's one of the YCbCr variant, it will be ignored and the output will > > > > > + * use a limited quantization range. > > > > > > > > Uh, maybe just say that the quantization range is selected automatically > > > > in case a YCbCr output format is in use. I'm not sure every YCbCr > > > > variant requires limited and even if it does, new formats could change > > > > this. > > > > > > I documented what i915 is doing: > > > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/i915/display/intel_hdmi.c#L2143 > > > > Sure, this is one valid strategy for the automatic behavior of YCbCr. > > Drivers could also always send an InfoFrame to ensure full range where > > possible. The point here is that this property shall not affect YCbCr > > output formats! > > > > Maybe it's even better to say "driver specific" instead of "automatic". > > Honestly, I'm not sure what you want from me here. Ville and you > insisted on the previous version to document what i915 is doing and to > follow whatever the behaviour was, and that we shouldn't spend time > improving the property. Fine, I did that. > > But now, you want me to ... improve the property? The property has a clear scope: quantization range for RGB output formats. What Intel does with things that are not in scope of the property is irrelevant. This isn't improving the property either but documenting the scope of the property. Sorry if this seems arbitrary but these details are so important to get right because the interactions between all the different things is already majorly broken. > Maxime >