From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Max Staudt <mstaudt@chromium.org>,
Tomasz Figa <tfiga@chromium.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Alan Stern <stern@rowland.harvard.edu>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Sean Paul <seanpaul@chromium.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH v3 2/3] media: uvcvideo: Refactor the status irq API
Date: Tue, 26 Mar 2024 17:59:25 +0900 [thread overview]
Message-ID: <20240326085925.GC1041856@google.com> (raw)
In-Reply-To: <20240325-guenter-mini-v3-2-c4bc61d84e03@chromium.org>
On (24/03/25 16:31), Ricardo Ribalda wrote:
>
> void uvc_status_unregister(struct uvc_device *dev)
> {
> - usb_kill_urb(dev->int_urb);
> + uvc_status_suspend(dev);
> uvc_input_unregister(dev);
> }
Was the removal of usb_kill_urb() intended? If so, does it deserve
to be a patch on its own?
next prev parent reply other threads:[~2024-03-26 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 16:31 [PATCH v3 0/3] uvcvideo: Attempt N to land UVC race conditions fixes Ricardo Ribalda
2024-03-25 16:31 ` [PATCH v3 1/3] media: uvcvideo: stop stream during unregister Ricardo Ribalda
2024-03-25 16:31 ` [PATCH v3 2/3] media: uvcvideo: Refactor the status irq API Ricardo Ribalda
2024-03-26 8:42 ` Sergey Senozhatsky
2024-03-26 8:49 ` Ricardo Ribalda
2024-03-26 8:59 ` Sergey Senozhatsky [this message]
2024-03-25 16:31 ` [PATCH v3 3/3] media: uvcvideo: Exit early if there is not int_urb Ricardo Ribalda
2024-03-25 16:41 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326085925.GC1041856@google.com \
--to=senozhatsky@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@kernel.org \
--cc=mstaudt@chromium.org \
--cc=ribalda@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=seanpaul@chromium.org \
--cc=stern@rowland.harvard.edu \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).