Re: [PATCH v3 12/25] media: i2c: imx258: Allow configuration of clock lane behaviour

Pavel Machek
2024-04-03T18:48:18Z

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

Hi!

> The sensor supports the clock lane either remaining in HS mode
> during frame blanking, or dropping to LP11.
>
> Add configuration of the mode via V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK.

> + ret = imx258_write_reg(imx258, IMX258_CLK_BLANK_STOP,
> + IMX258_REG_VALUE_08BIT,
> + imx258->csi2_flags & V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK ?
> + 1 : 0);

!! can be used to turn value into 1/0. I find it easier to read than ?
1 : 0 combination, but possibly that's fine, too.

Best regards,
Pavel

--
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]