Re: [PATCH v3 05/25] media: i2c: imx258: Add regulator control

Pavel Machek
2024-04-03T18:44:26Z

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

Hi!

> The device tree bindings define the relevant regulators for the
> sensor, so update the driver to request the regulators and control
> them at the appropriate times.

> @@ -995,9 +1007,19 @@ static int imx258_power_on(struct device *dev)
> struct imx258 *imx258 = to_imx258(sd);
> int ret;
>
> + ret = regulator_bulk_enable(IMX258_NUM_SUPPLIES,
> + imx258->supplies);
> + if (ret) {

Will this make it fail for all current users?

Best regards,
Pavel

--
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]