Re: [PATCH v3 11/25] media: i2c: imx258: Add get_selection for pixel array information

Pavel Machek
2024-04-03T18:46:55Z

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Hi!

> Libcamera requires the cropping information for each mode, so
> add this information to the driver.

> @@ -116,6 +124,9 @@ struct imx258_mode {
> u32 link_freq_index;
> /* Default register values */
> struct imx258_reg_list reg_list;
> +
> + /* Analog crop rectangle. */

No need for "." at the end, as it is not above.

> + struct v4l2_rect crop;
> };

If the crop is same in all modes, should we have it in common place?

Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]