From: Marek Vasut <marex@denx.de>
To: linux-media@vger.kernel.org
Cc: Marek Vasut <marex@denx.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Michael Tretter <m.tretter@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: [PATCH 2/3] media: i2c: isl7998x: Use 0xf page to program all four pages
Date: Sat, 13 Jul 2024 17:41:55 +0200 [thread overview]
Message-ID: <20240713154242.107903-2-marex@denx.de> (raw)
In-Reply-To: <20240713154242.107903-1-marex@denx.de>
Use page 0xf to program the same value of SDT and short detection
settings into all four pages 1..4 . This reduces the I2C traffic
slightly.
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Michael Tretter <m.tretter@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: linux-media@vger.kernel.org
---
drivers/media/i2c/isl7998x.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/media/i2c/isl7998x.c b/drivers/media/i2c/isl7998x.c
index 5f8f11f7a2c1c..7d2799e498520 100644
--- a/drivers/media/i2c/isl7998x.c
+++ b/drivers/media/i2c/isl7998x.c
@@ -312,14 +312,8 @@
static const struct reg_sequence isl7998x_init_seq_1[] = {
{ ISL7998X_REG_P0_SHORT_DIAG_IRQ_EN, 0xff },
- { ISL7998X_REG_PX_DEC_SDT(0x1), 0x07 },
- { ISL7998X_REG_PX_DEC_SHORT_DET_CTL_1(0x1), 0x03 },
- { ISL7998X_REG_PX_DEC_SDT(0x2), 0x07 },
- { ISL7998X_REG_PX_DEC_SHORT_DET_CTL_1(0x2), 0x03 },
- { ISL7998X_REG_PX_DEC_SDT(0x3), 0x07 },
- { ISL7998X_REG_PX_DEC_SHORT_DET_CTL_1(0x3), 0x03 },
- { ISL7998X_REG_PX_DEC_SDT(0x4), 0x07 },
- { ISL7998X_REG_PX_DEC_SHORT_DET_CTL_1(0x4), 0x03 },
+ { ISL7998X_REG_PX_DEC_SDT(0xf), 0x07 },
+ { ISL7998X_REG_PX_DEC_SHORT_DET_CTL_1(0xf), 0x03 },
{ ISL7998X_REG_P5_LI_ENGINE_CTL, 0x00 },
{ ISL7998X_REG_P0_SW_RESET_CTL, 0x1f, 10 },
{ ISL7998X_REG_P0_IO_BUFFER_CTL, 0x00 },
--
2.43.0
next prev parent reply other threads:[~2024-07-13 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-13 15:41 [PATCH 1/3] media: i2c: isl7998x: Enable VACTIVE and HDELAY shadow registers Marek Vasut
2024-07-13 15:41 ` Marek Vasut [this message]
2024-07-13 15:41 ` [PATCH 3/3] media: i2c: isl7998x: Implement get_mbus_config Marek Vasut
2024-07-14 14:33 ` Francesco Dolcini
2024-07-14 15:37 ` Marek Vasut
2024-07-14 20:36 ` Francesco Dolcini
2024-09-24 22:44 ` [PATCH 1/3] media: i2c: isl7998x: Enable VACTIVE and HDELAY shadow registers Marek Vasut
2024-10-01 14:56 ` Michael Tretter
2024-10-03 16:03 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240713154242.107903-2-marex@denx.de \
--to=marex@denx.de \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox