Re: [PATCH -next v2 2/2] media: siano: remove redundant null pointer checks in cec_devnode_init()

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Sep 07, 2024 at 11:44:00AM +0800, Li Zetao wrote:
> Since the debugfs_create_dir() never returns a null pointer, checking
> the return value for a null pointer is redundant, Remove this check
> since debugfs_create_file can handle IS_ERR pointers.
> 
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
> ---
> v1 -> v2: Remove this check since debugfs_create_file can
> handle IS_ERR pointers.
> v1:
> https://lore.kernel.org/all/20240903143607.2004802-2-lizetao1@huawei.com/
> 
>  drivers/media/common/siano/smsdvb-debugfs.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/media/common/siano/smsdvb-debugfs.c b/drivers/media/common/siano/smsdvb-debugfs.c
> index 73990e469df9..9db38ae4ecee 100644
> --- a/drivers/media/common/siano/smsdvb-debugfs.c
> +++ b/drivers/media/common/siano/smsdvb-debugfs.c
> @@ -411,10 +411,6 @@ void smsdvb_debugfs_register(void)
>  	 * subsystem.
>  	 */
>  	d = debugfs_create_dir("smsdvb", usb_debug_root);
> -	if (IS_ERR_OR_NULL(d)) {
> -		pr_err("Couldn't create sysfs node for smsdvb\n");
> -		return;
> -	}
>  	smsdvb_debugfs_usb_root = d;

Why is d even needed here, just assign it to smsdvb_debugfs_usb_root
directly, right?

thanks,

greg k-h