From: Tommaso Merciai <tomm.merciai@gmail.com>
Cc: linuxfancy@googlegroups.com, sakari.ailus@linux.intel.com,
laurent.pinchart@ideasonboard.com, tomm.merciai@gmail.com,
julien.massot@collabora.com,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] media: i2c: max96714: add HAS_EVENTS subdev flag
Date: Tue, 10 Sep 2024 15:44:27 +0200 [thread overview]
Message-ID: <20240910134428.795273-2-tomm.merciai@gmail.com> (raw)
In-Reply-To: <20240910134428.795273-1-tomm.merciai@gmail.com>
Controls can be exposed to userspace via a v4l-subdevX device, and
userspace has to be able to subscribe to control events so that it is
notified when the control changes value. Add missing HAS_EVENTS flag.
Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
---
drivers/media/i2c/max96714.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/max96714.c b/drivers/media/i2c/max96714.c
index 159753b13777..94b1bc000e48 100644
--- a/drivers/media/i2c/max96714.c
+++ b/drivers/media/i2c/max96714.c
@@ -602,7 +602,8 @@ static int max96714_create_subdev(struct max96714_priv *priv)
goto err_free_ctrl;
}
- priv->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_STREAMS;
+ priv->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
+ V4L2_SUBDEV_FL_HAS_EVENTS | V4L2_SUBDEV_FL_STREAMS;
priv->sd.entity.function = MEDIA_ENT_F_VID_IF_BRIDGE;
priv->sd.entity.ops = &max96714_entity_ops;
--
2.34.1
next prev parent reply other threads:[~2024-09-10 13:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 13:44 [PATCH 0/2] media: i2c: max96714/max96717 Tommaso Merciai
2024-09-10 13:44 ` Tommaso Merciai [this message]
2024-09-12 10:44 ` [PATCH 1/2] media: i2c: max96714: add HAS_EVENTS subdev flag Laurent Pinchart
2024-09-12 11:11 ` Tommaso Merciai
2024-09-12 12:05 ` Laurent Pinchart
2024-09-12 12:14 ` Sakari Ailus
2024-09-12 12:18 ` Laurent Pinchart
2024-09-12 12:52 ` Tommaso Merciai
2024-09-10 13:44 ` [PATCH 2/2] media: i2c: max96717: " Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910134428.795273-2-tomm.merciai@gmail.com \
--to=tomm.merciai@gmail.com \
--cc=julien.massot@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxfancy@googlegroups.com \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox