[PATCH] Added ID 1d19:6108 Dexatek Technology Ltd. Video Grabber

[PATCH] Added ID 1d19:6108 Dexatek Technology Ltd. Video Grabber

[Rohan Barar]

---
 drivers/media/usb/cx231xx/cx231xx-cards.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c
index 92efe6c1f..bda729b42 100644
--- a/drivers/media/usb/cx231xx/cx231xx-cards.c
+++ b/drivers/media/usb/cx231xx/cx231xx-cards.c
@@ -994,6 +994,8 @@ const unsigned int cx231xx_bcount = ARRAY_SIZE(cx231xx_boards);
 
 /* table of devices that work with this driver */
 struct usb_device_id cx231xx_id_table[] = {
+	{USB_DEVICE(0x1D19, 0x6108),
+	.driver_info = CX231XX_BOARD_PV_XCAPTURE_USB},
 	{USB_DEVICE(0x1D19, 0x6109),
 	.driver_info = CX231XX_BOARD_PV_XCAPTURE_USB},
 	{USB_DEVICE(0x0572, 0x5A3C),
-- 
2.46.1

Dear Maintainers,

This patch adds support for the USB device 1D19:6108 (Dexatek Technology Ltd. Video Grabber) to the cx231xx driver.

This device was sold by the supermarket chain 'ALDI' in Australia circa 2013 as part of the 'BAUHN DVD Maker (DK8723)'.

This device is very similar to the 1D19:6109 (https://www.linuxtv.org/wiki/index.php/SilverCrest_USB_2.0_Video_Grabber_SVG_2.0_A2).

I have confirmed that both video and audio capture are working correctly by compiling, signing and loading the patched driver into the kernel using modprobe:
* Video Capture: CONFIRMED WORKING in OBS & VLC.
* Audio Capture: CONFIRMED WORKING via command `arecord -D hw:1,0 -f S16_LE -r 48000 -c 2 audio_capture_test.wav`.

The sole modification is including a new entry to the device ID table, which can be found in `drivers/media/usb/cx231xx/cx231xx-cards.c`.

Note: I previously submitted this patch to vdr@linuxtv.org (https://linuxtv.org/mailman3/hyperkitty/list/vdr@linuxtv.org/thread/4QFRB6JX3WD7Q74XAR32DHUDODTPKNBE/), but was redirected here.

Signed-off-by: Rohan Barar rohan.barar@gmail.com

Thank you for considering my patch!

Kind regards,

Rohan Barar

Re: [PATCH] Added ID 1d19:6108 Dexatek Technology Ltd. Video Grabber

[Rohan Barar]

Dear all,

I am following up on my patch submission for the `cx231xx` driver, which adds support for the Dexatek Technology Ltd Video Grabber (USB Device ID: 1d19:6108).

The patch is a straightforward two-line addition and has been thoroughly tested.

For evidence of the device functioning correctly after applying the patch, please refer to: https://github.com/KernelGhost/TapeShift

I would greatly appreciate any feedback or review at your earliest convenience. Thank you!

Best regards,  

Rohan Barar

Re: [PATCH] Added ID 1d19:6108 Dexatek Technology Ltd. Video Grabber

[Mauro Carvalho Chehab]

Em Mon, 30 Sep 2024 23:05:11 +1000
Rohan Barar <rohan.barar@gmail.com> escreveu:

> Dear all,
> 
> I am following up on my patch submission for the `cx231xx` driver, which adds support for the Dexatek Technology Ltd Video Grabber (USB Device ID: 1d19:6108).
> 
> The patch is a straightforward two-line addition and has been thoroughly tested.
> 
> For evidence of the device functioning correctly after applying the patch, please refer to: https://github.com/KernelGhost/TapeShift
> 
> I would greatly appreciate any feedback or review at your earliest convenience. Thank you!

Your patch is tracked here:

https://patchwork.linuxtv.org/project/linux-media/list/?series=&submitter=rohan+barar&state=&q=&archive=&delegate=

And media CI detected some troubles on it:

https://gitlab.freedesktop.org/linux-media/users/patchwork/-/pipelines/1279069/test_report?job_name=media-patchstyle

It detected problems with your SoB and with the e-mail subject.

The e-mail subject should be something similar to:

	media: cx231xx: Add support for a new Dexatek device

Please check the process about how to submit a patch at the Linux
documentation and, in particular, how we handle stuff on media at:

	https://www.kernel.org/doc/html/latest/driver-api/media/maintainer-entry-profile.html

Please fix the patch and submit a new version. 

Please notice that this is a busy subsystem. We may take some time to
review your work, but, provided that it is tracked on patchwork,
we'll get there ;-)

Regards,
Mauro


Thanks,
Mauro

[PATCH v2] media: cx231xx: Add support for a new 'Dexatek' device (USB ID: 1d19:6108)

[Rohan Barar]

This patch adds support for a Dexatek Technology Ltd Video Grabber (USB ID: 1d19:6108) to the `cx231xx` driver.

This device, sold under the name "BAUHN DVD Maker (DK8723)" by ALDI in Australia, is similar to the device with USB ID `1d19:6109`.

The latter is already supported in the `cx231xx` driver.

Both video and audio capture have been tested and confirmed to work after compiling, signing, and loading the patched driver.

For evidence of the device functioning correctly, refer to: https://github.com/KernelGhost/TapeShift

Signed-off-by: Rohan Barar <rohan.barar@gmail.com>

---
 drivers/media/usb/cx231xx/cx231xx-cards.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c
index 92efe6c1f..bda729b42 100644
--- a/drivers/media/usb/cx231xx/cx231xx-cards.c
+++ b/drivers/media/usb/cx231xx/cx231xx-cards.c
@@ -994,6 +994,8 @@ const unsigned int cx231xx_bcount = ARRAY_SIZE(cx231xx_boards);

 /* table of devices that work with this driver */
 struct usb_device_id cx231xx_id_table[] = {
+	{USB_DEVICE(0x1D19, 0x6108),
+	.driver_info = CX231XX_BOARD_PV_XCAPTURE_USB},
 	{USB_DEVICE(0x1D19, 0x6109),
 	.driver_info = CX231XX_BOARD_PV_XCAPTURE_USB},
 	{USB_DEVICE(0x0572, 0x5A3C),
--
2.46.1

[PATCH v3] media: cx231xx: Add support for Dexatek USB Video Grabber 1d19:6108

[Rohan Barar]

Add Dexatek Technology Ltd USB Video Grabber 1d19:6108 to the cx231xx
driver. This device is sold under the name "BAUHN DVD Maker (DK8723)" by
ALDI in Australia.

This device is similar to 1d19:6109, which is already included in cx231xx.

Both video and audio capture function correctly after installing the
patched cx231xx driver.

Patch Changelog
v1:
 - Initial submission.
v2:
 - Fix SoB + Improve subject.
v3:
 - Rephrase message to not exceed 75 characters per line.
 - Removed reference to external GitHub URL.

Signed-off-by: Rohan Barar <rohan.barar@gmail.com>

---
 drivers/media/usb/cx231xx/cx231xx-cards.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c
index 92efe6c1f..bda729b42 100644
--- a/drivers/media/usb/cx231xx/cx231xx-cards.c
+++ b/drivers/media/usb/cx231xx/cx231xx-cards.c
@@ -994,6 +994,8 @@ const unsigned int cx231xx_bcount = ARRAY_SIZE(cx231xx_boards);

 /* table of devices that work with this driver */
 struct usb_device_id cx231xx_id_table[] = {
+	{USB_DEVICE(0x1D19, 0x6108),
+	.driver_info = CX231XX_BOARD_PV_XCAPTURE_USB},
 	{USB_DEVICE(0x1D19, 0x6109),
 	.driver_info = CX231XX_BOARD_PV_XCAPTURE_USB},
 	{USB_DEVICE(0x0572, 0x5A3C),
--
2.46.1