From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B45211C7B7C for ; Wed, 16 Oct 2024 07:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729065078; cv=none; b=ixTncNuQkYkdptmf8SnuMBLHUesBUL69yercP56yp2E7BvjYgsSljNOzqE2vKoCzxJQY6szpF7hX9xzGJDtSAaom0n577loAz0duxJ0MSQYFBw7lQNEIULTScLQUoBHwE2nDeVHNarhNfJka3+cj1b5u8oO56WcuutLHQjUWfvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729065078; c=relaxed/simple; bh=1z3g25bMB7Gy6wU7Q3wXDM+vk/l6eix2Thl26VwssI8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H2MlE1BU4yYfXyDLabf4qShtJZ0lYuSRs81K4g2Xl1aRPWo/WY/WnlxzcGorqrZLlpXNdXUUAMwc9dTVAEMTzzALxReL532xaha+S0vWHM1qV3mKOZsZttw67qYzhAkJonbwNbzra+RsSdJZ1JqJn2lFPRSspx/1rc61hhx7BNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=b9++UP4Q; arc=none smtp.client-ip=217.70.183.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="b9++UP4Q" Received: by mail.gandi.net (Postfix) with ESMTPSA id 96369E0009; Wed, 16 Oct 2024 07:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1729065073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tm3papsLBSL8G1T47SfyAWFtAJxqHawmlLvsFptZoWY=; b=b9++UP4Q4ctv3W6tJMqPqH/62yAAVVmgt5faBQo5G97ba7wywv2B7ve/Aquj8Uw7NGqDJm o8b9r+mY2WmsiFSOPa4GsZ4dMWAAnWcqYHnU4nsETD/2n6G9cmysmxriabKwbmwo5STRmI EpbGFtUi+pjUZ+boAm8npJGf/G+JszrxYnA48VB3IKV49wp1rUVRypraql0i0sIjbLv1LX 6rVMk1nnCkLPPBdIzVM3U22CsE1kAclNFdoaC7OEbBKy22KwaZLzvFGDvYUOlIyR9cKioC JWY4/EN3lj58sSVDWA4O+4jHm/lKd9Tcd9nGUv4f24WzlhkAYhB+JQIWbF4sUg== Date: Wed, 16 Oct 2024 09:50:58 +0200 From: Luca Ceresoli To: Hans Verkuil Cc: Tomasz Figa , Marek Szyprowski , Mauro Carvalho Chehab , Shuah Khan , Kieran Bingham , Daniel Almeida , Andy Walls , Yong Zhi , Sakari Ailus , Bingbu Cao , Dan Scally , Tianshu Qiu , Martin Tuma , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Ezequiel Garcia , Corentin Labbe , Michael Krufky , Laurent Pinchart , Matt Ranostay , Michael Tretter , Pengutronix Kernel Team , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Ming Qian , Zhou Peng , Eddie James , Joel Stanley , Andrew Jeffery , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Raspberry Pi Kernel Maintenance , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Philipp Zabel , Nas Chung , Jackson Lee , Devarsh Thakkar , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Tiffany Lin , Yunfei Dong , Joseph Liu , Marvin Lin , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Xavier Roumegue , Mirela Rabulea , Shawn Guo , Sascha Hauer , Fabio Estevam , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Robert Foss , Todor Tomov , Bryan O'Donoghue , Stanimir Varbanov , Vikash Garodia , Jacopo Mondi , Niklas =?UTF-8?Q?S=C3=B6derlund?= , Fabrizio Castro , Kieran Bingham , Mikhail Ulyanov , Jacob Chen , Heiko Stuebner , Dafna Hirschfeld , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , =?UTF-8?Q?=C5=81ukasz?= Stelmach , Andrzej Pietrasiewicz , Jacek Anaszewski , Andrzej Hajda , Fabien Dessenne , Hugues Fruchet , Jean-Christophe Trotin , Maxime Coquelin , Alexandre Torgue , Alain Volmat , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Yong Deng , Paul Kocialkowski , Benoit Parrot , Jai Luthra , Michal Simek , Andy Shevchenko , Hans de Goede , Greg Kroah-Hartman , Steve Longerbeam , Jack Zhu , Changhuang Liang , Sowjanya Komatineni , linux-media@vger.kernel.org Subject: Re: [PATCH 09/10] staging: media: drop vb2_ops_wait_prepare/finish Message-ID: <20241016095058.7bbfddc1@booty> In-Reply-To: <20241014-vb2-wait-v1-9-8c3ee25c618c@xs4all.nl> References: <20241014-vb2-wait-v1-0-8c3ee25c618c@xs4all.nl> <20241014-vb2-wait-v1-9-8c3ee25c618c@xs4all.nl> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: luca.ceresoli@bootlin.com Hello Hans, On Mon, 14 Oct 2024 17:06:36 +0200 Hans Verkuil wrote: > Since commit 88785982a19d ("media: vb2: use lock if wait_prepare/finish > are NULL") it is no longer needed to set the wait_prepare/finish > vb2_ops callbacks as long as the lock field in vb2_queue is set. > > Since the vb2_ops_wait_prepare/finish callbacks already rely on that field, > we can safely drop these callbacks. > > This simplifies the code and this is a step towards the goal of deleting > these callbacks. > > Signed-off-by: Hans Verkuil Tested-by: Luca Ceresoli # drivers/staging/media/tegra-video/vi.c -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com