From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Stanimir Varbanov <svarbanov@suse.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv6 0/3] media: venus: close() fixes
Date: Tue, 5 Nov 2024 22:38:43 +0900 [thread overview]
Message-ID: <20241105133843.GA13546@google.com> (raw)
In-Reply-To: <37a906eb-4cd1-4034-9bf6-2f9f4560b9e3@suse.de>
Hi Stanimir,
On (24/11/05 14:04), Stanimir Varbanov wrote:
> On 10/25/24 19:56, Sergey Senozhatsky wrote:
> > A couple of fixes for venus driver close() handling
> > (both enc and dec).
> >
> > v5->v6:
> > -- added kfree() backtrace to 0002
> >
> > Sergey Senozhatsky (3):
> > media: venus: fix enc/dec destruction order
> > media: venus: sync with threaded IRQ during inst destruction
> > media: venus: factor out inst destruction routine
>
> Could you please combine 1/3 and 2/3 commit bodies into 3/3 body and
> resend the new 3/3 only. I do not see a reason to apply 1/3 and 2/3.
So the reason being is that 1/3 fixes a race condition (stale data
in ->fh) and a lockdep splat (wrong destruction order). 2/3 fixes a
completely different race (IRQ vs close) condition and UAF. And 3/3
is just a refactoring that doesn't fix anything. Are you sure you
want to squash all 3 of them? Because they look slightly independent
to me.
> Also, on what platform this was tested?
I ran CTS on one of the strongbad devices.
prev parent reply other threads:[~2024-11-05 13:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 16:56 [PATCHv6 0/3] media: venus: close() fixes Sergey Senozhatsky
2024-10-25 16:56 ` [PATCHv6 1/3] media: venus: fix enc/dec destruction order Sergey Senozhatsky
2024-10-25 16:56 ` [PATCHv6 2/3] media: venus: sync with threaded IRQ during inst destruction Sergey Senozhatsky
2024-12-04 6:31 ` Sergey Senozhatsky
2024-10-25 16:56 ` [PATCHv6 3/3] media: venus: factor out inst destruction routine Sergey Senozhatsky
2024-11-01 3:27 ` [PATCHv6 0/3] media: venus: close() fixes Sergey Senozhatsky
2024-11-05 12:04 ` Stanimir Varbanov
2024-11-05 13:38 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105133843.GA13546@google.com \
--to=senozhatsky@chromium.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=stanimir.k.varbanov@gmail.com \
--cc=svarbanov@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).