From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
hverkuil@xs4all.nl
Subject: Re: [PATCH v7 5/5] media: intel/ipu6: Obtain link frequency from a sub-device
Date: Mon, 16 Dec 2024 13:13:26 +0200 [thread overview]
Message-ID: <20241216111326.GK32204@pendragon.ideasonboard.com> (raw)
In-Reply-To: <Z1_evC9EsHnXuj_r@kekkonen.localdomain>
On Mon, Dec 16, 2024 at 08:03:08AM +0000, Sakari Ailus wrote:
> On Sun, Dec 15, 2024 at 07:08:32PM +0200, Laurent Pinchart wrote:
> > Hi Sakari,
> >
> > Thank you for the patch.
> >
> > I think this should come before 4/5.
>
> Because of...? Both are needed for this to work.
Because, unless I'm mistaken, it would otherwise introduce a bisection
breakage. 4/5 drops the LINK_FREQ control from the IVSC driver, and
obtaining the link frequency through .get_mbus_config() is only
supported when using the v4l2_get_link_freq() variant that takes a pad
argument.
> > On Tue, Dec 10, 2024 at 09:59:06AM +0200, Sakari Ailus wrote:
> > > Obtain the link frequency from the sub-device instead of a control
> > > handler. This allows obtaining it using the get_mbus_config() sub-device
> > > pad op that which is only supported by the IVSC driver.
> >
> > "which is the only method supported by the IVSC driver"
>
> Yes.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-12-16 11:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 7:59 [PATCH v7 0/5] Use V4L2 mbus config for conveying MEI CSI link frequency Sakari Ailus
2024-12-10 7:59 ` [PATCH v7 1/5] media: v4l: Support passing media pad argument to v4l2_get_link_freq() Sakari Ailus
2024-12-12 17:04 ` Jacopo Mondi
2024-12-15 16:45 ` Laurent Pinchart
2024-12-16 8:38 ` Sakari Ailus
2024-12-10 7:59 ` [PATCH v7 2/5] media: v4l: Support obtaining link frequency via get_mbus_config Sakari Ailus
2024-12-12 17:05 ` Jacopo Mondi
2024-12-15 16:59 ` Laurent Pinchart
2024-12-16 8:46 ` Sakari Ailus
2024-12-16 11:16 ` Laurent Pinchart
2024-12-16 12:15 ` Sakari Ailus
2024-12-16 13:51 ` Laurent Pinchart
2024-12-10 7:59 ` [PATCH v7 3/5] media: Documentation: Update link frequency driver documentation Sakari Ailus
2024-12-12 16:53 ` Jacopo Mondi
2024-12-13 7:15 ` Sakari Ailus
2024-12-15 17:02 ` Laurent Pinchart
2024-12-16 8:07 ` Sakari Ailus
2024-12-16 8:08 ` Sakari Ailus
2024-12-16 11:20 ` Laurent Pinchart
2024-12-16 12:05 ` Sakari Ailus
2024-12-16 13:51 ` Laurent Pinchart
2024-12-10 7:59 ` [PATCH v7 4/5] media: ivsc: csi: Obtain link frequency from the media pad Sakari Ailus
2024-12-10 7:59 ` [PATCH v7 5/5] media: intel/ipu6: Obtain link frequency from a sub-device Sakari Ailus
2024-12-15 17:08 ` Laurent Pinchart
2024-12-16 7:47 ` Sakari Ailus
2024-12-16 9:07 ` Laurent Pinchart
2024-12-16 9:18 ` Sakari Ailus
2024-12-16 9:40 ` Laurent Pinchart
2024-12-16 8:03 ` Sakari Ailus
2024-12-16 11:13 ` Laurent Pinchart [this message]
2024-12-16 11:21 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216111326.GK32204@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox