From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: "André Apitzsch" <git@apitzsch.eu>,
"Ricardo Ribalda" <ribalda@kernel.org>
Subject: [PATCH 1/2] Revert "media: imx214: Fix the error handling in imx214_probe()"
Date: Thu, 16 Jan 2025 13:46:59 +0200 [thread overview]
Message-ID: <20250116114700.67468-2-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20250116114700.67468-1-sakari.ailus@linux.intel.com>
This reverts commit 9bc92332cc3f06fda3c6e2423995ca2da0a7ec9a.
Revert this "fix" as it's not really helpful but makes backporting a
proper fix harder.
Fixes: 9bc92332cc3f ("media: imx214: Fix the error handling in imx214_probe()")
Cc: stable@vger.kernel.org # for >= v6.12
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/i2c/imx214.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index 4962cfe7c83d..10b6ad66d126 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c
@@ -1114,7 +1114,6 @@ static int imx214_probe(struct i2c_client *client)
v4l2_ctrl_handler_free(&imx214->ctrls);
error_power_off:
pm_runtime_disable(imx214->dev);
- regulator_bulk_disable(IMX214_NUM_SUPPLIES, imx214->supplies);
return ret;
}
--
2.39.5
next prev parent reply other threads:[~2025-01-16 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 11:46 [PATCH 0/2] Fix PM on imx214 error paths Sakari Ailus
2025-01-16 11:46 ` Sakari Ailus [this message]
2025-01-16 11:47 ` [PATCH 2/2] media: i2c: imx214: Rectify probe error handling related to runtime PM Sakari Ailus
2025-01-20 19:57 ` [PATCH 0/2] Fix PM on imx214 error paths André Apitzsch
2025-01-22 12:04 ` Sakari Ailus
2025-01-22 21:00 ` André Apitzsch
2025-01-23 7:44 ` Sakari Ailus
2025-02-05 22:17 ` André Apitzsch
2025-02-05 23:26 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116114700.67468-2-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=git@apitzsch.eu \
--cc=linux-media@vger.kernel.org \
--cc=ribalda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).