From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C41F31A8409; Thu, 27 Mar 2025 19:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743102161; cv=none; b=kP0iyFXXqjuAgUpAm0iiyjoFl3FixiLXXvuXNvebB3YanDTtG9eMh/Hw9VewcYhwmRg7n4vgE8ugtBsthCKJLR3/kAg+TnknHVFnsJYYYJYzniklJKnRX2XiFSAWPgmUEpCzdbFWYWfDS3suzVX/zl5nnFXFDpyWi0e4TtHBUas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743102161; c=relaxed/simple; bh=JTga+ZYiNcpELw4y54+Pi3yVKvexG7sn/A4fJdlQJGw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UWz32ZqX88Fr00uvoflSJWxBSkTlxRmaSvzD6rD+kQ6SIosEpUf7YAzW3LkZfigaH0XFsGxhI4wKhirdADwfarm3Hoh9vBz0nSr6fst/V+7KQbErj6KbLCyYFHv3Jt8usSuM6ALd0N+qvdJkpB/4GiCrzEDmSGlnzcu/Fmz574I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=ENODeLGp; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ENODeLGp" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 90EBDF6; Thu, 27 Mar 2025 20:00:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743102049; bh=JTga+ZYiNcpELw4y54+Pi3yVKvexG7sn/A4fJdlQJGw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ENODeLGpPEKSI8MBFpqjI7lZvvSd9MHFHL68HAOYDArbsOTUfdPR/UdtWB0EB5CT4 gDACEbOCy1Z5C/ZTPHJJ9IEpGMJki0MAw3XGn9WymDeucWzc2paNT+15USh5FieFdI jvcLgOdSxM6U25X3/vSES7hWByFDTUeSXEfDsSmw= Date: Thu, 27 Mar 2025 21:02:15 +0200 From: Laurent Pinchart To: Frank Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dong Aisheng , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Mauro Carvalho Chehab , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Robert Chiras , "Guoniu.zhou" Subject: Re: [PATCH v3 10/12] arm64: dts: imx8qm: add 24MHz clock-xtal24m Message-ID: <20250327190215.GC22659@pendragon.ideasonboard.com> References: <20250210-8qxp_camera-v3-0-324f5105accc@nxp.com> <20250210-8qxp_camera-v3-10-324f5105accc@nxp.com> <20250327185813.GA22659@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250327185813.GA22659@pendragon.ideasonboard.com> On Thu, Mar 27, 2025 at 08:58:14PM +0200, Laurent Pinchart wrote: > Hi Frank, > > Thank you for the patch. > > On Mon, Feb 10, 2025 at 03:59:29PM -0500, Frank Li wrote: > > Add fixed clock node clock-xtal24m to prepare to add camera support. > > > > Signed-off-by: Frank Li > > --- > > change from v1 to v3 > > - none > > --- > > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi > > index c6a17a0d739c5..40cd45cd9f88f 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi > > @@ -590,6 +590,13 @@ mipi_pll_div2_clk: clock-controller-mipi-div2-pll { > > clock-output-names = "mipi_pll_div2_clk"; > > }; > > > > + xtal24m: clock-xtal24m { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <24000000>; > > + clock-output-names = "xtal_24MHz"; > > + }; > > This is a clock oscillator mounted on the PCB, isn't it ? It shouldn't > be in imx8qm.dtsi, but in board-specific DT sources. You add fixed regulators to arch/arm64/boot/dts/freescale/imx8qm-mek.dts and arch/arm64/boot/dts/freescale/imx8qxp-mek.dts in patch 12/12, the additional of the fixed clock could go there too, in the same patch. > > + > > vpu_subsys_dsp: bus@55000000 { > > compatible = "simple-bus"; > > #address-cells = <1>; -- Regards, Laurent Pinchart