Re: [PATCH v5 0/4] Add AIE driver support for mt8188

Laurent Pinchart
2025-04-03T19:53:20Z

Hi Bo,

Thank you for the patches.

On Thu, Apr 03, 2025 at 03:38:32PM +0800, bo.kong wrote:
> From: Bo Kong <Bo.Kong@mediatek.com>
>
> AIE(AI Engine) is one of the units in mt8188 ISP which provides hardware accelerated face detection function, it can detect different sizes of faces in a raw image.

This series is missing:

- The v4l2-compliance report
- Documentation of the UAPI
- A pointer to an open-source userspace implementation using the device,
in a project relevant to the field of use

> Bo Kong (4):
> media: dt-bindings: add MT8188 AIE
> arm64: dts: mt8188: add aie node
> uapi: linux: add MT8188 AIE
> media: mediatek: add MT8188 AIE driver
>
> .../bindings/media/mediatek,mt8188-aie.yaml | 78 +
> arch/arm64/boot/dts/mediatek/mt8188.dtsi | 33 +
> drivers/media/platform/mediatek/Kconfig | 1 +
> drivers/media/platform/mediatek/Makefile | 1 +
> drivers/media/platform/mediatek/aie/Kconfig | 12 +
> drivers/media/platform/mediatek/aie/Makefile | 5 +
> drivers/media/platform/mediatek/aie/mtk_aie.h | 870 ++++++
> .../media/platform/mediatek/aie/mtk_aie_drv.c | 2398 +++++++++++++++++
> .../platform/mediatek/aie/mtk_aie_v4l2.c | 1295 +++++++++
> drivers/media/v4l2-core/v4l2-ioctl.c | 3 +
> include/uapi/linux/mtk_aie_v4l2_controls.h | 308 +++
> include/uapi/linux/videodev2.h | 6 +
> 12 files changed, 5010 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml
> create mode 100644 drivers/media/platform/mediatek/aie/Kconfig
> create mode 100644 drivers/media/platform/mediatek/aie/Makefile
> create mode 100644 drivers/media/platform/mediatek/aie/mtk_aie.h
> create mode 100644 drivers/media/platform/mediatek/aie/mtk_aie_drv.c
> create mode 100644 drivers/media/platform/mediatek/aie/mtk_aie_v4l2.c
> create mode 100644 include/uapi/linux/mtk_aie_v4l2_controls.h

--
Regards,

Laurent Pinchart