Re: [PATCH 2/7] media: intel/ipu6: Remove line_align

Sakari Ailus
2025-04-10T15:34:58Z

On Thu, Apr 10, 2025 at 03:12:40PM +0200, Stanislaw Gruszka wrote:
> On Thu, Apr 10, 2025 at 12:04:14PM +0000, Sakari Ailus wrote:
> > Hi Stanislaw,
> >
> > Thanks for the set.
> >
> > On Mon, Apr 07, 2025 at 03:40:32PM +0200, Stanislaw Gruszka wrote:
> > > isys->line_align value is only used in one place and we can just use
> > > the proper value directly there.
> > >
> > > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> > > ---
> > > drivers/media/pci/intel/ipu6/ipu6-isys-video.c | 2 +-
> > > drivers/media/pci/intel/ipu6/ipu6-isys.c | 1 -
> > > drivers/media/pci/intel/ipu6/ipu6-isys.h | 4 ----
> > > 3 files changed, 1 insertion(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> > > index e36a21aa9040..3165904d7ebf 100644
> > > --- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> > > +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> > > @@ -241,7 +241,7 @@ static void ipu6_isys_try_fmt_cap(struct ipu6_isys_video *av, u32 type,
> > > else
> > > *bytesperline = DIV_ROUND_UP(*width * pfmt->bpp, BITS_PER_BYTE);
> > >
> > > - *bytesperline = ALIGN(*bytesperline, av->isys->line_align);
> > > + *bytesperline = ALIGN(*bytesperline, 64);
> >
> > Is this value the same for ipu7?
>
> Yes.

Ack, thanks for confirming this.

--
Sakari Ailus