Re: [PATCH] media: intel/ipu6: Fix dma mask for non-secure mode

[kernel test robot <lkp@intel.com>]

Hi Stanislaw,

kernel test robot noticed the following build errors:

[auto build test ERROR on linuxtv-media-pending/master]
[also build test ERROR on linus/master v6.15-rc1 next-20250409]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Stanislaw-Gruszka/media-intel-ipu6-Fix-dma-mask-for-non-secure-mode/20250409-180044
base:   https://git.linuxtv.org/media-ci/media-pending.git master
patch link:    https://lore.kernel.org/r/20250409095825.1014521-1-stanislaw.gruszka%40linux.intel.com
patch subject: [PATCH] media: intel/ipu6: Fix dma mask for non-secure mode
config: x86_64-buildonly-randconfig-004-20250409 (https://download.01.org/0day-ci/archive/20250409/202504092006.r3kxuxvV-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250409/202504092006.r3kxuxvV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504092006.r3kxuxvV-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/media/pci/intel/ipu6/ipu6-dma.c:174:9: error: call to undeclared function 'ipu6_alloc_iova'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     174 |         iova = ipu6_alloc_iova(mmu, count);
         |                ^
   drivers/media/pci/intel/ipu6/ipu6-dma.c:174:9: note: did you mean 'ipu_alloc_iova'?
   drivers/media/pci/intel/ipu6/ipu6-mmu.h:80:28: note: 'ipu_alloc_iova' declared here
      80 | static inline struct iova *ipu_alloc_iova(struct ipu6_mmu *mmu,
         |                            ^
>> drivers/media/pci/intel/ipu6/ipu6-dma.c:174:7: error: incompatible integer to pointer conversion assigning to 'struct iova *' from 'int' [-Wint-conversion]
     174 |         iova = ipu6_alloc_iova(mmu, count);
         |              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/pci/intel/ipu6/ipu6-dma.c:399:9: error: call to undeclared function 'ipu6_alloc_iova'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     399 |         iova = ipu6_alloc_iova(mmu, npages);
         |                ^
   drivers/media/pci/intel/ipu6/ipu6-dma.c:399:7: error: incompatible integer to pointer conversion assigning to 'struct iova *' from 'int' [-Wint-conversion]
     399 |         iova = ipu6_alloc_iova(mmu, npages);
         |              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   4 errors generated.
--
>> drivers/media/pci/intel/ipu6/ipu6-mmu.c:424:9: error: call to undeclared function 'ipu6_alloc_iova'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     424 |         iova = ipu6_alloc_iova(mmu, n_pages);
         |                ^
   drivers/media/pci/intel/ipu6/ipu6-mmu.c:424:9: note: did you mean 'ipu_alloc_iova'?
   drivers/media/pci/intel/ipu6/ipu6-mmu.h:80:28: note: 'ipu_alloc_iova' declared here
      80 | static inline struct iova *ipu_alloc_iova(struct ipu6_mmu *mmu,
         |                            ^
>> drivers/media/pci/intel/ipu6/ipu6-mmu.c:424:7: error: incompatible integer to pointer conversion assigning to 'struct iova *' from 'int' [-Wint-conversion]
     424 |         iova = ipu6_alloc_iova(mmu, n_pages);
         |              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   2 errors generated.


vim +/ipu6_alloc_iova +174 drivers/media/pci/intel/ipu6/ipu6-dma.c

   151	
   152	void *ipu6_dma_alloc(struct ipu6_bus_device *sys, size_t size,
   153			     dma_addr_t *dma_handle, gfp_t gfp,
   154			     unsigned long attrs)
   155	{
   156		struct device *dev = &sys->auxdev.dev;
   157		struct pci_dev *pdev = sys->isp->pdev;
   158		dma_addr_t pci_dma_addr, ipu6_iova;
   159		struct ipu6_mmu *mmu = sys->mmu;
   160		struct vm_info *info;
   161		unsigned long count;
   162		struct page **pages;
   163		struct iova *iova;
   164		unsigned int i;
   165		int ret;
   166	
   167		info = kzalloc(sizeof(*info), GFP_KERNEL);
   168		if (!info)
   169			return NULL;
   170	
   171		size = PAGE_ALIGN(size);
   172		count = PHYS_PFN(size);
   173	
 > 174		iova = ipu6_alloc_iova(mmu, count);
   175		if (!iova)
   176			goto out_kfree;
   177	
   178		pages = __alloc_buffer(size, gfp, attrs);
   179		if (!pages)
   180			goto out_free_iova;
   181	
   182		dev_dbg(dev, "dma_alloc: size %zu iova low pfn %lu, high pfn %lu\n",
   183			size, iova->pfn_lo, iova->pfn_hi);
   184		for (i = 0; iova->pfn_lo + i <= iova->pfn_hi; i++) {
   185			pci_dma_addr = dma_map_page_attrs(&pdev->dev, pages[i], 0,
   186							  PAGE_SIZE, DMA_BIDIRECTIONAL,
   187							  attrs);
   188			dev_dbg(dev, "dma_alloc: mapped pci_dma_addr %pad\n",
   189				&pci_dma_addr);
   190			if (dma_mapping_error(&pdev->dev, pci_dma_addr)) {
   191				dev_err(dev, "pci_dma_mapping for page[%d] failed", i);
   192				goto out_unmap;
   193			}
   194	
   195			ret = ipu6_mmu_map(mmu->dmap->mmu_info,
   196					   PFN_PHYS(iova->pfn_lo + i), pci_dma_addr,
   197					   PAGE_SIZE);
   198			if (ret) {
   199				dev_err(dev, "ipu6_mmu_map for pci_dma[%d] %pad failed",
   200					i, &pci_dma_addr);
   201				dma_unmap_page_attrs(&pdev->dev, pci_dma_addr,
   202						     PAGE_SIZE, DMA_BIDIRECTIONAL,
   203						     attrs);
   204				goto out_unmap;
   205			}
   206		}
   207	
   208		info->vaddr = vmap(pages, count, VM_USERMAP, PAGE_KERNEL);
   209		if (!info->vaddr)
   210			goto out_unmap;
   211	
   212		*dma_handle = PFN_PHYS(iova->pfn_lo);
   213	
   214		info->pages = pages;
   215		info->ipu6_iova = *dma_handle;
   216		info->size = size;
   217		list_add(&info->list, &mmu->vma_list);
   218	
   219		return info->vaddr;
   220	
   221	out_unmap:
   222		while (i--) {
   223			ipu6_iova = PFN_PHYS(iova->pfn_lo + i);
   224			pci_dma_addr = ipu6_mmu_iova_to_phys(mmu->dmap->mmu_info,
   225							     ipu6_iova);
   226			dma_unmap_page_attrs(&pdev->dev, pci_dma_addr, PAGE_SIZE,
   227					     DMA_BIDIRECTIONAL, attrs);
   228	
   229			ipu6_mmu_unmap(mmu->dmap->mmu_info, ipu6_iova, PAGE_SIZE);
   230		}
   231	
   232		__free_buffer(pages, size, attrs);
   233	
   234	out_free_iova:
   235		__free_iova(&mmu->dmap->iovad, iova);
   236	out_kfree:
   237		kfree(info);
   238	
   239		return NULL;
   240	}
   241	EXPORT_SYMBOL_NS_GPL(ipu6_dma_alloc, "INTEL_IPU6");
   242	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki