From: Jeongjun Park <aha310510@gmail.com>
To: mchehab@kernel.org
Cc: hverkuil@xs4all.nl, zhang_shurong@foxmail.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeongjun Park <aha310510@gmail.com>
Subject: [PATCH] media: az6007: fix out-of-bounds in az6007_i2c_xfer()
Date: Mon, 21 Apr 2025 19:55:54 +0900 [thread overview]
Message-ID: <20250421105555.34984-1-aha310510@gmail.com> (raw)
According to the previous commit 1047f9343011 ("media: az6007:
Fix null-ptr-deref in az6007_i2c_xfer()"), msgs[i].len is user-controlled.
In the previous commit, bounds checking was added because a null-ptr-deref
bug occurs when msgs[i].buf and msgs[i].len are set to null. However, this
leads to an out-of-bounds vuln for st->data when msgs[i].len is set to a
large value.
Therefore, code to check the maximum value of msgs[i].len needs to be added.
Fixes: 1047f9343011 ("media: az6007: Fix null-ptr-deref in az6007_i2c_xfer()")
Signed-off-by: Jeongjun Park <aha310510@gmail.com>
---
drivers/media/usb/dvb-usb-v2/az6007.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/az6007.c b/drivers/media/usb/dvb-usb-v2/az6007.c
index 65ef045b74ca..fba1b6c08dc7 100644
--- a/drivers/media/usb/dvb-usb-v2/az6007.c
+++ b/drivers/media/usb/dvb-usb-v2/az6007.c
@@ -788,7 +788,7 @@ static int az6007_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
if (az6007_xfer_debug)
printk(KERN_DEBUG "az6007: I2C W addr=0x%x len=%d\n",
addr, msgs[i].len);
- if (msgs[i].len < 1) {
+ if (msgs[i].len < 1 || msgs[i].len + 1 > sizeof(st->data)) {
ret = -EIO;
goto err;
}
@@ -806,7 +806,7 @@ static int az6007_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
if (az6007_xfer_debug)
printk(KERN_DEBUG "az6007: I2C R addr=0x%x len=%d\n",
addr, msgs[i].len);
- if (msgs[i].len < 1) {
+ if (msgs[i].len < 1 || msgs[i].len + 5 > sizeof(st->data)) {
ret = -EIO;
goto err;
}
--
next reply other threads:[~2025-04-21 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 10:55 Jeongjun Park [this message]
2025-09-04 8:05 ` [PATCH] media: az6007: fix out-of-bounds in az6007_i2c_xfer() Hans Verkuil
2025-09-04 11:07 ` Jeongjun Park
2025-09-05 7:35 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421105555.34984-1-aha310510@gmail.com \
--to=aha310510@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=zhang_shurong@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox