From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24DC8267F6B for ; Wed, 23 Apr 2025 12:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745412208; cv=none; b=iJhgdTLDxUvYQts/m8EEeuFNzMyqUO++7+LGGM/TMU46REREf6WiqMThyZ+4tcR3LVmenn1iGgZRyH8NXX6xNyum83JySH1xtpJu9AYiiQkhWYvPLYxEsKPLs6BUt99i5dgvQJfmz/ws5/33YYiOQRKdPdqo8LlpFP0nmxLW0kY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745412208; c=relaxed/simple; bh=uKdKCmATL7HbQw83WokzCuStiTmae6ffQMdaQPDSD/w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WJw3xH+c+aWFeDpnWKueM8K8yks/7nQueRh9xbJ0tFxLoxKsV4T03szjFdz7uU+rz3glzBp5MvC/z64xaBV46nl09CAf5Ds9aiMEGWQY0WP9FkPK7HT5OmFr9f1P1iFZ4G31tQ/Wf/T8JlUGLN8GNU126HtnnoR7pS9tVgUAEA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=ErloB4Id; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ErloB4Id" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D063A1AE2; Wed, 23 Apr 2025 14:43:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1745412204; bh=uKdKCmATL7HbQw83WokzCuStiTmae6ffQMdaQPDSD/w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ErloB4IdofyFxxaHYTWX4PUS0sGg5tRMFvEFAbZUmJuwhKz467v0anL5+flGzr0a9 HzAWo97aFmyHv5isVjxYUrg3c/cGdK5JaAXlkOKACFQpGvY/xkJk1sFttx036H3CUC dDbeOmY8roqK65qWsKNuDu4m0msw3A9gT6xnwnsI= Date: Wed, 23 Apr 2025 15:43:22 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, dongcheng.yan@intel.com Subject: Re: [PATCH v3 11/11] media: ccs-pll: Document the CCS PLL flags Message-ID: <20250423124322.GG17813@pendragon.ideasonboard.com> References: <20250423123359.1800904-1-sakari.ailus@linux.intel.com> <20250423123359.1800904-12-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250423123359.1800904-12-sakari.ailus@linux.intel.com> Hi Sakari, Thank you for the patch. On Wed, Apr 23, 2025 at 03:33:59PM +0300, Sakari Ailus wrote: > Document the CCS PLL flags with short comments. The CCS spec has more > information on them while the added documentation helps finding the > relevant information in the CCS spec. > > Signed-off-by: Sakari Ailus > --- > drivers/media/i2c/ccs-pll.c | 2 +- > drivers/media/i2c/ccs-pll.h | 27 ++++++++++++++++++++++++--- > 2 files changed, 25 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/ccs-pll.c b/drivers/media/i2c/ccs-pll.c > index 87798616b76d..8f9a695bd9e5 100644 > --- a/drivers/media/i2c/ccs-pll.c > +++ b/drivers/media/i2c/ccs-pll.c > @@ -129,8 +129,8 @@ static void print_pll_flags(struct device *dev, struct ccs_pll *pll) > { > dev_dbg(dev, "PLL flags%s%s%s%s%s%s%s%s%s%s%s\n", > pll->flags & PLL_FL(OP_PIX_CLOCK_PER_LANE) ? " op-pix-clock-per-lane" : "", > - pll->flags & PLL_FL(NO_OP_CLOCKS) ? " no-op-clocks" : "", > pll->flags & PLL_FL(EVEN_PLL_MULTIPLIER) ? " even-pll-multiplier" : "", > + pll->flags & PLL_FL(NO_OP_CLOCKS) ? " no-op-clocks" : "", > pll->flags & PLL_FL(LANE_SPEED_MODEL) ? " lane-speed" : "", > pll->flags & PLL_FL(EXT_IP_PLL_DIVIDER) ? > " ext-ip-pll-divider" : "", > diff --git a/drivers/media/i2c/ccs-pll.h b/drivers/media/i2c/ccs-pll.h > index 754eb5f52cc4..c668ee4d4493 100644 > --- a/drivers/media/i2c/ccs-pll.h > +++ b/drivers/media/i2c/ccs-pll.h > @@ -18,19 +18,40 @@ > #define CCS_PLL_BUS_TYPE_CSI2_DPHY 0x00 > #define CCS_PLL_BUS_TYPE_CSI2_CPHY 0x01 > > -/* Old SMIA and implementation specific flags */ > -/* op pix clock is for all lanes in total normally */ > +/* Old SMIA and implementation specific flags. */ > +/* OP PIX clock is for all lanes in total normally. */ > #define CCS_PLL_FLAG_OP_PIX_CLOCK_PER_LANE BIT(0) > -#define CCS_PLL_FLAG_NO_OP_CLOCKS BIT(1) > +/* If set, the PLL multipliers are required to be even. */ > #define CCS_PLL_FLAG_EVEN_PLL_MULTIPLIER BIT(3) > + > /* CCS PLL flags */ > + > +/* The sensor doesn't have OP clocks at all. */ > +#define CCS_PLL_FLAG_NO_OP_CLOCKS BIT(1) > +/* System speed model if this flag is unset. */ > #define CCS_PLL_FLAG_LANE_SPEED_MODEL BIT(2) > +/* If set, the pre-PLL divider may have odd values, too. */ > #define CCS_PLL_FLAG_EXT_IP_PLL_DIVIDER BIT(4) > +/* > + * If set, the OP PIX clock doesn't have to exactly match with data rate, it may > + * be higher. See "OP Domain Formulas" in MIPI CCS 1.1 spec. > + */ > #define CCS_PLL_FLAG_FLEXIBLE_OP_PIX_CLK_DIV BIT(5) > +/* If set, the VT domain may run faster than the OP domain. */ > #define CCS_PLL_FLAG_FIFO_DERATING BIT(6) > +/* If set, the VT domain may run slower than the OP domain. */ > #define CCS_PLL_FLAG_FIFO_OVERRATING BIT(7) > +/* If set, the PLL tree has two PLLs instead of one. */ > #define CCS_PLL_FLAG_DUAL_PLL BIT(8) > +/* > + * If set, the OP SYS clock is a dual data rate clock, transferring two bits per > + * cycle instead of one. > + */ > #define CCS_PLL_FLAG_OP_SYS_DDR BIT(9) > +/* > + * If set, the OP PIX clock is a dual data rate clock, transferring two bits per Same comment as for v2. > + * cycle instead of one. > + */ > #define CCS_PLL_FLAG_OP_PIX_DDR BIT(10) > > /** -- Regards, Laurent Pinchart