From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4379272E60; Mon, 5 May 2025 23:19:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487186; cv=none; b=a68imzOdlyGRK589CN0Q95ELX+AdGs6ClTgB/UOJ+Fjis+OWwi18PiOfeRL35eD8iVqzhoRQzzPVuXnKBnSbx+/jkYWHxL+BTuDndmeJUn7S76r/kpmNMPZ6HDZ7fc7oZP0q+bq52asJg1jbeFpj1bsiVPxQ1NxRN8X0d5iFYHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487186; c=relaxed/simple; bh=GXQQVWklXWNAEB0XwIb9nq+0BoP+bo7EBFoAE8e69kU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BQE8Uc1DJpho8+f6bzWaQP4gykzNb1H1xebgt48/uV3KJHPStcQc4mzvkIwgM9hQZlPpl5crx1uxM47aT01MRZ7AEZFaZOQB7AISM723MzkYifV5J5d0SYYVeTXN3s6HQritqN4qn4Qr7nJEA0z3OejqLwhh8RCpJ6pmcbP9qw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TWSHEYeM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TWSHEYeM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A252C4CEEF; Mon, 5 May 2025 23:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746487185; bh=GXQQVWklXWNAEB0XwIb9nq+0BoP+bo7EBFoAE8e69kU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TWSHEYeMoboShy+JhAkTUT7RS5eU1KZu/WyLZrZVvg8/Rrr5eEADVpaOSNkUvQ5Pb A2HbUnFBnECXrf5UHAHb6S07y0l60lTfuCljihpNDNBH5Xgl7W00iQ5wWnz21JxZFj pFA2/PUvTQqPl979U1bcheW+LK5JJM/FwidAicYSC8PQOpRSW6hmob4QFKLsQoUumb Rv/jXMdE4dTL9/hFcOH9wlCfNAFXox7on5h1+sVqk5Zlw5150S4vxmHvutnSHJjBJM qnR27k8hmOwKmMSrCJrejKFEQ5DhuqPr3rcvOPFx9Lai8KimLzPtFSx/UhHQJKYOmT KJ0N9D+UhTEAQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , mchehab@kernel.org, christophe.jaillet@wanadoo.fr, ribalda@chromium.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 047/114] media: cx231xx: set device_caps for 417 Date: Mon, 5 May 2025 19:17:10 -0400 Message-Id: <20250505231817.2697367-47-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505231817.2697367-1-sashal@kernel.org> References: <20250505231817.2697367-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.237 Content-Transfer-Encoding: 8bit From: Hans Verkuil [ Upstream commit a79efc44b51432490538a55b9753a721f7d3ea42 ] The video_device for the MPEG encoder did not set device_caps. Add this, otherwise the video device can't be registered (you get a WARN_ON instead). Not seen before since currently 417 support is disabled, but I found this while experimenting with it. Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/cx231xx/cx231xx-417.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c index c5e21785fafe2..02343e88cc618 100644 --- a/drivers/media/usb/cx231xx/cx231xx-417.c +++ b/drivers/media/usb/cx231xx/cx231xx-417.c @@ -1722,6 +1722,8 @@ static void cx231xx_video_dev_init( vfd->lock = &dev->lock; vfd->release = video_device_release_empty; vfd->ctrl_handler = &dev->mpeg_ctrl_handler.hdl; + vfd->device_caps = V4L2_CAP_READWRITE | V4L2_CAP_STREAMING | + V4L2_CAP_VIDEO_CAPTURE; video_set_drvdata(vfd, dev); if (dev->tuner_type == TUNER_ABSENT) { v4l2_disable_ioctl(vfd, VIDIOC_G_FREQUENCY); -- 2.39.5