From: Richard Leitner <richard.leitner@linux.dev>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org,
Richard Leitner <richard.leitner@linux.dev>
Subject: [PATCH v4 02/10] leds: flash: add support for flash/stobe duration
Date: Wed, 07 May 2025 09:51:31 +0200 [thread overview]
Message-ID: <20250507-ov9282-flash-strobe-v4-2-72b299c1b7c9@linux.dev> (raw)
In-Reply-To: <20250507-ov9282-flash-strobe-v4-0-72b299c1b7c9@linux.dev>
Add support for the new V4L2_CID_FLASH_DURATION control to the leds
driver.
Signed-off-by: Richard Leitner <richard.leitner@linux.dev>
---
drivers/leds/led-class-flash.c | 15 +++++++++++++++
include/linux/led-class-flash.h | 16 ++++++++++++++++
2 files changed, 31 insertions(+)
diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c
index f4e26ce84862c05092a9598e63ed301967852f13..165035a8826ca7d44a5cd265a5130a76c6e94347 100644
--- a/drivers/leds/led-class-flash.c
+++ b/drivers/leds/led-class-flash.c
@@ -440,6 +440,21 @@ int led_update_flash_brightness(struct led_classdev_flash *fled_cdev)
}
EXPORT_SYMBOL_GPL(led_update_flash_brightness);
+int led_set_flash_duration(struct led_classdev_flash *fled_cdev, u32 duration)
+{
+ struct led_classdev *led_cdev = &fled_cdev->led_cdev;
+ struct led_flash_setting *s = &fled_cdev->duration;
+
+ s->val = duration;
+ led_clamp_align(s);
+
+ if (!(led_cdev->flags & LED_SUSPENDED))
+ return call_flash_op(fled_cdev, duration_set, s->val);
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(led_set_flash_duration);
+
MODULE_AUTHOR("Jacek Anaszewski <j.anaszewski@samsung.com>");
MODULE_DESCRIPTION("LED Flash class interface");
MODULE_LICENSE("GPL v2");
diff --git a/include/linux/led-class-flash.h b/include/linux/led-class-flash.h
index 36df927ec4b7dcaf9074c6ef32ac8ce83a87a79d..21ec856c36bc67decda46aa8ff1c040ffdcf1181 100644
--- a/include/linux/led-class-flash.h
+++ b/include/linux/led-class-flash.h
@@ -45,6 +45,8 @@ struct led_flash_ops {
int (*timeout_set)(struct led_classdev_flash *fled_cdev, u32 timeout);
/* get the flash LED fault */
int (*fault_get)(struct led_classdev_flash *fled_cdev, u32 *fault);
+ /* set flash duration */
+ int (*duration_set)(struct led_classdev_flash *fled_cdev, u32 duration);
};
/*
@@ -75,6 +77,9 @@ struct led_classdev_flash {
/* flash timeout value in microseconds along with its constraints */
struct led_flash_setting timeout;
+ /* flash timeout value in microseconds along with its constraints */
+ struct led_flash_setting duration;
+
/* LED Flash class sysfs groups */
const struct attribute_group *sysfs_groups[LED_FLASH_SYSFS_GROUPS_SIZE];
};
@@ -209,4 +214,15 @@ int led_set_flash_timeout(struct led_classdev_flash *fled_cdev, u32 timeout);
*/
int led_get_flash_fault(struct led_classdev_flash *fled_cdev, u32 *fault);
+/**
+ * led_set_flash_duration - set flash LED duration
+ * @fled_cdev: the flash LED to set
+ * @timeout: the flash duration to set it to
+ *
+ * Set the flash strobe duration.
+ *
+ * Returns: 0 on success or negative error value on failure
+ */
+int led_set_flash_duration(struct led_classdev_flash *fled_cdev, u32 duration);
+
#endif /* __LINUX_FLASH_LEDS_H_INCLUDED */
--
2.47.2
next prev parent reply other threads:[~2025-05-07 7:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 7:51 [PATCH v4 00/10] Add strobe/flash duration v4l2 ctrl & use it for ov9282 Richard Leitner
2025-05-07 7:51 ` [PATCH v4 01/10] media: v4l: ctrls: add a control for flash/strobe duration Richard Leitner
2025-05-07 7:51 ` Richard Leitner [this message]
2025-05-13 10:08 ` (subset) [PATCH v4 02/10] leds: flash: add support for flash/stobe duration Lee Jones
2025-05-07 7:51 ` [PATCH v4 03/10] media: v4l2-flash: add support for flash/strobe duration Richard Leitner
2025-05-07 7:51 ` [PATCH v4 04/10] media: v4l2-flash: fix flash_timeout comment Richard Leitner
2025-05-07 7:51 ` [PATCH v4 05/10] Documentation: uAPI: media: add V4L2_CID_FLASH_DURATION Richard Leitner
2025-05-07 7:51 ` [PATCH v4 06/10] media: i2c: ov9282: add output enable register definitions Richard Leitner
2025-05-07 7:51 ` [PATCH v4 07/10] media: i2c: ov9282: add led_mode v4l2 control Richard Leitner
2025-05-26 20:41 ` Sakari Ailus
2025-05-28 12:15 ` Richard Leitner
2025-05-07 7:51 ` [PATCH v4 08/10] media: i2c: ov9282: add strobe_duration " Richard Leitner
2025-05-26 20:27 ` Sakari Ailus
2025-06-16 22:11 ` Richard Leitner
2025-05-07 7:51 ` [PATCH v4 09/10] media: i2c: ov9282: add strobe_source " Richard Leitner
2025-05-26 20:24 ` Sakari Ailus
2025-05-28 9:46 ` Richard Leitner
2025-05-07 7:51 ` [PATCH v4 10/10] media: i2c: ov9282: implement try_ctrl for strobe_duration Richard Leitner
2025-05-26 20:22 ` Sakari Ailus
2025-05-28 9:25 ` Richard Leitner
2025-05-26 18:41 ` [PATCH v4 00/10] Add strobe/flash duration v4l2 ctrl & use it for ov9282 Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507-ov9282-flash-strobe-v4-2-72b299c1b7c9@linux.dev \
--to=richard.leitner@linux.dev \
--cc=dave.stevenson@raspberrypi.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pavel@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox