Linux Media Controller development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Haren Myneni <haren@linux.ibm.com>,
	Bagas Sanjaya <bagasdotme@gmail.com>,
	Andrew Donnellan <ajd@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Akshay Gupta <akshay.gupta@amd.com>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	hans@jjverkuil.nl,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Lee Jones <lee@kernel.org>
Subject: Re: [PATCH 1/2] Documentation: Bump media IOCTL reserved numbers
Date: Mon, 26 May 2025 13:48:02 +0200	[thread overview]
Message-ID: <20250526114802.GD17743@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20250526111732.487229-2-sakari.ailus@linux.intel.com>

Hi Sakari,

Thank you for the patch.

On Mon, May 26, 2025 at 02:17:31PM +0300, Sakari Ailus wrote:
> The Media Controller uses IOCTL numbers up to 0x81. Given that nothing
> appears to be using them for other purposes, even in the samples
> allocation (checked with $ git grep "#define.*_IO.*'|'"), just reassign
> the numbers up to 0x8f to linux/media.h and bump the samples allocation by
> 0x10.

The commit message should explain why. The explanation is in the cover
letter, just move it to this patch. With that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  Documentation/userspace-api/ioctl/ioctl-number.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index bc91756bde73..6b3be3fb0b15 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> @@ -312,8 +312,8 @@ Code  Seq#    Include File                                           Comments
>  'z'   40-7F                                                          CAN bus card conflict!
>                                                                       <mailto:oe@port.de>
>  'z'   10-4F  drivers/s390/crypto/zcrypt_api.h                        conflict!
> -'|'   00-7F  linux/media.h
> -'|'   80-9F  samples/                                                Any sample and example drivers
> +'|'   00-8F  linux/media.h
> +'|'   90-AF  samples/                                                Any sample and example drivers
>  0x80  00-1F  linux/fb.h
>  0x81  00-1F  linux/vduse.h
>  0x89  00-06  arch/x86/include/asm/sockios.h

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2025-05-26 11:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-26 11:17 [PATCH 0/2] Document Media Controller IOCTL number assignments Sakari Ailus
2025-05-26 11:17 ` [PATCH 1/2] Documentation: Bump media IOCTL reserved numbers Sakari Ailus
2025-05-26 11:48   ` Laurent Pinchart [this message]
2025-05-26 13:24     ` Sakari Ailus
2025-05-26 11:17 ` [PATCH 2/2] media: uapi: Document IOCTL number assignment Sakari Ailus
2025-05-26 11:48   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250526114802.GD17743@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=ajd@linux.ibm.com \
    --cc=akshay.gupta@amd.com \
    --cc=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hans@jjverkuil.nl \
    --cc=haren@linux.ibm.com \
    --cc=lee@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox