From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B01628EA45 for ; Wed, 28 May 2025 17:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748455101; cv=none; b=nJJOrbICeE/SgcE/vTEOZ0bJ4i/0ffFzcfkXykjaIofXmZkEb6S4KGES1TVXHHjoOwatPbL5LoGe3/+EfGc3+A0wDbAJnlE6MBnDq6+zQshrG3G8NEFubzSIZf0CuUAwC/5j2Fx5OHpxg0gc+Xz2hDPwT6ZdZOCLfr58P/4NhsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748455101; c=relaxed/simple; bh=HA5ZQn5fQPLOOloa5F6rQaFQ9FTy8GVrXJ6ypXARzQk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GjNgl76thxEr6MQqypogdnASW0sSb5D8H/oTVZOyPit7lwfNt/aNeczi+sHiMNuBJOmMdfVXq22GbOvTLaUUPl2tsaz8l9vmAdvy0JLp8EeAuELshdD+qlvRX5kWmnj6Zh7BAGVabQc94Q36O/JNPR551LgmBOefMv4ejfrq88M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=fVxEhKAY; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fVxEhKAY" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-549b116321aso6423665e87.3 for ; Wed, 28 May 2025 10:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1748455097; x=1749059897; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tCuIJR/iChkHw0yEIzz8Ln6RB6qmCdhlawG29rZoR8U=; b=fVxEhKAYkteC/GmhLOQRS9CdyTGTW7VFyGZ5pGSaPKQBvO83pUc3JAhf6erkAJxYKq pApgD6o10uMLuJ3EJuZiwIqhRcyri0moiUsULKc7waR6VaYzseDI0eV6mA1Iwlcy2iGX UPc+mOZVOz60NuwcvXgtXcipml+gc6442gtCY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748455097; x=1749059897; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tCuIJR/iChkHw0yEIzz8Ln6RB6qmCdhlawG29rZoR8U=; b=Hrl11GuEaPmjLMMTZ9CHSCloGbmLjxfAPfiQEfT/fxcQ1m9Qe7N1yrhCg4jTrO8JD4 JwwGaeYVKNc6mDHaU+gMIaLQxJqUM4R6VSjYL9nv8TAJ1RvRwZ1wJ46q6p75cuJ5vMRx ikZUivyhqfIQK22lnch74shfXST1DViPyLeJOTDwgL/BmGtfCEICFmah7eOAd710u9Fx apPRV+rLC+ZSj6A44NZR9Z9femRNWqEc06CfZ6cMy3UbDx5MVULCKua0AfpjNR7amBMx HoUpdJJTEW7YPPSqwZLiwAN5lGGwPm107KY0OlAbWCZvnbn+fvEjT3SB71H+0IrAtBOB D56Q== X-Gm-Message-State: AOJu0YwJis9YRpXYbjZ0H7I66mTfLITHPA6u31BuLniTdGjNQ/h6zxyd FNsCvp9y6Dl7su5eqH2JhrK4c1pEBcGDr1cHCTI0/JDi/TaaE9Z1uSUti66yOpZ+9Q== X-Gm-Gg: ASbGncuIcAlj1763CrPjmjAo2adOo8V1rBcyAsO9rMWUhQBifG8YBMwzxHTCJLr3ptS yMNjsEv0c+5uvBD+AcT7FTwDoYRyZs4AfW/m/+vZ0Go0iqRWpQ4i4ApmzvnDKPsTfW+NGp9IeiI OU1B99GH+8uyM8YofO8Oyig4xexZbabeRjsfV3QulgEP8d68cOHiGUJS6gamC2DHFkkziTZXdpX lyVOvkTbU1kTAR38CFi8bWmYeQK2fc4SZUNd6pcFYLOEL7MdptJooiRpVtl49NQT5Pr/zJ0OhMn O4NVqveXRiZvhU9LvaYaUS8NRWqxxRJ3ss20Iy6aZ6YghwswlxxDI2xbERT+H9vAFpqX2yd277T W8O6IPNQAIKvNtaSbPvyRuHHG3A== X-Google-Smtp-Source: AGHT+IEfb/5c0hVCUbJITUofOqtObUG+Si5mZBkEHtSmk+GA/XRbpdGOGTWRjSo++W26qr16iDNv9w== X-Received: by 2002:a05:6512:23aa:b0:553:2480:2309 with SMTP id 2adb3069b0e04-553248024ffmr3984960e87.3.1748455097320; Wed, 28 May 2025 10:58:17 -0700 (PDT) Received: from ribalda.c.googlers.com (90.52.88.34.bc.googleusercontent.com. [34.88.52.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5532f62a6eesm376805e87.98.2025.05.28.10.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 10:58:16 -0700 (PDT) From: Ricardo Ribalda Date: Wed, 28 May 2025 17:58:03 +0000 Subject: [PATCH 8/9] media: uvcvideo: Do not turn on the camera unless is needed Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250528-uvc-grannular-invert-v1-8-d01581f9cc25@chromium.org> References: <20250528-uvc-grannular-invert-v1-0-d01581f9cc25@chromium.org> In-Reply-To: <20250528-uvc-grannular-invert-v1-0-d01581f9cc25@chromium.org> To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 There are a lot of IOCTLs that do not need to turn on the camera. Eg: - They only operate to internal data, like UVCIOC_CTRL_MAP. - They are not applicable to the uvc driver, like VIDIOC_G_AUDIO. - They are handled by the uvc framework, like VIDIOC_STREAMON. Remove them from the turn-on list. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_v4l2.c | 57 ---------------------------------------- 1 file changed, 57 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c index e7373a2ae3c37ca02f9076773154901a603820ac..fcb1b79c214849ce4da96a86a688d777b32cc688 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -1291,75 +1291,18 @@ static long uvc_v4l2_unlocked_ioctl(struct file *file, /* The following IOCTLs do need to turn on the camera. */ switch (cmd) { - case UVCIOC_CTRL_MAP: case UVCIOC_CTRL_QUERY: - case VIDIOC_CROPCAP: - case VIDIOC_DBG_G_CHIP_INFO: - case VIDIOC_DBG_G_REGISTER: - case VIDIOC_DBG_S_REGISTER: - case VIDIOC_DECODER_CMD: - case VIDIOC_DQEVENT: - case VIDIOC_DV_TIMINGS_CAP: - case VIDIOC_ENCODER_CMD: - case VIDIOC_ENUMAUDIO: - case VIDIOC_ENUMAUDOUT: - case VIDIOC_ENUMOUTPUT: - case VIDIOC_ENUMSTD: - case VIDIOC_ENUM_DV_TIMINGS: - case VIDIOC_ENUM_FREQ_BANDS: - case VIDIOC_G_AUDIO: - case VIDIOC_G_AUDOUT: - case VIDIOC_G_CROP: case VIDIOC_G_CTRL: - case VIDIOC_G_DV_TIMINGS: - case VIDIOC_G_EDID: - case VIDIOC_G_ENC_INDEX: case VIDIOC_G_EXT_CTRLS: - case VIDIOC_G_FBUF: - case VIDIOC_G_FREQUENCY: case VIDIOC_G_INPUT: - case VIDIOC_G_JPEGCOMP: - case VIDIOC_G_MODULATOR: - case VIDIOC_G_OUTPUT: - case VIDIOC_G_PRIORITY: - case VIDIOC_G_SLICED_VBI_CAP: - case VIDIOC_G_STD: - case VIDIOC_G_TUNER: - case VIDIOC_LOG_STATUS: - case VIDIOC_OVERLAY: - case VIDIOC_PREPARE_BUF: - case VIDIOC_QUERYBUF: - case VIDIOC_QUERYCAP: case VIDIOC_QUERYCTRL: case VIDIOC_QUERYMENU: - case VIDIOC_QUERYSTD: - case VIDIOC_QUERY_DV_TIMINGS: case VIDIOC_QUERY_EXT_CTRL: - case VIDIOC_REMOVE_BUFS: - case VIDIOC_STREAMOFF: - case VIDIOC_STREAMON: - case VIDIOC_S_AUDIO: - case VIDIOC_S_AUDOUT: - case VIDIOC_S_CROP: case VIDIOC_S_CTRL: - case VIDIOC_S_DV_TIMINGS: - case VIDIOC_S_EDID: case VIDIOC_S_EXT_CTRLS: - case VIDIOC_S_FBUF: case VIDIOC_S_FMT: - case VIDIOC_S_FREQUENCY: - case VIDIOC_S_HW_FREQ_SEEK: case VIDIOC_S_INPUT: - case VIDIOC_S_JPEGCOMP: - case VIDIOC_S_MODULATOR: - case VIDIOC_S_OUTPUT: case VIDIOC_S_PARM: - case VIDIOC_S_PRIORITY: - case VIDIOC_S_SELECTION: - case VIDIOC_S_STD: - case VIDIOC_S_TUNER: - case VIDIOC_TRY_DECODER_CMD: - case VIDIOC_TRY_ENCODER_CMD: case VIDIOC_TRY_EXT_CTRLS: case VIDIOC_TRY_FMT: return uvc_v4l2_pm_ioctl(file, cmd, arg); -- 2.49.0.1266.g31b7d2e469-goog