From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C9D622D9EB; Wed, 4 Jun 2025 20:10:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749067812; cv=none; b=IT5bv41y5kgsaC8t9eunWMBQlAH4UV4b5xcRm3uBPijmnt4hQYX89s+P8+QK3NnUxW2er3rjQU1bBxSl+18+AeN6MhYksO0LpP/UZhsrZ4p9cxrx4lWvV540x3jW8vNCxv0yVOl5aQfoRRbsnF5n8qQBYAhu3oEv8sXLCMVIcLo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749067812; c=relaxed/simple; bh=JA52+QnvbuG3EENYM7JPRyaiysq+VkS9i9fM+g1A6bU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r58rF0pUVd4edVGPv4J68iKfX52prUBSAqi/5qmwmTpXvpvuCTGsrHU1OcfvDQiXgx9w4opg6WSW0DEtTqsNgEtBIL2KH+DjP+5WFJE0eFeP+xq6fIjz6icROMoSZrjxaxMvTqjaZaPk1ChVGQe/rJkUlO6o0LsmejAjKqZWGgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=LJPEJVvD; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="LJPEJVvD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1749067808; bh=JA52+QnvbuG3EENYM7JPRyaiysq+VkS9i9fM+g1A6bU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=LJPEJVvDRnf3DFmydzCHmJWaQ4mxNwo7hUrucAjedI04PXtyJr5NHsE4JEdOmKNjd UWWGAW8OTYDTFWWVoSGPi9gOXazR/ij2mrw4HoiQl3Q9lbcYq3oBPd0kwrTIWD6O/L l5GCAQ8/og+OwAYCtpm2c9caoYfEryHUgcf2UeZ+9aGTEhp9YI08unkln8LsNsNGg5 VU0gEpeDQKd6OG6mJiG4O0yYZ5XnRmpfGDDFa2c7MjG8dC8FFq9UMfXrbaPdyYI7Zd H0DLmQGJzUFSU/b+nVBfz5loagrpuVBT3n8X6etqqWAY/1AR8sc7MawIqx5lm47H4q maY7n/v7UCmkA== Received: from [192.168.13.145] (unknown [IPv6:2606:6d00:10:5285::5ac]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id D84AA17E378F; Wed, 4 Jun 2025 22:10:06 +0200 (CEST) From: Nicolas Dufresne Date: Wed, 04 Jun 2025 16:09:39 -0400 Subject: [PATCH v3 5/5] media: mtk-vcodec: Don't try to decode 422/444 VP9 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250604-sebastianfricke-vcodec_manual_request_completion_with_state_machine-v3-5-603db4749d90@collabora.com> References: <20250604-sebastianfricke-vcodec_manual_request_completion_with_state_machine-v3-0-603db4749d90@collabora.com> In-Reply-To: <20250604-sebastianfricke-vcodec_manual_request_completion_with_state_machine-v3-0-603db4749d90@collabora.com> To: Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Hans Verkuil , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, linux-media@vger.kernel.org, Sebastian Fricke , Nicolas Dufresne X-Mailer: b4 0.14.2 This is not supported by the hardware and trying to decode these leads to LAT timeout errors. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Nicolas Dufresne --- .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c index eea0050eacc1c41abd8e0a1cd546c1ecce90a311..65bd344a12f65d4cb3a81d34f41710f0089a2349 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c @@ -551,6 +551,12 @@ static int mtk_vdec_s_ctrl(struct v4l2_ctrl *ctrl) mtk_v4l2_vdec_err(ctx, "VP9: bit_depth:%d", frame->bit_depth); return -EINVAL; } + + if (!(frame->flags & V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING) || + !(frame->flags & V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING)) { + mtk_v4l2_vdec_err(ctx, "VP9: only 420 subsampling is supported"); + return -EINVAL; + } break; case V4L2_CID_STATELESS_AV1_SEQUENCE: seq = (struct v4l2_ctrl_av1_sequence *)hdr_ctrl->p_new.p; -- 2.49.0