From: kernel test robot <lkp@intel.com>
To: Bingbu Cao <bingbu.cao@intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-media@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: [sailus-media-tree:ipu7 7/7] drivers/staging/media/ipu7/ipu7-boot.c:212:6: warning: variable 'total_queue_size' set but not used
Date: Thu, 26 Jun 2025 11:08:03 +0800 [thread overview]
Message-ID: <202506261100.HLBItoq7-lkp@intel.com> (raw)
Hi Bingbu,
First bad commit (maybe != root cause):
tree: git://linuxtv.org/sailus/media_tree.git ipu7
head: 0542d88a01679ac03a980f7d53daefe8caebe345
commit: 0542d88a01679ac03a980f7d53daefe8caebe345 [7/7] media: staging/ipu7: add Makefile, Kconfig and to-do file for IPU7
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20250626/202506261100.HLBItoq7-lkp@intel.com/config)
compiler: clang version 20.1.7 (https://github.com/llvm/llvm-project 6146a88f60492b520a36f8f8f3231e15f3cc6082)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250626/202506261100.HLBItoq7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506261100.HLBItoq7-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/staging/media/ipu7/ipu7-boot.c:212:6: warning: variable 'total_queue_size' set but not used [-Wunused-but-set-variable]
212 | u32 total_queue_size = 0, total_queue_size_aligned = 0;
| ^
1 warning generated.
vim +/total_queue_size +212 drivers/staging/media/ipu7/ipu7-boot.c
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 206
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 207 int ipu7_boot_init_boot_config(struct ipu7_bus_device *adev,
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 208 struct syscom_queue_config *qconfigs,
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 209 int num_queues, u32 uc_freq,
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 210 dma_addr_t subsys_config, u8 major)
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 211 {
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 @212 u32 total_queue_size = 0, total_queue_size_aligned = 0;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 213 struct ipu7_syscom_context *syscom = adev->syscom;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 214 struct ia_gofo_boot_config *boot_config;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 215 struct syscom_queue_params_config *cfgs;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 216 struct device *dev = &adev->auxdev.dev;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 217 struct syscom_config_s *syscfg;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 218 dma_addr_t queue_mem_dma_ptr;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 219 void *queue_mem_ptr;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 220 unsigned int i;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 221
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 222 dev_dbg(dev, "boot config queues_nr: %d freq: %u sys_conf: 0x%pad\n",
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 223 num_queues, uc_freq, &subsys_config);
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 224 /* Allocate boot config. */
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 225 adev->boot_config_size =
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 226 sizeof(*cfgs) * num_queues + sizeof(*boot_config);
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 227 adev->boot_config = ipu7_dma_alloc(adev, adev->boot_config_size,
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 228 &adev->boot_config_dma_addr,
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 229 GFP_KERNEL, 0);
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 230 if (!adev->boot_config) {
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 231 dev_err(dev, "Failed to allocate boot config.\n");
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 232 return -ENOMEM;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 233 }
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 234
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 235 boot_config = adev->boot_config;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 236 memset(boot_config, 0, sizeof(struct ia_gofo_boot_config));
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 237 init_boot_config(boot_config, adev->boot_config_size, major);
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 238 boot_config->subsys_config = subsys_config;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 239
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 240 boot_config->uc_tile_frequency = uc_freq;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 241 boot_config->uc_tile_frequency_units =
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 242 IA_GOFO_FW_BOOT_UC_FREQUENCY_UNITS_MHZ;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 243 boot_config->syscom_context_config.max_output_queues =
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 244 syscom->num_output_queues;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 245 boot_config->syscom_context_config.max_input_queues =
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 246 syscom->num_input_queues;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 247
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 248 ipu7_dma_sync_single(adev, adev->boot_config_dma_addr,
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 249 adev->boot_config_size);
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 250
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 251 for (i = 0; i < num_queues; i++) {
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 252 u32 queue_size = qconfigs[i].max_capacity *
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 253 qconfigs[i].token_size_in_bytes;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 254
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 255 total_queue_size += queue_size;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 256 queue_size = ALIGN(queue_size, 64U);
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 257 total_queue_size_aligned += queue_size;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 258 qconfigs[i].queue_size = queue_size;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 259 }
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 260
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 261 /* Allocate queue memory */
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 262 syscom->queue_mem = ipu7_dma_alloc(adev, total_queue_size_aligned,
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 263 &syscom->queue_mem_dma_addr,
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 264 GFP_KERNEL, 0);
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 265 if (!syscom->queue_mem) {
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 266 dev_err(dev, "Failed to allocate queue memory.\n");
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 267 return -ENOMEM;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 268 }
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 269 syscom->queue_mem_size = total_queue_size_aligned;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 270
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 271 syscfg = &boot_config->syscom_context_config;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 272 cfgs = ipu7_syscom_get_queue_config(syscfg);
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 273 queue_mem_ptr = syscom->queue_mem;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 274 queue_mem_dma_ptr = syscom->queue_mem_dma_addr;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 275 for (i = 0; i < num_queues; i++) {
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 276 cfgs[i].token_array_mem = queue_mem_dma_ptr;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 277 cfgs[i].max_capacity = qconfigs[i].max_capacity;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 278 cfgs[i].token_size_in_bytes = qconfigs[i].token_size_in_bytes;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 279 qconfigs[i].token_array_mem = queue_mem_ptr;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 280 queue_mem_dma_ptr += qconfigs[i].queue_size;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 281 queue_mem_ptr += qconfigs[i].queue_size;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 282 }
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 283
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 284 ipu7_dma_sync_single(adev, syscom->queue_mem_dma_addr,
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 285 total_queue_size_aligned);
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 286
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 287 return 0;
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 288 }
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 289 EXPORT_SYMBOL_NS_GPL(ipu7_boot_init_boot_config, "INTEL_IPU7");
d9b3da4f62a7a18 Bingbu Cao 2025-05-29 290
:::::: The code at line 212 was first introduced by commit
:::::: d9b3da4f62a7a182b5689c5b822c43c5b4053fd4 media: staging/ipu7: add firmware parse, syscom interface and boot
:::::: TO: Bingbu Cao <bingbu.cao@intel.com>
:::::: CC: Sakari Ailus <sakari.ailus@linux.intel.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-06-26 3:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202506261100.HLBItoq7-lkp@intel.com \
--to=lkp@intel.com \
--cc=bingbu.cao@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox