Re: [PATCH v5 2/2] dma-buf: heaps: Introduce a new heap for reserved memory

Maxime Ripard
2025-06-30T08:52:08Z

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

On Fri, Jun 27, 2025 at 02:23:47PM -0500, Rob Herring wrote:
> > +static int __init carveout_heap_init(void)
> > +{
> > + struct device_node *rmem_node;
> > + struct device_node *node;
> > + int ret;
> > +
> > + rmem_node = of_find_node_by_path("/reserved-memory");
> > + if (!rmem_node)
> > + return 0;
> > +
> > + for_each_child_of_node(rmem_node, node) {
> > + if (!of_device_is_compatible(node, "carved-out"))
> > + continue;
> > +
> > + ret = carveout_heap_setup(node);
> > + if (ret)
> > + return ret;
> > + }
>
> /reserved-memory nodes get a platform_device, so why not make this a
> driver?

Because I never realised we could :)

Thanks, I'll fix it for the next version

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]