Re: [PATCH v5 2/2] dma-buf: heaps: Introduce a new heap for reserved memory

Charan Teja Kalla
2025-08-08T10:17:29Z

Hi Maxime,

On 6/17/2025 5:55 PM, Maxime Ripard wrote:
> +static void carveout_heap_dma_buf_release(struct dma_buf *buf)
> +{
> + struct carveout_heap_buffer_priv *buffer_priv = buf->priv;
> + struct carveout_heap_priv *heap_priv = buffer_priv->heap;
> + unsigned long len = buffer_priv->num_pages * PAGE_SIZE;
> +
> + gen_pool_free(heap_priv->pool, buffer_priv->paddr, len);

Just checking If clearing of the memory is missed before releasing it to
the free pool. If not, isn't it a leak of data when the heap is being
used by the multiple apps.

BTW, thanks for these patches.

> + kfree(buffer_priv);
> +}

-Charan