linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hansg@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Ricardo Ribalda <ribalda@chromium.org>
Cc: Hans de Goede <hansg@kernel.org>, linux-media@vger.kernel.org
Subject: [PATCH 0/1] media: uvcvideo: Use a count variable for meta_formats
Date: Tue,  8 Jul 2025 12:46:21 +0200	[thread overview]
Message-ID: <20250708104622.73237-1-hansg@kernel.org> (raw)

Hi,

I still was not entirely happy with how the meta_formats handling code
looked, especially not with uvc_meta_v4l2_enum_formats().

So here is a small patch / attempt to clean it up a bit.

Ricardo, assuming you're ok with the suggested changes can you give
this a test please ?

My main UVC test cam only supports standard UVC metadata which is
not helpful for testing (1), I did give this patch a spin with that
camera but that does not say much.

Regards,

Hans

1) It is a microsoft HD camera (but quite old) so I wonder if maybe
it does have the metadata but not the extended control for enabling it.
How would I test this ? 


Hans de Goede (1):
  media: uvcvideo: Use a count variable for meta_formats instead of 0
    terminating

 drivers/media/usb/uvc/uvc_metadata.c | 21 +++++++++------------
 drivers/media/usb/uvc/uvcvideo.h     |  4 ++--
 2 files changed, 11 insertions(+), 14 deletions(-)

-- 
2.49.0


             reply	other threads:[~2025-07-08 10:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-08 10:46 Hans de Goede [this message]
2025-07-08 10:46 ` [PATCH] media: uvcvideo: Use a count variable for meta_formats instead of 0 terminating Hans de Goede
2025-07-08 11:42   ` Ricardo Ribalda
2025-07-11 13:51     ` Hans de Goede
2025-07-11 17:15   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250708104622.73237-1-hansg@kernel.org \
    --to=hansg@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=ribalda@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).