[PATCH] media: uvcvideo: Fix assignment in if condition

[PATCH] media: uvcvideo: Fix assignment in if condition

[Darshan Rathod]

The function uvc_input_init() used an assignment of the return value
of input_register_device() within the condition of an if statement.

This coding style is discouraged by the Linux kernel coding style guide
as it can be confused with a comparison and hide potential bugs.
The checkpatch.pl script flags this as an error:
"ERROR: do not use assignment in if condition"

Separate the assignment into its own statement before the conditional
check to improve code readability and adhere to the kernel's
coding standards.

Signed-off-by: Darshan Rathod <darshanrathod475@gmail.com>
---
 drivers/media/usb/uvc/uvc_status.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/usb/uvc/uvc_status.c b/drivers/media/usb/uvc/uvc_status.c
index ee01dce4b783..3c29c0bb3f7c 100644
--- a/drivers/media/usb/uvc/uvc_status.c
+++ b/drivers/media/usb/uvc/uvc_status.c
@@ -62,7 +62,8 @@ static int uvc_input_init(struct uvc_device *dev)
 	__set_bit(EV_KEY, input->evbit);
 	__set_bit(KEY_CAMERA, input->keybit);
 
-	if ((ret = input_register_device(input)) < 0)
+	ret = input_register_device(input);
+	if (ret < 0)
 		goto error;
 
 	dev->input = input;
-- 
2.43.0

Re: [PATCH] media: uvcvideo: Fix assignment in if condition

[Laurent Pinchart]

Hi Darshan,

Thank you for the patch.

On Tue, Jul 15, 2025 at 11:30:56AM +0000, Darshan Rathod wrote:
> The function uvc_input_init() used an assignment of the return value

s/used/uses/

> of input_register_device() within the condition of an if statement.
> 
> This coding style is discouraged by the Linux kernel coding style guide
> as it can be confused with a comparison and hide potential bugs.
> The checkpatch.pl script flags this as an error:
> "ERROR: do not use assignment in if condition"
> 
> Separate the assignment into its own statement before the conditional
> check to improve code readability and adhere to the kernel's
> coding standards.
> 
> Signed-off-by: Darshan Rathod <darshanrathod475@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I'll update the commit message as mentioned above when applying, no need
for a v2.

> ---
>  drivers/media/usb/uvc/uvc_status.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_status.c b/drivers/media/usb/uvc/uvc_status.c
> index ee01dce4b783..3c29c0bb3f7c 100644
> --- a/drivers/media/usb/uvc/uvc_status.c
> +++ b/drivers/media/usb/uvc/uvc_status.c
> @@ -62,7 +62,8 @@ static int uvc_input_init(struct uvc_device *dev)
>  	__set_bit(EV_KEY, input->evbit);
>  	__set_bit(KEY_CAMERA, input->keybit);
>  
> -	if ((ret = input_register_device(input)) < 0)
> +	ret = input_register_device(input);
> +	if (ret < 0)
>  		goto error;
>  
>  	dev->input = input;

-- 
Regards,

Laurent Pinchart