From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C132C2DE6E8 for ; Fri, 18 Jul 2025 15:29:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752852556; cv=none; b=Cw5wHniXaZ6iJ03cHNukWty7S9xXbO5uB3af/T10svr2Tks94wjqwgfKRI2cxgIYc7XRr6YZafID7OIpFWh5zSIRiMPqAHtrOXeNyO1J60pLA1i+L61cS2HAGOjtjrkNM2breQepbtniK30qyiKMGlhcnau5Sxira2AQMwvUvnI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752852556; c=relaxed/simple; bh=uxVn8z5vNh8b0EqiZQiCnQQE1xnoXDxMYQl0MrMLYTg=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=usfbTHe03HozXxdg+V+WyOqDlBCtyVLgsXPuWz7t4/tYniAx6IfHGe+a0iAR6sJYW3Ol7/XBlCCdIRViMfvbUD1VPg2h89xEiEDLluqQGzt11LCfJvAexivTXp6ntclNHfWLERV+y/NiRG4fOsNckxaaV6YmGOS1VFXZvI+CxuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=eTPUcOZ3; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eTPUcOZ3" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-32b43846e8cso16361931fa.0 for ; Fri, 18 Jul 2025 08:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1752852553; x=1753457353; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=rpDHWMEfaZbT1j+vHvp6fYznBSkyjPMp+OhgKVI7GZI=; b=eTPUcOZ3ciPt0mrZ413bHiuaJmr3ydTd+HzDitI1AKvXznxqPY06Lc0os1FlBofQzm VqJrsipXemmiSDsKQP3xIZMlwIm7Q+p6kbKRFZ5+dNlCxAOX2Pi7AKT6IHhhSO13uAkL Hl5aTUvzRQqwl7ib04IjVMZ1fWTbyS27RCO9w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752852553; x=1753457353; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rpDHWMEfaZbT1j+vHvp6fYznBSkyjPMp+OhgKVI7GZI=; b=rB8FgBYozsuhTBjM8DPDSFgh2CB52/a+CTup3G9WjzEZOY33f463YEe8f5Qbn6NXOT zg4vl+xLlnCSS+BOApDqGtTFPwIkCD8QW9jqlIHg2e6ivvuGnd+nNn4NxSNSkV6SmwaJ RocCqvgolJESXIKSFbpUHwej8RTZ69BqiuObSfS+MUbcbvXbnc0BzHKHc+JgO7txuaF7 uPxdbMd4TSVqEj3FxYwjUjfre7h9/xyFBpzjHKSyKmAvK63WCq+PIUIWL0+ioMrtCOp2 8pHX2xizoHxz/Oq1C8ZIViHEsZBAxpDEMDwbP8Z2nKUAZ6a9Y3+B/7r255AoaFJRo9qh uO5Q== X-Forwarded-Encrypted: i=1; AJvYcCXSkc70XACxu92dukWkDGaSecShhr8H9y/FUWXBCYIqVnJQz2o6lo92x/IOQmBVVvLNhqoLCahg4tUkNQ==@vger.kernel.org X-Gm-Message-State: AOJu0YwE9bJ71BB/2Iamu4Z9wEtSQid8y71KXPC+9Rcae08D8flonB4o +RGTVZPWnwbWmgdO6KnM8LeOYwxSW4dEfKJQcLVZAIIi5RqAhokzKqlo6AH/wgGyjw== X-Gm-Gg: ASbGncvMfFfcqtsx6jYO2dWorDgA5m1wezx27s12BuEgpX2NnTdDsqL0bnfYmqvJOAN a9bHjNEXurPni4/79rWhR/TSUrJ4hreNKSARjWXF5LcQT2kLN9CG68t7GlVLN9Lxo8NEG9DfnPi +O+7dhvjtFZYyf0cF8CNisx4MvnOchwDjArPHi1I02PSegwmGUn1g9eXIh8ZRX0pW8oGnFuUKud XMc4dwiwFH/6sBy1+ebv//Oj+vcUU7DVScps5B17ODSPe6mhTT80R0TwQZE5MGHVOoY/hJoNAU7 AFVLuLTFksoxk2KgUqfLB5PYyAwsex8mRyg/K1VCOyWKRExER4cooMMvxsxw6MC5M1nOsKBa6Ct IvkUaWBD2HsoiTVZfLql2Yq6hXrUnxVM/h/vbVDo5w6FRLiXQJca4V10rU4krLRBz+RVUYyexQk LtQQ== X-Google-Smtp-Source: AGHT+IHCWWFRndQq5TQ10sqZoNxAVRRJdBRC8Iz2chXxrbesJiaBnj6t6V30lxJSk7p201wqjG9aTA== X-Received: by 2002:a2e:be12:0:b0:32a:c14b:7db9 with SMTP id 38308e7fff4ca-330a7ae47d7mr9316611fa.7.1752852552744; Fri, 18 Jul 2025 08:29:12 -0700 (PDT) Received: from ribalda.c.googlers.com (166.141.88.34.bc.googleusercontent.com. [34.88.141.166]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-330a91d9d6dsm2268601fa.83.2025.07.18.08.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jul 2025 08:29:12 -0700 (PDT) From: Ricardo Ribalda Subject: [PATCH v5 0/5] media: uvcvideo: Implement the Privacy GPIO as a evdev Date: Fri, 18 Jul 2025 15:29:09 +0000 Message-Id: <20250718-uvc-subdev-v5-0-a5869b071b0d@chromium.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAEVoemgC/23MSw6CMBSF4a2Yjq25tw8ojtyHcVDpRTpQTCuNx rB3C4kRDMNzku9/s0jBU2T7zZsFSj767paH3m5Y3drbhbh3eTMBQiFI4H2qeezPjhI3VaNUUVq As2YZ3AM1/jnFjqe8Wx8fXXhN7YTj+83gPJOQA7eFkRJrcq4Uh7oN3dX3110XLmwsJfHTCGahR dZGO2NBo5VOrmg50ygWWmYNZHUpnUKLZkWrmRZ6oVXWGgkU6Kpq0P7pYRg+AhwQAmEBAAA= X-Change-ID: 20241030-uvc-subdev-89f4467a00b5 To: Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus , Hans de Goede , Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Yunke Cao , linux-gpio@vger.kernel.org, linux-usb@vger.kernel.org, Ricardo Ribalda , Hans Verkuil , Hans de Goede X-Mailer: b4 0.14.2 Some notebooks have a button to disable the camera (not to be mistaken with the mechanical cover). This is a standard GPIO linked to the camera via the ACPI table. 4 years ago we added support for this button in UVC via the Privacy control. This has three issues: - If the camera has its own privacy control, it will be masked. - We need to power-up the camera to read the privacy control gpio. - Other drivers have not followed this approach and have used evdev. We fixed the power-up isses with "granular power saving", but the other issues are still open. This patchset implements the Privacy GPIO as a evdev. Signed-off-by: Ricardo Ribalda --- Changes in v5: - Drop UVC_GUID_EXT_GPIO_CONTROLLER - Remove merged patches and patches that will conflict with uvc-rotation - Rebase - Link to v4: https://lore.kernel.org/r/20241125-uvc-subdev-v4-0-51e040599f1a@chromium.org Changes in v4: - Remove gpio entity, it is not needed. - Use unit->gpio.irq in free_irq to make smatch happy. - Link to v3: https://lore.kernel.org/r/20241112-uvc-subdev-v3-0-0ea573d41a18@chromium.org Changes in v3: - CodeStyle (Thanks Sakari) - Re-implement as input device - Make the code depend on UVC_INPUT_EVDEV - Link to v2: https://lore.kernel.org/r/20241108-uvc-subdev-v2-0-85d8a051a3d3@chromium.org Changes in v2: - Rebase on top of https://patchwork.linuxtv.org/project/linux-media/patch/20241106-uvc-crashrmmod-v6-1-fbf9781c6e83@chromium.org/ - Create uvc_gpio_cleanup and uvc_gpio_deinit - Refactor quirk: do not disable irq - Change define number for MEDIA_ENT_F_GPIO - Link to v1: https://lore.kernel.org/r/20241031-uvc-subdev-v1-0-a68331cedd72@chromium.org --- Ricardo Ribalda (5): media: uvcvideo: Factor out gpio functions to its own file media: uvcvideo: Re-implement privacy GPIO as an input device media: uvcvideo: Introduce UVC_QUIRK_PRIVACY_DURING_STREAM media: uvcvideo: Make gpio_unit entity-less media: uvcvideo: Remove UVC_EXT_GPIO entity drivers/media/usb/uvc/Kconfig | 2 +- drivers/media/usb/uvc/Makefile | 3 + drivers/media/usb/uvc/uvc_ctrl.c | 20 ------ drivers/media/usb/uvc/uvc_driver.c | 135 ++--------------------------------- drivers/media/usb/uvc/uvc_entity.c | 1 - drivers/media/usb/uvc/uvc_gpio.c | 139 +++++++++++++++++++++++++++++++++++++ drivers/media/usb/uvc/uvc_status.c | 13 +++- drivers/media/usb/uvc/uvc_video.c | 4 ++ drivers/media/usb/uvc/uvcvideo.h | 38 ++++++---- include/linux/usb/uvc.h | 3 - 10 files changed, 185 insertions(+), 173 deletions(-) --- base-commit: d968e50b5c26642754492dea23cbd3592bde62d8 change-id: 20241030-uvc-subdev-89f4467a00b5 Best regards, -- Ricardo Ribalda