Re: [0/4] Remove the wl1273 FM Radio

Laurent Pinchart
2025-08-14T14:07:25Z

On Thu, Aug 14, 2025 at 01:57:38PM +0000, Dr. David Alan Gilbert wrote:
> * Laurent Pinchart (laurent.pinchart@ideasonboard.com) wrote:
> > On Sat, Aug 09, 2025 at 12:23:59AM +0000, Dr. David Alan Gilbert wrote:
> > > * Laurent Pinchart (laurent.pinchart@ideasonboard.com) wrote:
> > > > On Fri, Aug 08, 2025 at 02:09:56PM +0000, Dr. David Alan Gilbert wrote:
> > > > > * Laurent Pinchart (laurent.pinchart@ideasonboard.com) wrote:
> > > > > > On Thu, Jun 26, 2025 at 12:50:18PM +0000, Dr. David Alan Gilbert wrote:
> > > > > > > * Patchwork Integration (patchwork@media-ci.org) wrote:
> > > > > > > > Dear Dr. David Alan Gilbert:
> > > > > > > >
> > > > > > > > Thanks for your patches! Unfortunately the Media CI robot detected some
> > > > > > > > issues:
> > > > > > > >
> > > > > > > > # Test checkpatch:./0001-media-radio-wl1273-Remove.patch checkpatch
> > > > > > > > WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> > > > > > > > #7:
> > > > > > > > https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/
> > > > > > > >
> > > > > > > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> > > > > > > > #61:
> > > > > > > > deleted file mode 100644
> > > > > > > >
> > > > > > > > total: 0 errors, 2 warnings, 0 checks, 30 lines checked
> > > > > > >
> > > > > > > I did check that, couldn't find any appropriate MAINTAINERS entry anyway
> > > > > > >
> > > > > > > > # Test checkpatch:./0002-ASoC-wl1273-Remove.patch checkpatch
> > > > > > > > WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> > > > > > > > #7:
> > > > > > > > https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/
> > > > > > >
> > > > > > > Yep, said that in my cover letter; suggestions on how to refer to that URL
> > > > > > > in a better way are welcome.
> > > > > >
> > > > > > You can ignore those two warnings.
> > > > >
> > > > > Thanks for confirming that.
> > > > > Could you (or some other -media maintainer) pick 1/4 for linux-media please;
> > > > > Generally I think Lee tends only to pick the mfd specific bit up, so I need
> > > > > to get the specifics in through the other trees.
> > > >
> > > > We can take patch 1/4 in the media tree, but merging the different
> > > > pieces in an uncoordinated fashion will result in breakages in
> > > > linux-next :-/
> > >
> > > It should be safe to go in order; so you taking patch 1/4 should move
> > > things forward.
> >
> > 1/4 to 3/4 can be merged in any order, but 4/4 depends on the first
> > three patches getting merged first. The simplest option is to merge 1/4
> > to 3/4 for v6.18 through their respective trees, and 4/4 for v6.19. To
> > speed up merging 4/4 in v6.18 we need to coordinate between the three
> > subsystem maintainers.
>
> I see you've picked 1/4 up in -next - thanks!

I haven't, but Hans did :-)

> I'll give the sound folk a prod for 2/4.
> For 3/4 and 4/4 probably the easiest thing if we can get 2 in is if 3/4 and 4/4
> go in as a pair in 6.19.

3/4 could go in v6.18 already, it's only 4/4 that is bothersome.

> All this coordination thing seems to be rare!

It's not the most common case indeed, but it still happens routinely.

> > > > I think the simplest option would be to create a branch on top of v6.16
> > > > (or v6.17-rc1) with the 4 patches applied, and merge it in the media,
> > > > mfd and sound trees. That would require Lee to drop patches 3/4 and 4/4
> > > > that he already applied to the mfd tree though.
> > > >
> > > > > > > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> > > > > > > > #71:
> > > > > > > > deleted file mode 100644
> > > > > > > >
> > > > > > > > total: 0 errors, 2 warnings, 0 checks, 36 lines checked
> > > > > > > >
> > > > > > > > # Test checkpatch:./0003-mfd-wl1273-core-Remove.patch checkpatch
> > > > > > > > WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> > > > > > > > #8:
> > > > > > > > https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/
> > > > > > > >
> > > > > > > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> > > > > > > > #55:
> > > > > > > > deleted file mode 100644
> > > > > > > >
> > > > > > > > total: 0 errors, 2 warnings, 0 checks, 23 lines checked
> > > > > > > >
> > > > > > > > # Test checkpatch:./0004-mfd-wl1273-core-Remove-the-header.patch checkpatch
> > > > > > > > WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> > > > > > > > #7:
> > > > > > > > https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/
> > > > > > > >
> > > > > > > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> > > > > > > > #35:
> > > > > > > > deleted file mode 100644
> > > > > > > >
> > > > > > > > total: 0 errors, 2 warnings, 0 checks, 7 lines checked
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > Please fix your series, and upload a new version. If you have a patchwork
> > > > > > > > account, do not forget to mark the current series as Superseded.
> > > > > > > >
> > > > > > > > For more details, check the full report at:
> > > > > > > > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/79088843/artifacts/report.htm .
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > Best regards, and Happy Hacking!
> > > > > > > > Media CI robot on behalf of the linux-media community.
> > > > > > > >
> > > > > > > > ---
> > > > > > > > Check the latest rules for contributing your patches at:
> > > > > > > > https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> > > > > > > >
> > > > > > > > If you believe that the CI is wrong, kindly open an issue at
> > > > > > > > https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> > > > > > > > to this message.
> > > > > > > >

--
Regards,

Laurent Pinchart