* [PATCH] media: vsp1: Export missing vsp1_isp_free_buffer symbol
@ 2025-08-21 15:42 Laurent Pinchart
2025-08-21 18:29 ` Jacopo Mondi
2025-08-21 18:45 ` Niklas Söderlund
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Pinchart @ 2025-08-21 15:42 UTC (permalink / raw)
To: linux-media
Cc: linux-renesas-soc, Jacopo Mondi, Niklas Söderlund, stable
The vsp1_isp_free_buffer() function implemented by the vsp1 driver is
part of the API exposed to the rcar-isp driver. All other symbols except
that one are properly exported. Fix it.
Fixes: d06c1a9f348d ("media: vsp1: Add VSPX support")
Cc: stable@vger.kernel.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/media/platform/renesas/vsp1/vsp1_vspx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/renesas/vsp1/vsp1_vspx.c b/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
index a754b92232bd..1673479be0ff 100644
--- a/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
+++ b/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
@@ -286,6 +286,7 @@ void vsp1_isp_free_buffer(struct device *dev,
dma_free_coherent(bus_master, buffer_desc->size, buffer_desc->cpu_addr,
buffer_desc->dma_addr);
}
+EXPORT_SYMBOL_GPL(vsp1_isp_free_buffer);
/**
* vsp1_isp_start_streaming - Start processing VSPX jobs
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: vsp1: Export missing vsp1_isp_free_buffer symbol
2025-08-21 15:42 [PATCH] media: vsp1: Export missing vsp1_isp_free_buffer symbol Laurent Pinchart
@ 2025-08-21 18:29 ` Jacopo Mondi
2025-08-21 18:45 ` Niklas Söderlund
1 sibling, 0 replies; 3+ messages in thread
From: Jacopo Mondi @ 2025-08-21 18:29 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, linux-renesas-soc, Jacopo Mondi,
Niklas Söderlund, stable
Hi Laurent
On Thu, Aug 21, 2025 at 06:42:41PM +0300, Laurent Pinchart wrote:
> The vsp1_isp_free_buffer() function implemented by the vsp1 driver is
> part of the API exposed to the rcar-isp driver. All other symbols except
> that one are properly exported. Fix it.
>
> Fixes: d06c1a9f348d ("media: vsp1: Add VSPX support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Ups, thanks for fixing
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
> drivers/media/platform/renesas/vsp1/vsp1_vspx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_vspx.c b/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
> index a754b92232bd..1673479be0ff 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
> @@ -286,6 +286,7 @@ void vsp1_isp_free_buffer(struct device *dev,
> dma_free_coherent(bus_master, buffer_desc->size, buffer_desc->cpu_addr,
> buffer_desc->dma_addr);
> }
> +EXPORT_SYMBOL_GPL(vsp1_isp_free_buffer);
>
> /**
> * vsp1_isp_start_streaming - Start processing VSPX jobs
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: vsp1: Export missing vsp1_isp_free_buffer symbol
2025-08-21 15:42 [PATCH] media: vsp1: Export missing vsp1_isp_free_buffer symbol Laurent Pinchart
2025-08-21 18:29 ` Jacopo Mondi
@ 2025-08-21 18:45 ` Niklas Söderlund
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2025-08-21 18:45 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, linux-renesas-soc, Jacopo Mondi, stable
Hi Laurent,
Thanks for spotting this.
On 2025-08-21 18:42:41 +0300, Laurent Pinchart wrote:
> The vsp1_isp_free_buffer() function implemented by the vsp1 driver is
> part of the API exposed to the rcar-isp driver. All other symbols except
> that one are properly exported. Fix it.
>
> Fixes: d06c1a9f348d ("media: vsp1: Add VSPX support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/media/platform/renesas/vsp1/vsp1_vspx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_vspx.c b/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
> index a754b92232bd..1673479be0ff 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_vspx.c
> @@ -286,6 +286,7 @@ void vsp1_isp_free_buffer(struct device *dev,
> dma_free_coherent(bus_master, buffer_desc->size, buffer_desc->cpu_addr,
> buffer_desc->dma_addr);
> }
> +EXPORT_SYMBOL_GPL(vsp1_isp_free_buffer);
>
> /**
> * vsp1_isp_start_streaming - Start processing VSPX jobs
> --
> Regards,
>
> Laurent Pinchart
>
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-21 18:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-21 15:42 [PATCH] media: vsp1: Export missing vsp1_isp_free_buffer symbol Laurent Pinchart
2025-08-21 18:29 ` Jacopo Mondi
2025-08-21 18:45 ` Niklas Söderlund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).