From: Dikshita Agarwal <quic_dikshita@quicinc.com>
To: Vikash Garodia <quic_vgarodia@quicinc.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Stefan Schmidt <stefan.schmidt@linaro.org>,
Vedang Nagar <quic_vnagar@quicinc.com>,
"Hans Verkuil" <hverkuil@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Renjiang Han <quic_renjiang@quicinc.com>,
Wangao Wang <quic_wangaow@quicinc.com>,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: [PATCH v4 18/26] media: iris: Add encoder support for V4L2 event subscription
Date: Mon, 25 Aug 2025 12:30:42 +0530 [thread overview]
Message-ID: <20250825-iris-video-encoder-v4-18-84aa2bc0a46b@quicinc.com> (raw)
In-Reply-To: <20250825-iris-video-encoder-v4-0-84aa2bc0a46b@quicinc.com>
Implement support for V4L2 event subscription on the encoder device by
handling the SUBSCRIBE_EVENT and UNSUBSCRIBE_EVENT ioctls with the
necessary hooks.
This enables userspace applications to subscribe to V4L2 events,
allowing asynchronous notification mechanisms.
Tested-by: Vikash Garodia <quic_vgarodia@quicinc.com> # X1E80100
Reviewed-by: Vikash Garodia <quic_vgarodia@quicinc.com>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-HDK
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
---
drivers/media/platform/qcom/iris/iris_venc.c | 14 ++++++++++++++
drivers/media/platform/qcom/iris/iris_venc.h | 1 +
drivers/media/platform/qcom/iris/iris_vidc.c | 9 ++++++++-
3 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/iris/iris_venc.c b/drivers/media/platform/qcom/iris/iris_venc.c
index 55938050249fa1a041b835214e79028ae0b35e36..384b30555546f2a0677e49400f177b96611f866b 100644
--- a/drivers/media/platform/qcom/iris/iris_venc.c
+++ b/drivers/media/platform/qcom/iris/iris_venc.c
@@ -3,6 +3,7 @@
* Copyright (c) 2022-2025 Qualcomm Innovation Center, Inc. All rights reserved.
*/
+#include <media/v4l2-event.h>
#include <media/v4l2-mem2mem.h>
#include "iris_buffer.h"
@@ -286,3 +287,16 @@ int iris_venc_validate_format(struct iris_inst *inst, u32 pixelformat)
return 0;
}
+
+int iris_venc_subscribe_event(struct iris_inst *inst,
+ const struct v4l2_event_subscription *sub)
+{
+ switch (sub->type) {
+ case V4L2_EVENT_EOS:
+ return v4l2_event_subscribe(&inst->fh, sub, 0, NULL);
+ case V4L2_EVENT_CTRL:
+ return v4l2_ctrl_subscribe_event(&inst->fh, sub);
+ default:
+ return -EINVAL;
+ }
+}
diff --git a/drivers/media/platform/qcom/iris/iris_venc.h b/drivers/media/platform/qcom/iris/iris_venc.h
index 04fd41275547c40c359c6ea04dfe4ee31d2d0df6..2d9614ae18e8a2318df6673fbeae5ee33c99b596 100644
--- a/drivers/media/platform/qcom/iris/iris_venc.h
+++ b/drivers/media/platform/qcom/iris/iris_venc.h
@@ -14,5 +14,6 @@ int iris_venc_enum_fmt(struct iris_inst *inst, struct v4l2_fmtdesc *f);
int iris_venc_try_fmt(struct iris_inst *inst, struct v4l2_format *f);
int iris_venc_s_fmt(struct iris_inst *inst, struct v4l2_format *f);
int iris_venc_validate_format(struct iris_inst *inst, u32 pixelformat);
+int iris_venc_subscribe_event(struct iris_inst *inst, const struct v4l2_event_subscription *sub);
#endif
diff --git a/drivers/media/platform/qcom/iris/iris_vidc.c b/drivers/media/platform/qcom/iris/iris_vidc.c
index 92a616787a30a51f4fbf4760badffd6fabc48cc6..5d9b36858e9317b1eddac12004432229e18967a7 100644
--- a/drivers/media/platform/qcom/iris/iris_vidc.c
+++ b/drivers/media/platform/qcom/iris/iris_vidc.c
@@ -487,7 +487,12 @@ static int iris_subscribe_event(struct v4l2_fh *fh, const struct v4l2_event_subs
{
struct iris_inst *inst = container_of(fh, struct iris_inst, fh);
- return iris_vdec_subscribe_event(inst, sub);
+ if (inst->domain == DECODER)
+ return iris_vdec_subscribe_event(inst, sub);
+ else if (inst->domain == ENCODER)
+ return iris_venc_subscribe_event(inst, sub);
+
+ return -EINVAL;
}
static int iris_dec_cmd(struct file *filp, void *fh,
@@ -582,6 +587,8 @@ static const struct v4l2_ioctl_ops iris_v4l2_ioctl_ops_enc = {
.vidioc_enum_framesizes = iris_enum_framesizes,
.vidioc_enum_frameintervals = iris_enum_frameintervals,
.vidioc_querycap = iris_querycap,
+ .vidioc_subscribe_event = iris_subscribe_event,
+ .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
};
void iris_init_ops(struct iris_core *core)
--
2.34.1
next prev parent reply other threads:[~2025-08-25 7:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 7:00 [PATCH v4 00/26] Enable H.264/H.265 encoder support and fixes in iris driver common code Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 01/26] media: iris: Fix buffer count reporting in internal buffer check Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 02/26] media: iris: Report unreleased PERSIST buffers on session close Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 03/26] media: iris: Fix memory leak by freeing untracked persist buffer Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 04/26] media: iris: Fix port streaming handling Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 05/26] media: iris: Allow substate transition to load resources during output streaming Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 06/26] media: iris: Always destroy internal buffers on firmware release response Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 07/26] media: iris: Update vbuf flags before v4l2_m2m_buf_done Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 08/26] media: iris: Simplify session stop logic by relying on vb2 checks Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 09/26] media: iris: Allow stop on firmware only if start was issued Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 10/26] media: iris: Send dummy buffer address for all codecs during drain Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 11/26] media: iris: Fix missing LAST flag handling " Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 12/26] media: iris: Fix format check for CAPTURE plane in try_fmt Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 13/26] media: iris: Add support for video encoder device Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 14/26] media: iris: Initialize and deinitialize encoder instance structure Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 15/26] media: iris: Add support for ENUM_FMT, S/G/TRY_FMT encoder Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 16/26] media: iris: Add support for ENUM_FRAMESIZES/FRAMEINTERVALS for encoder Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 17/26] media: iris: Add support for VIDIOC_QUERYCAP for encoder video device Dikshita Agarwal
2025-08-25 7:00 ` Dikshita Agarwal [this message]
2025-08-25 7:00 ` [PATCH v4 19/26] media: iris: Add support for G/S_SELECTION " Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 20/26] media: iris: Add support for G/S_PARM " Dikshita Agarwal
2025-09-03 10:05 ` [PATCH v4.1 " Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 21/26] media: iris: Add platform-specific capabilities " Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 22/26] media: iris: Add V4L2 streaming support " Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 23/26] media: iris: Set platform capabilities to firmware " Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 24/26] media: iris: Allocate and queue internal buffers " Dikshita Agarwal
2025-08-29 9:05 ` Bryan O'Donoghue
2025-08-29 18:06 ` Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 25/26] media: iris: Add support for buffer management ioctls for encoder device Dikshita Agarwal
2025-08-25 7:00 ` [PATCH v4 26/26] media: iris: Add support for drain sequence in encoder video device Dikshita Agarwal
2025-09-05 10:34 ` [PATCH v4 00/26] Enable H.264/H.265 encoder support and fixes in iris driver common code Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250825-iris-video-encoder-v4-18-84aa2bc0a46b@quicinc.com \
--to=quic_dikshita@quicinc.com \
--cc=abhinav.kumar@linux.dev \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_renjiang@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=quic_vnagar@quicinc.com \
--cc=quic_wangaow@quicinc.com \
--cc=stefan.schmidt@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).