From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A66C22D47FA for ; Mon, 25 Aug 2025 09:51:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756115488; cv=none; b=C+yjVbJ/yxpE6CaQFCAlTE4vA8aTXo3Lw3FLcigY2/4Gu+TTxwwvcTgBMD20YOucuFHHLFDhSyWPcCdtvUu2j2u0ABLv9g3n8nPLucujeysOJnLpvkMOEwE9bolU97ZdbGgD/of1wVAHGjrVRDeLtqb7XfW6vzkVRhHpQfMST+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756115488; c=relaxed/simple; bh=BGZc/wGUCzmkAsrkk3y0NzymRQ1pceAtC+EhpyCOu24=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eeQxlZZd0fZbEJyvTy9muWMdQww07DOK5Ijm6hsoIkaQagA1U0HOK+cPbPgNaYrU0FU4U1KdSfMH72+FwQr/5PWb85BRDa907usaHxPigDoNFgw30Umsmz865v6B+qYfCXrhTBQ5S/ZkxqyfFQW/PBGB6truy7yVLgPG7zOSECw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JCbPLQTY; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JCbPLQTY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756115487; x=1787651487; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BGZc/wGUCzmkAsrkk3y0NzymRQ1pceAtC+EhpyCOu24=; b=JCbPLQTYlQxf/hfWNEU0hI6k3e3FDymlBTh+thaKoB/jxsRu8V3pRTas j58uQiqpmRKHXC2ewMCmjfOahWWVxWWkpBxXgFB+B88Bbz3l/KGVVV+Ux wlsPGxaWP9e/UVs5t6BZz35T3JpGzGneN2Nz5sCbIJWVW/le5HqtDkB// 0yXxCAlaPVM/aDx2r7uAYih/F5Jaa+Vj+8H11hpebGuuuwkXUY7c5ieXI MTSLk4TgIJ2K4k6+RCM7cOgbg1eX6tWWr5ODikvByTm3LcE3m9UBLxWIg QUik0mXPDwXHWCw9xOmnh1icrkoUtDTZrji4TPJKbQO0yee77dWEhhB7N A==; X-CSE-ConnectionGUID: 39KuCR1+SMOpXa3QJh+pCg== X-CSE-MsgGUID: C37+4T57TpOT36pv0oMA8Q== X-IronPort-AV: E=McAfee;i="6800,10657,11532"; a="69695785" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="69695785" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2025 02:51:26 -0700 X-CSE-ConnectionGUID: fFJ7zjbfSSyJ1ay3hg4apA== X-CSE-MsgGUID: aWe1Squ5TrGT+0cJsy2czw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="200195408" Received: from vpanait-mobl.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.7]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2025 02:51:19 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 1D8E9121F6D; Mon, 25 Aug 2025 12:51:08 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1uqTr2-00000005adZ-0KfD; Mon, 25 Aug 2025 12:51:08 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Alexander Shiyan , Dave Stevenson , Tommaso Merciai , Umang Jain , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , "Wang, Hongju" , Stefan Klug , Mirela Rabulea , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Stanislaw Gruszka , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen Subject: [PATCH v11 05/66] media: v4l2-subdev: Extend VIDIOC_SUBDEV_S_ROUTING error codes Date: Mon, 25 Aug 2025 12:50:06 +0300 Message-ID: <20250825095107.1332313-6-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250825095107.1332313-1-sakari.ailus@linux.intel.com> References: <20250825095107.1332313-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Return -ENXIO from routing configuration errors other than generic IOCTL argument validation. Signed-off-by: Sakari Ailus --- drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 2 +- drivers/media/platform/raspberrypi/rp1-cfe/csi2.c | 2 +- drivers/media/v4l2-core/v4l2-subdev.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c index ede6cc74c023..3c26cfef93d1 100644 --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c @@ -114,7 +114,7 @@ static int __mxc_isi_crossbar_set_routing(struct v4l2_subdev *sd, "invalid route from memory input (%u) to pipe %u\n", route->sink_pad, route->source_pad - xbar->num_sinks); - return -EINVAL; + return -ENXIO; } } diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/csi2.c b/drivers/media/platform/raspberrypi/rp1-cfe/csi2.c index 35c2ab1e2cd4..997b75aa5958 100644 --- a/drivers/media/platform/raspberrypi/rp1-cfe/csi2.c +++ b/drivers/media/platform/raspberrypi/rp1-cfe/csi2.c @@ -492,7 +492,7 @@ static int csi2_set_routing(struct v4l2_subdev *sd, const struct v4l2_subdev_route *route = &routing->routes[i]; if (route->source_stream != 0) - return -EINVAL; + return -ENXIO; } ret = v4l2_subdev_set_routing_with_fmt(sd, state, routing, diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c index 1da953629010..8d4c484109fb 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -2112,7 +2112,7 @@ int v4l2_subdev_routing_validate(struct v4l2_subdev *sd, { u32 *remote_pads = NULL; unsigned int i, j; - int ret = -EINVAL; + int ret = -ENXIO; if (disallow & (V4L2_SUBDEV_ROUTING_NO_STREAM_MIX | V4L2_SUBDEV_ROUTING_NO_MULTIPLEXING)) { -- 2.47.2