From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D66692E0B73 for ; Mon, 25 Aug 2025 09:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756115523; cv=none; b=LRFR60dDctqyYpZ5X3rvnigs66rZaTQBgRA+kTAePd/UCjCcMnfxVICfnE167i7VhD5CJT9EuIZbBquOpMGWc4zEj6eUbD3MWObNRku/dh3fE9qnBuCtMAgf21oNa0klP9aM82IlEAwGjUHPbES1o3xwnvuVojYynVf6l/8/UJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756115523; c=relaxed/simple; bh=8HJcfMcOOvD2BQv2SOLqsTBuHafldVIEOuAJr3++6m4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nKgK7Sok6/MykMSd55hSPuOCTrPN/SuzlJeQpEQPHy8F98yspIMI6oDE4VMTnEb8Oex7TlG3ozWjQaVJH6vyyRzwnSDbQJ56AXd1xRHW9DCZbVJ1F+gG8lRpVf2eMQPGAfneIksUJxqkccTfesamZgacQC0zk1k0hGF5uFU6uH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GHAMaJ88; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GHAMaJ88" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756115522; x=1787651522; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8HJcfMcOOvD2BQv2SOLqsTBuHafldVIEOuAJr3++6m4=; b=GHAMaJ88bcaSF6Jy45WWwmRtRR84heL2gh3JzczIZmwXNnehtU3rPNNK VrhaatOu/eUwxdxQ2FOTOSZxFaJ+iXDuQGew3RZb2TXyKT70JdXsYBWAt Fux9pGwUJyLPB7/h1mKhdmUk6BG/hF4Oywpnc5OKVXnrkzMylF+k+lvn5 jsqszfmM6uOfwAOW1R5gSVKckbD7pYWXyNHlie/OTbeJFWti4pPcG+8NM kQoR4yzFqr9YimtEcIJ0twFjZxz/ciZ7WqMRNAOoJx5y2FP36BobgDnoP tpjESJGx048HuFQf/XJx+GbyiJrWF3vJxQr9Gsy0y0Y0kaaYrnTE4p0pr A==; X-CSE-ConnectionGUID: YuhUziqAQwyXoAWftc8IkA== X-CSE-MsgGUID: Xh/EFxgQS8mYGtDoba3COw== X-IronPort-AV: E=McAfee;i="6800,10657,11532"; a="58032479" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="58032479" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2025 02:51:54 -0700 X-CSE-ConnectionGUID: sZOdu5FgQDmcmmdj/LOpuQ== X-CSE-MsgGUID: 1ZiHL8FRRbKdGP34pg5lOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="173431157" Received: from vpanait-mobl.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.7]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2025 02:51:47 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 4A66C12200E; Mon, 25 Aug 2025 12:51:09 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1uqTr3-00000005ai8-17BH; Mon, 25 Aug 2025 12:51:09 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: hans@jjverkuil.nl, laurent.pinchart@ideasonboard.com, Prabhakar , Kate Hsuan , Alexander Shiyan , Dave Stevenson , Tommaso Merciai , Umang Jain , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , "Wang, Hongju" , Stefan Klug , Mirela Rabulea , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Heimir Thor Sverrisson , Kieran Bingham , Stanislaw Gruszka , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen Subject: [PATCH v11 61/66] media: i2c: imx219: Report streams using frame descriptors Date: Mon, 25 Aug 2025 12:51:02 +0300 Message-ID: <20250825095107.1332313-62-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250825095107.1332313-1-sakari.ailus@linux.intel.com> References: <20250825095107.1332313-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Laurent Pinchart Implement the .get_frame_desc() subdev operation to report information about streams to the connected CSI-2 receiver. This is required to let the CSI-2 receiver driver know about virtual channels and data types for each stream. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Signed-off-by: Sakari Ailus --- drivers/media/i2c/imx219.c | 48 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index 136c084bb930..8ed1febc7b21 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -23,6 +23,7 @@ #include #include +#include #include #include #include @@ -678,6 +679,24 @@ static void imx219_free_controls(struct imx219 *imx219) * Subdev operations */ +static unsigned int imx219_format_bpp(u32 code) +{ + switch (code) { + case MEDIA_BUS_FMT_SRGGB8_1X8: + case MEDIA_BUS_FMT_SGRBG8_1X8: + case MEDIA_BUS_FMT_SGBRG8_1X8: + case MEDIA_BUS_FMT_SBGGR8_1X8: + return 8; + + case MEDIA_BUS_FMT_SRGGB10_1X10: + case MEDIA_BUS_FMT_SGRBG10_1X10: + case MEDIA_BUS_FMT_SGBRG10_1X10: + case MEDIA_BUS_FMT_SBGGR10_1X10: + default: + return 10; + } +} + static int imx219_set_framefmt(struct imx219 *imx219, struct v4l2_subdev_state *state) { @@ -1063,6 +1082,34 @@ static int imx219_get_selection(struct v4l2_subdev *sd, return -EINVAL; } +static int imx219_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad, + struct v4l2_mbus_frame_desc *fd) +{ + const struct v4l2_mbus_framefmt *fmt; + struct v4l2_subdev_state *state; + u32 code; + + if (pad != IMX219_PAD_SOURCE) + return -EINVAL; + + state = v4l2_subdev_lock_and_get_active_state(sd); + fmt = v4l2_subdev_state_get_format(state, IMX219_PAD_SOURCE, + IMX219_STREAM_IMAGE); + code = fmt->code; + v4l2_subdev_unlock_state(state); + + fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2; + fd->num_entries = 1; + + fd->entry[0].pixelcode = code; + fd->entry[0].stream = IMX219_STREAM_IMAGE; + fd->entry[0].bus.csi2.vc = 0; + fd->entry[0].bus.csi2.dt = imx219_format_bpp(code) == 8 ? + MIPI_CSI2_DT_RAW8 : MIPI_CSI2_DT_RAW10; + + return 0; +} + static int imx219_init_state(struct v4l2_subdev *sd, struct v4l2_subdev_state *state) { @@ -1113,6 +1160,7 @@ static const struct v4l2_subdev_pad_ops imx219_pad_ops = { .set_fmt = imx219_set_pad_format, .get_selection = imx219_get_selection, .enum_frame_size = imx219_enum_frame_size, + .get_frame_desc = imx219_get_frame_desc, .enable_streams = imx219_enable_streams, .disable_streams = imx219_disable_streams, }; -- 2.47.2