From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9201B302CB6 for ; Wed, 3 Sep 2025 13:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756907625; cv=none; b=BA1c6ex+Ilis9HVGi2rZRVYYcr+HyxXFO5M+w9U8dCnzkNdGls4OJg1OBt/P/7fE56NphPXvCDSw6vDkwiOJ4cOMGHGGOcrHN7VB/Oboo5EQ0hIQoyxidTymGtIZ06kE+xWM7PymP5MvgIAnay9aADWbjNjKhoZq0kZyZzif2rM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756907625; c=relaxed/simple; bh=bFmghQqy0ghYY1JhEcf/0fnhaJ+a+WfZRmvEimGtVR0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fOH4eEuvisigjC8/rxDK20oB0K+lcAt+ePPgpSZlQUoX9YKOx094shjI9zsrrt2Uo3scEeYkX5FW3HMZI7WOKSmRF+xvnVtaDNIW+gpmS+LEo8SYye3fdDs8mDMG8YsXtC8MWPchdxU7vTk8an55f9hTjm/LbsblVJ2LK5ik/7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=P99YDGze; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="P99YDGze" Received: from pendragon.ideasonboard.com (230.215-178-91.adsl-dyn.isp.belgacom.be [91.178.215.230]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id DF282842; Wed, 3 Sep 2025 15:52:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1756907552; bh=bFmghQqy0ghYY1JhEcf/0fnhaJ+a+WfZRmvEimGtVR0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P99YDGzecEtZddmvi+px/bL0P+VZ3LH/KH6JL4jkkEVT0ChI5qi6+8LWTUYM1ijxH qVxunsu0agWs5SbbRoxwiT5RtjIkLs1TvRYkNP0lUYshU3suhsE6aZp9ul5H+9BHPa dSKv9R7CxHfEObrgG7XRRS8ubC5ReY+j7dYlJ93w= Date: Wed, 3 Sep 2025 15:53:20 +0200 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, Prabhakar , Kate Hsuan , Alexander Shiyan , Dave Stevenson , Tommaso Merciai , Umang Jain , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , "Wang, Hongju" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Stanislaw Gruszka , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen Subject: Re: [PATCH v11 05/66] media: v4l2-subdev: Extend VIDIOC_SUBDEV_S_ROUTING error codes Message-ID: <20250903135320.GH3648@pendragon.ideasonboard.com> References: <20250825095107.1332313-1-sakari.ailus@linux.intel.com> <20250825095107.1332313-6-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250825095107.1332313-6-sakari.ailus@linux.intel.com> Hi Sakari, On Mon, Aug 25, 2025 at 12:50:06PM +0300, Sakari Ailus wrote: > Return -ENXIO from routing configuration errors other than generic IOCTL > argument validation. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 2 +- > drivers/media/platform/raspberrypi/rp1-cfe/csi2.c | 2 +- > drivers/media/v4l2-core/v4l2-subdev.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > index ede6cc74c023..3c26cfef93d1 100644 > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > @@ -114,7 +114,7 @@ static int __mxc_isi_crossbar_set_routing(struct v4l2_subdev *sd, > "invalid route from memory input (%u) to pipe %u\n", > route->sink_pad, > route->source_pad - xbar->num_sinks); > - return -EINVAL; > + return -ENXIO; > } > } > > diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/csi2.c b/drivers/media/platform/raspberrypi/rp1-cfe/csi2.c > index 35c2ab1e2cd4..997b75aa5958 100644 > --- a/drivers/media/platform/raspberrypi/rp1-cfe/csi2.c > +++ b/drivers/media/platform/raspberrypi/rp1-cfe/csi2.c > @@ -492,7 +492,7 @@ static int csi2_set_routing(struct v4l2_subdev *sd, > const struct v4l2_subdev_route *route = &routing->routes[i]; > > if (route->source_stream != 0) > - return -EINVAL; > + return -ENXIO; > } > > ret = v4l2_subdev_set_routing_with_fmt(sd, state, routing, > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c > index 1da953629010..8d4c484109fb 100644 > --- a/drivers/media/v4l2-core/v4l2-subdev.c > +++ b/drivers/media/v4l2-core/v4l2-subdev.c > @@ -2112,7 +2112,7 @@ int v4l2_subdev_routing_validate(struct v4l2_subdev *sd, > { > u32 *remote_pads = NULL; > unsigned int i, j; > - int ret = -EINVAL; > + int ret = -ENXIO; > > if (disallow & (V4L2_SUBDEV_ROUTING_NO_STREAM_MIX | > V4L2_SUBDEV_ROUTING_NO_MULTIPLEXING)) { -- Regards, Laurent Pinchart