From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EE003126CE for ; Wed, 3 Sep 2025 15:11:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756912281; cv=none; b=Nj0UE2JzXiEJncMvP2pC0dDOdJr9Ag3vNqrOXSXVJP+Yi/VunjCspzITwXUqSIlx1dyljrC8he5z6abOKrleytkPtFsbI4r20Ig7xPOmKtoDO0f2Mjp2OulstIHXYdbiXwj7hyXXp8DwZGXEk/gQ85brDFTWWozQrsY+tIPlsow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756912281; c=relaxed/simple; bh=QTeBnku6UmWV5CxCVL+cwIMTrrWzOH4MbjoQn1vQnws=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RLoSV5LhEnKkRo8ZrqRS9Zv5ySndGThAcytFZvFbjDjhyVSLdPoTPL4gKxjMND7a0ChdO4t6ubGrhZEE2dj/3dARz0qmbFgAK6TJI0kaicmYF1/rec9Icb8B3/CeXNogaJe/EEqrkoE7Z+g4cY9O8XlxG+mftZiF2NmfDs3OjR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=CbN6E38K; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CbN6E38K" Received: from pendragon.ideasonboard.com (230.215-178-91.adsl-dyn.isp.belgacom.be [91.178.215.230]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A0068664; Wed, 3 Sep 2025 17:10:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1756912209; bh=QTeBnku6UmWV5CxCVL+cwIMTrrWzOH4MbjoQn1vQnws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CbN6E38KT7H35jdeCpfSq352O4ZbOoRSxPbV/65ONqNHFoPvs7+EPwezCM2wa7w2v qWuphAGm9g+OxVXZAZjOrki0QuRrpcAcA/O8sg52+98XnjNfIHY6+iZM1G7+jnPk66 /V2fQOVfxfxPOMJSAEt6zcKJRv2YSA/jSdSwP4P0= Date: Wed, 3 Sep 2025 17:10:58 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: Sakari Ailus , linux-media@vger.kernel.org, hans@jjverkuil.nl, Prabhakar , Kate Hsuan , Alexander Shiyan , Dave Stevenson , Tommaso Merciai , Umang Jain , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , "Wang, Hongju" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Stanislaw Gruszka , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Tomi Valkeinen Subject: Re: [PATCH v11 20/66] media: Documentation: Reference COLOR_PATTERN control in raw format docs Message-ID: <20250903151058.GQ3648@pendragon.ideasonboard.com> References: <20250825095107.1332313-1-sakari.ailus@linux.intel.com> <20250825095107.1332313-21-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Wed, Sep 03, 2025 at 02:03:39PM +0200, Jacopo Mondi wrote: > On Wed, Sep 03, 2025 at 01:03:01PM +0300, Sakari Ailus wrote: > > On Mon, Sep 01, 2025 at 04:21:53PM +0200, Jacopo Mondi wrote: > > > On Mon, Aug 25, 2025 at 12:50:21PM +0300, Sakari Ailus wrote: > > > > Add a reference to the V4L2_CID_COLOR_PATTERN control in the generic raw > > > > pixelformat documentation. > > > > > > > > Signed-off-by: Sakari Ailus > > > > --- > > > > .../userspace-api/media/v4l/ext-ctrls-image-source.rst | 2 ++ > > > > Documentation/userspace-api/media/v4l/subdev-formats.rst | 3 +++ > > > > 2 files changed, 5 insertions(+) > > > > > > > > diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst > > > > index b19aaaffbce0..0fcd60d8c621 100644 > > > > --- a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst > > > > +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst > > > > @@ -93,6 +93,8 @@ Image Source Control IDs > > > > is reported as being (say) 128, then a value of 192 would represent > > > > a gain of exactly 1.5. > > > > > > > > +.. _image-source-control-color-pattern: > > > > + I'd move this to the previous patch. > > > > ``V4L2_CID_COLOR_PATTERN (integer)`` > > > > This control determines the color components and native pixel order in the > > > > sensor's CFA (Color Filter Array) when used in conjunction with > > > > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst > > > > index e77b4ad19737..77571adeb21e 100644 > > > > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst > > > > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst > > > > @@ -3444,6 +3444,9 @@ camera sensors using Bayer and other Colour Filter Arrays (CFAs) on serial > > > > interfaces. The packing of the data on the bus is determined by the hardware, > > > > however the bit depth is still specific to the format. > > > > > > > > +The colour components and the native pixel order are determined by the > > > > > > Isn't > > > +The native colour components ordering are determined by ... > > > > > > As I don't see how "colour components and the native pixel order" > > > information can be conveyed separately. > > > > How about: > > > > The native Colour Filter Array (CFA) pattern is determined by the Reviewed-by: Laurent Pinchart > Works for me, thanks! > > > > Up to you > > > > > > Reviewed-by: Jacopo Mondi > > > > > > > +:ref:`V4L2_CID_COLOR_PATTERN ` control. > > > > + > > > > .. tabularcolumns:: |p{2.0cm}|p{4.0cm}|p{11.3cm}| > > > > > > > > .. cssclass:: longtable -- Regards, Laurent Pinchart