From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 744DC2EC54A for ; Wed, 3 Sep 2025 21:36:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756935395; cv=none; b=RKPGrISRe6bzCasf2xUDppX7bKb1aBU68ke9TGtqzpuP/0D53vPV/kUkvcLxOTSYTukPsq+/ORmQi2hYOsQCjlm6zAIkMZ9tE8JoC7kbFZJGvLsn2hsGLlW5INj4l2YF73PxpitmRAvYrqqz4ZoZZRDkYZad/NYTcL1tE5yknxQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756935395; c=relaxed/simple; bh=c+fBME9jIM/veu83UkRmbUpK3LDym/71f4gp1S0tqKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NIl0CESajPsVdxY3Wvw5/TdUvXUpcLiWAD0arCcz2bYDBxiAkbsHSSMxBjPh3SEKd5GqNYCmE3ujJ4m3yC5fRMHkupF6cfSa+s0I4cxpXphOTr4IZtf7i/GGkgDnkE0dHR/fqtKZJKAukYjSfhKxrHWNUPsi/eXPIGVxVS+wuE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=fmp3petb; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fmp3petb" Received: from pendragon.ideasonboard.com (230.215-178-91.adsl-dyn.isp.belgacom.be [91.178.215.230]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9D3396F3; Wed, 3 Sep 2025 23:35:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1756935321; bh=c+fBME9jIM/veu83UkRmbUpK3LDym/71f4gp1S0tqKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fmp3petbkNSTTiuqb/EomvVJwIo3tvAo+gW+CCT/2lAFhw1mX1QU2Hbc/Z8wqC8Sr mQuadt+qBHBVyjY84ySv4YUipzgAF7/U6JBQmXhQFMdVYm7kj7UV3hSLgadnkBZsWW 65VIxdqmttInS/AZPJlAPx+srh5wvGu6r/rVG2KU= Date: Wed, 3 Sep 2025 23:36:09 +0200 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, hans@jjverkuil.nl, Prabhakar , Kate Hsuan , Alexander Shiyan , Dave Stevenson , Tommaso Merciai , Umang Jain , Benjamin Mugnier , Sylvain Petinot , Christophe JAILLET , Julien Massot , Naushir Patuck , "Yan, Dongcheng" , "Cao, Bingbu" , "Qiu, Tian Shu" , "Wang, Hongju" , Stefan Klug , Mirela Rabulea , =?utf-8?B?QW5kcsOp?= Apitzsch , Heimir Thor Sverrisson , Kieran Bingham , Stanislaw Gruszka , Mehdi Djait , Ricardo Ribalda Delgado , Hans de Goede , Jacopo Mondi , Tomi Valkeinen Subject: Re: [PATCH v11 38/66] Revert "media: uapi: v4l: Don't expose generic metadata formats to userspace" Message-ID: <20250903213609.GC3648@pendragon.ideasonboard.com> References: <20250825095107.1332313-1-sakari.ailus@linux.intel.com> <20250825095107.1332313-39-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250825095107.1332313-39-sakari.ailus@linux.intel.com> On Mon, Aug 25, 2025 at 12:50:39PM +0300, Sakari Ailus wrote: > This reverts commit d69c8429ea80af02e89e5b3eecb78e417ad049c8. > > Make the generic metadata formats visible for the userspace again. "Now that the API has stabilized, make ..." > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart > --- > include/uapi/linux/videodev2.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 6a5d9ac7bdb9..2b2e070f272c 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -890,7 +890,6 @@ struct v4l2_pix_format { > #define V4L2_META_FMT_RPI_FE_CFG v4l2_fourcc('R', 'P', 'F', 'C') /* PiSP FE configuration */ > #define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S') /* PiSP FE stats */ > > -#ifdef __KERNEL__ > /* > * Line-based metadata formats. Remember to update v4l_fill_fmtdesc() when > * adding new ones! > @@ -902,7 +901,6 @@ struct v4l2_pix_format { > #define V4L2_META_FMT_GENERIC_16 v4l2_fourcc('M', 'E', 'T', 'G') /* Generic 16-bit 8-bit metadata */ > #define V4L2_META_FMT_GENERIC_CSI2_20 v4l2_fourcc('M', 'E', 'C', 'K') /* 20-bit CSI-2 packed 8-bit metadata */ > #define V4L2_META_FMT_GENERIC_24 v4l2_fourcc('M', 'E', 'T', 'O') /* Generic 24-bit 8-bit metadata */ > -#endif > > /* priv field value to indicates that subsequent fields are valid. */ > #define V4L2_PIX_FMT_PRIV_MAGIC 0xfeedcafe -- Regards, Laurent Pinchart