From: Hans de Goede <hansg@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>
Cc: Hans de Goede <hansg@kernel.org>,
Aleksandrs Vinarskis <alex@vinarskis.com>,
platform-driver-x86@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: [PATCH v2 0/1] v4l2-subdev/int3472: Use "privacy" as con_id for the LED lookup
Date: Wed, 10 Sep 2025 12:47:01 +0200 [thread overview]
Message-ID: <20250910104702.7470-1-hansg@kernel.org> (raw)
Hi All,
During DT-binding review for extending the V4L2 camera sensor privacy LED
support to systems using devicetree, it has come up that having a "-led"
suffix for the LED name / con_id is undesirable since it already is clear
that it is a LED:
https://lore.kernel.org/linux-media/0e030e7d-0a1a-4a00-ba18-ed26107d07fa@oss.qualcomm.com/
There was discussion about making an exception for "privacy-led" since
that is already used on x86/ACPI platforms, but I'm afraid that will set
a bad example which ends up being copy and pasted, so lets just drop
the "-led" prefix from the x86/ACPI side, which we can do since there
this is only an in-kernel "API".
Changes in v2:
- Squash the changes into a single patch changing both places where
"privacy-led" is used to "privacy" in one go
Ilpo can you give your ack for this patch getting merged through
the linux-media tree?
Regards,
Hans
Hans de Goede (1):
media: v4l2-subdev / pdx86: int3472: Use "privacy" as con_id for the
privacy LED
drivers/media/v4l2-core/v4l2-subdev.c | 2 +-
drivers/platform/x86/intel/int3472/led.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.51.0
next reply other threads:[~2025-09-10 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 10:47 Hans de Goede [this message]
2025-09-10 10:47 ` [PATCH v2 1/1] media: v4l2-subdev / pdx86: int3472: Use "privacy" as con_id for the privacy LED Hans de Goede
2025-09-10 10:51 ` Ilpo Järvinen
2025-09-24 7:06 ` Aleksandrs Vinarskis
2025-09-24 9:58 ` Hans de Goede
2025-09-24 10:28 ` Sakari Ailus
2025-09-24 10:33 ` Hans de Goede
2025-09-25 16:04 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910104702.7470-1-hansg@kernel.org \
--to=hansg@kernel.org \
--cc=alex@vinarskis.com \
--cc=andy@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox