From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB09C22A4FE; Wed, 1 Oct 2025 11:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759318783; cv=none; b=EUrxrOiVGTUYbyKgMCX0lsWY4kbkzw/n665X7Efc6tQtWs2OZWLoHnXe1AKLVeJjwjGiT9uyQg/l+cMEx4dpB/OV0/YnyOGLRfKxjJGJ3aq5UVNntEyzKQWGnT651MUn+OzkvDCmtA30Aj2Qgct2D/YjpoKGZS7FLOIt+yfI79U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759318783; c=relaxed/simple; bh=Ezy7+mtT4eps9wTpBlbZkP1mFfCZBHTp5E+V6UHQD4c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UwuXmc6Gw7PvyRhIKXx+GtxFV0pLRzXaimW09uqODJCjKS92sOXfwvajbyOzBUtpFaW+ikS6vGbi/1tq833zIkrIIRSdeLa/GlxNzMda4V65pfKF16Hwl1pcssZI+6I6q0GN2GYxNoKHW25+yaOI2hwHBzaHPPBICdn2o5CT8yU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hyfhWXjK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hyfhWXjK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB4B8C4CEF4; Wed, 1 Oct 2025 11:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759318782; bh=Ezy7+mtT4eps9wTpBlbZkP1mFfCZBHTp5E+V6UHQD4c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hyfhWXjKKeqTsPAKqst9VMRZTuHnr79Sn85JR9oApnhJZe1TO5oXMimv1OZ2K5t1Q 9MiMpANH+0eOS4bcbwboljFqvrlf7T7uAAqpI3hYX8SgDpEKW89XvVN/UZ5DYJEoku FCsdu0jIgr5dBxYfu2TGJvAqsoQRkfMXMl/1F9lyU95/QyzDKaMdhpvL1V7Ya/B2mh pfedbt0u93fTYkQVaxWkIHD9fK5BbrTidNe/CqVFgP1WMiwVDvBVcc7cf3aq3rnWzp eISxrrXcYtNF0j6R+nLIOAcxLwM1v6bQ7c0J8gD109M3HZIzW3eQE3Urg+TrWFUG6k 2FEfVcfX3pxjQ== Date: Wed, 1 Oct 2025 14:39:37 +0300 From: Leon Romanovsky To: Alex Williamson Cc: Jason Gunthorpe , Andrew Morton , Bjorn Helgaas , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel@lists.freedesktop.org, iommu@lists.linux.dev, Jens Axboe , Joerg Roedel , kvm@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Logan Gunthorpe , Marek Szyprowski , Robin Murphy , Sumit Semwal , Vivek Kasireddy , Will Deacon Subject: Re: [PATCH v4 07/10] vfio/pci: Add dma-buf export config for MMIO regions Message-ID: <20251001113937.GH324804@unreal> References: <20250929151740.21f001e3.alex.williamson@redhat.com> <20250930075748.GF324804@unreal> <20250930100758.1605d5a5.alex.williamson@redhat.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250930100758.1605d5a5.alex.williamson@redhat.com> On Tue, Sep 30, 2025 at 10:07:58AM -0600, Alex Williamson wrote: > On Tue, 30 Sep 2025 10:57:48 +0300 > Leon Romanovsky wrote: > > > On Mon, Sep 29, 2025 at 03:17:40PM -0600, Alex Williamson wrote: > > > On Sun, 28 Sep 2025 17:50:17 +0300 > > > Leon Romanovsky wrote: > > > > > > > From: Leon Romanovsky > > > > > > > > Add new kernel config which indicates support for dma-buf export > > > > of MMIO regions, which implementation is provided in next patches. > > > > > > > > Signed-off-by: Leon Romanovsky > > > > --- > > > > drivers/vfio/pci/Kconfig | 20 ++++++++++++++++++++ > > > > 1 file changed, 20 insertions(+) > > > > > > > > diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig > > > > index 2b0172f54665..55ae888bf26a 100644 > > > > --- a/drivers/vfio/pci/Kconfig > > > > +++ b/drivers/vfio/pci/Kconfig > > > > @@ -55,6 +55,26 @@ config VFIO_PCI_ZDEV_KVM > > > > > > > > To enable s390x KVM vfio-pci extensions, say Y. > > > > > > > > +config VFIO_PCI_DMABUF > > > > + bool "VFIO PCI extensions for DMA-BUF" > > > > + depends on VFIO_PCI_CORE > > > > + depends on PCI_P2PDMA && DMA_SHARED_BUFFER > > > > + default y > > > > + help > > > > + Enable support for VFIO PCI extensions that allow exporting > > > > + device MMIO regions as DMA-BUFs for peer devices to access via > > > > + peer-to-peer (P2P) DMA. > > > > + > > > > + This feature enables a VFIO-managed PCI device to export a portion > > > > + of its MMIO BAR as a DMA-BUF file descriptor, which can be passed > > > > + to other userspace drivers or kernel subsystems capable of > > > > + initiating DMA to that region. > > > > + > > > > + Say Y here if you want to enable VFIO DMABUF-based MMIO export > > > > + support for peer-to-peer DMA use cases. > > > > + > > > > + If unsure, say N. > > > > + > > > > source "drivers/vfio/pci/mlx5/Kconfig" > > > > > > > > source "drivers/vfio/pci/hisilicon/Kconfig" > > > > > > This is only necessary if we think there's a need to build a kernel with > > > P2PDMA and VFIO_PCI, but not VFIO_PCI_DMABUF. Does that need really > > > exist? > > > > It is used to filter build of vfio_pci_dmabuf.c - drivers/vfio/pci/Makefile: > > vfio-pci-core-$(CONFIG_VFIO_PCI_DMABUF) += vfio_pci_dmabuf.o > > Maybe my question of whether it needs to exist at all is too broad. > Does it need to be a user visible Kconfig option? Where do we see the > need to preclude this feature from vfio-pci if the dependencies are > enabled? The dependencies are for the platform and not for the devices. For example, hisilicon device mentioned in other email doesn't support p2p, but the platform most likely support. I don't have strong feelings about this config and at least for our use case will always be enabled. I can hide it from the users. > > > > I also find it unusual to create the Kconfig before adding the > > > supporting code. Maybe this could be popped to the end or rolled into > > > the last patch if we decided to keep it. Thanks, > > > > It is leftover from previous version, I can squash it, but first we need > > to decide what to do with pcim_p2pdma_init() call, if it needs to be > > guarded or not. > > As in the other thread, I think it would be cleaner in an IS_ENABLED > branch. I'm tempted to suggest we filter out EOPNOTSUPP to allow it to > be unconditional, but I understand your point with the list_head > initialization. Thanks, We can add dmabuf list to struct unconditionally, as memory overhead is negligible. It will allow us to drop IS_ENABLED() too. Thanks > > Alex > >