From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C29DE2DC780 for ; Thu, 2 Oct 2025 08:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759394916; cv=none; b=snWDhalH/iaqO3/dhhVUvIBHKBv0saCX1MhMim1erRHjlb85rdmgCWv10SFUFsz2eyqfdeTwFYMrhmvY91yFCZBa/P2seV17UQ0cbK6livHZQEMr0dni2NtfoYccKteRPb+W+XLljBa+cqEClIe8hN9uH9q8+/nsKaxEa1B/EGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759394916; c=relaxed/simple; bh=5XEzoo2HfzAUhZ77KJ7gqJTgs1GrYseR5LL7SGMhOTE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=g+ZGhJaDoMDSxozQ12Bn69YohLcEPE/PUnVTZC6nPzAYNzqpQFR1XbHcvVbKZDtpFJk6kEi6B2AmyIhiqwoGF+Vpir7tu3oP4H5nuw8LFAc3Rwt8b+MJHSMu5PAmzz2tb4L0MvEAVDjsF2x4n+UkqBt5rLj/VHkR/FL/1okHwtQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GG2OsD2p; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GG2OsD2p" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-3737d09d123so8626991fa.2 for ; Thu, 02 Oct 2025 01:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759394913; x=1759999713; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=z69FFVofVQpQbXPazzIrMIWvZw9YVt4e5mOAMA1/qQ0=; b=GG2OsD2pj25nBWg2DiWnZDkj5WklapFP8mmyKqLDIERBYVpP4s9lpVjBPXTxTtUNjP xfqRoZvBkTg3GHZw9hujqER7iOEoGv3aAJ+LfoiraxAQ86L9l8IjHOv0SaASAOs5x7qb wxc3jw9Ga50WFDetpMKHXfc2WuCJvj54D2zkMje6zjb8fr2AB9GEk4B6fT9ShlP9UVaT R7Yz8IVyG63qqmI+ttb8e1jvEckV+kjdhPWDj6T2k/0+2wnog9VLigwu+5xSFI2W1IEr vVw+y8kp/NSYN7/LBmJokzkVM/KBMFBWm4SrA8t4rpyMTGyfZXMQNK66KeRM8LIOiDZm /g6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759394913; x=1759999713; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z69FFVofVQpQbXPazzIrMIWvZw9YVt4e5mOAMA1/qQ0=; b=JkYrFU120JZ3sQCnMQl/B9mlwrKN5NWpSG6FTkGetYpkdOK2sR9Kix7E2/PDB6qqTZ rBsLXE8WGkGIYGwg0KA8lQ2IW0m4/LeUmFZa62qGFJiFpPqTWAz4yPLOQQ43+1N++Aev yBjd3FvbDXSgal2AvnjuX6sN8AOgWB5Bfaetr8qtiE77Xz6N7AgBUx6zY/RXqDt+nriU soxpMRhdeghRAf7/C292209HJZjIGJdkABs9i/jTocAx8li3/I7tO/jWNGlwCcoqKadY YzY/mcDJSToSYtoWYeXvU2JzEZQhkXnTC0H4MeiqgtggsSQmeNs0pg0BZIeZi0bolzKG 8Ghw== X-Forwarded-Encrypted: i=1; AJvYcCWQ6zZaXwBdaeJxU4ivAzH7KByl/dMQ1T+YYjHMqNm4PLLl/H7vyoUuRAkmZe7TN6iLzfUYkN49u0DPZA==@vger.kernel.org X-Gm-Message-State: AOJu0YxuQFhiuEt9SZ1isTIdPX0/iySDG8rjKlo26KkeXquwL7fyMp4y bqYMBFsjIfK+bVl7v4zb3S2xgiVdcO08CRNJJe3ciF8WIJHpL+jkc4G9 X-Gm-Gg: ASbGncsz2bOGxaWscVQTnsGiq4EQ/OLzlW0zwAmYJM4Dzcpj5MbA1Mg4XLzlMYw9CS5 T0ngTZSSh1Xqf1LPBSUW/6CGpvzkv3mpq+FrKKgL4G8dyWa0zaUKydw0w9oVYH8XZil/dEW29GD 1QTo+pYfiXM04mxFNdOMM1+jeruU79ST6b/hqAlva6EoafyFc+/AXTrTu44jJSOaNmlZ1yv+RC0 vU61intLHVaGaMvGKNtD0KUbfmy5rm8mDyoVV8AvipkE+Nq0Ixjo6NG1vEIinuiasLFKoBykLjH UJ60y/PirYwTSOvudXY23JaOLO6MCPb3/wjEppen+5aW/xZW9v3XUHBZxjmJ45Vyw1D9mAqKaG+ eC8U2XW20RUXubj5+t9UKAmT4Z7Il1b+euVEIJXqnvOPkg6L+yO3t7xxEov3VcZZROWnvUjJlD0 ETCizuGfrQzqrHeQE8fAEec2Ft/xgRCmhQPs3QrvKJ X-Google-Smtp-Source: AGHT+IHSpWYO4jWecZ3WaJ5bbAKSHrzDEFpF/Bo9oTWfMoBxUJCFoeCGVTF74e3XeZ0egpGJ1oJ8eA== X-Received: by 2002:a2e:a912:0:b0:36d:501:76d8 with SMTP id 38308e7fff4ca-373a7430622mr20975301fa.31.1759394912620; Thu, 02 Oct 2025 01:48:32 -0700 (PDT) Received: from localhost.localdomain (broadband-109-173-93-221.ip.moscow.rt.ru. [109.173.93.221]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-373ba4cdf62sm5338621fa.51.2025.10.02.01.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 01:48:32 -0700 (PDT) From: Alexandr Sapozhnkiov To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Alexandr Sapozhnikov , linux-media@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH 5.10] gpu/i915: fix error return in mmap_offset_attach() Date: Thu, 2 Oct 2025 11:48:26 +0300 Message-ID: <20251002084828.11-1-alsp705@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Alexandr Sapozhnikov In the drm_vma_node_allow function, kmalloc may return NULL, in which case the file element will not be added to the mmo->vma_node list. It would be good to not ignore this event, but at least log an error message. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Alexandr Sapozhnikov --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c index a2195e28b625..adaef8f09d59 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c @@ -706,8 +706,11 @@ mmap_offset_attach(struct drm_i915_gem_object *obj, mmo = insert_mmo(obj, mmo); GEM_BUG_ON(lookup_mmo(obj, mmap_type) != mmo); out: - if (file) - drm_vma_node_allow_once(&mmo->vma_node, file); + if (file) { + err = drm_vma_node_allow_once(&mmo->vma_node, file); + if (err) + goto err; + } return mmo; err: -- 2.43.0