From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B198309DCE for ; Mon, 13 Oct 2025 14:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364926; cv=none; b=fkJ2k66MSzVExjXfbFP+FNVUOf1zQoeuFdDlVkMEglHIbVnJJqtyC5cJxaLAxmcBQ/sCOTHhmL5dclF82BiS7kbcFPfWVAA8jRM/TGlRmT+/XZKeNSWNM+IKWUFr1KitaYF6mCASpwjrC3ApXfpHZwk/osagUxL6ZJNBGJaS6AI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364926; c=relaxed/simple; bh=c9Kb2b0T3BLAmckMzo48k+Ue6UmlyuOLb1cyxCq4tlI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J1gUI71hMsAjo3UP7V3HFSYO+yHHO0MMGVxb+BVyAmZXFfMy5uMbwxLn4k80xPAkfvPd5QR3Mg+YuzCOylwQo6jSbD7jQRVbtRnB3rBflUO5/wpDIca6zdY4Egt+fo8qmw+jCMBgDDISdvrNcOyFNwGa65gDvqlhxrf9sBac7/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Obg8UI+A; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Obg8UI+A" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-586883eb9fbso5711828e87.1 for ; Mon, 13 Oct 2025 07:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1760364907; x=1760969707; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Smwvmk+cDkyGjYaS177QmxkSssvQt/cgmiOzwIecscI=; b=Obg8UI+AAndLMjNpmQNSR4pFxdQvBmATLrW0tjlJBW3Ga82UvE5E7Bd355kVGoaHO4 ttMWfRew/peUsFe5SIcszYqZy+eR2HHN2crwjPNUufybpRdiTHm0Bwnbfh/KyzTHuQqV O8YBh5SXSt+L03mH/Ayyllpx3mbN6eJlqmJrc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760364907; x=1760969707; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Smwvmk+cDkyGjYaS177QmxkSssvQt/cgmiOzwIecscI=; b=jlaH4a/0z6657oqKZsf1busvXnNwsfYVqJdq1SSPQaT362oJaV1fLRC3WP7T/5A6ZZ ZXm0wJQ+Ifj1+hKeGsLwIcVM64QE3AoAuL3TX6GQD/asKwH3OY8gerGSv7clVC5ZHhYS kObFNcRhQdleFzKgleUBuCboDK1W0KpHlnXGQagt9YFLPybdP2g40UROMNYRnDQy9jpQ Vph8fCDUrl8/bYoZAwedjSvnWmJQhQebtsrtMWiLxcO/H4SxTAEzKI6bR8pWrdKK/14d DRHuyGNX6y+nM71HlPFXmYRGbHL6l08fPlBuLTlRoEgzREhkTgw3UylegBUTAFcnxS3b 7deQ== X-Forwarded-Encrypted: i=1; AJvYcCWYMPoY/JDnLEOO7LuAdalUhOHlRRVShwxyPCJEZjpuFdJOV4HSfYNX1QioHibWqFGR8n2d+4jGcuMe8A==@vger.kernel.org X-Gm-Message-State: AOJu0Yxl7T0ALA/UJ5IPB48iAMITvW96Nb0Guqg2FOFiCyUMpJPlYDYl DVJ7bte4RglNz06ULTIEVbp5ACEcAuLlTAPHpRD408Qdxy8DU+qF3l37XpUrQdiOgQ== X-Gm-Gg: ASbGncuonJE5rdF5IrsNBC+iyNFXUMoBopw30I4WZhQyWxM8rhs44EtjZ5RS5a89P5H uplRZhQg24gSCVKrbGHYQfX5gr+4Fwg4x31wDUkMY+Pc0V6v9e/UqkVObrkjU71S8Ow5Y8p5AD0 0K2rEhO5P3v6JyL34rWyty6TFRyjjVSDHDzQL5/R/jGAhxKim5qfrilQzev9Um09rbIb/yiukof mDI7KrsX5or/xhyHmfR1StJcVRjnT3R5Bsp5j0qc56YCHrHIriPZuUnzG5hvK6iqLNmbd9RhwyU 4KijS7L/MNxxfvVxRp2GY1v/PvyBGhVnOM3+TqopXk3kSRL0NuOuhyvpfS+9Qc7Mtrrg7dv4xyX j5T2cevIwfh1bToIyoKoQiVJ/tOPQ9yIyEPDJxCHolGhHDnHKOB+VLAZikmrcvqk4+Ay8z5kIrI La+DmPbR4S0rrcvevxoQ== X-Google-Smtp-Source: AGHT+IG0XyykaxSpAJZEJBiMkxB//rHuKsliNYYIqdi4qrxeJQYdIviCb9iwNXvzzJnUAUziWI3Chw== X-Received: by 2002:a05:6512:ea9:b0:585:bc5e:237c with SMTP id 2adb3069b0e04-5906dafca4dmr5906081e87.49.1760364906745; Mon, 13 Oct 2025 07:15:06 -0700 (PDT) Received: from ribalda.c.googlers.com (56.213.88.34.bc.googleusercontent.com. [34.88.213.56]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590881e4e58sm4165256e87.25.2025.10.13.07.15.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 07:15:06 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 13 Oct 2025 14:15:09 +0000 Subject: [PATCH 29/32] media: samsung: exynos4-is: Use %pe format specifier Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251013-ptr_err-v1-29-2c5efbd82952@chromium.org> References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> In-Reply-To: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> To: Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , =?utf-8?q?Krzysztof_Ha=C5=82asa?= , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR(). This patch fixes this cocci report: ./platform/samsung/exynos4-is/media-dev.c:1337:16-23: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda --- drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index c781853586fd21996105c050e587bf8079cfc095..d6f7601de597e3d3517ef9195d728deb578e74f1 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1333,8 +1333,8 @@ static int fimc_md_register_clk_provider(struct fimc_md *fmd) cp->clks[i] = clk_register(NULL, &camclk->hw); if (IS_ERR(cp->clks[i])) { - dev_err(dev, "failed to register clock: %s (%ld)\n", - init.name, PTR_ERR(cp->clks[i])); + dev_err(dev, "failed to register clock: %s (%pe)\n", + init.name, cp->clks[i]); ret = PTR_ERR(cp->clks[i]); goto err; } -- 2.51.0.760.g7b8bcc2412-goog