From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F8EC2C21C3 for ; Mon, 13 Oct 2025 14:14:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364901; cv=none; b=K+TkYuoFQilHp7oqaLEufUrg0gslQF12jUHX7JtOjun9Ku0W9022t7/zFFJFCEYQZBMiAo/5XlRcnR0K3WnD+WXfQyT6TJsGgtC0LjbFJIwO4DJxbiyxCVe6AkxKJ6mSjm0+/XBOPQ7d9HeZYpgHL2lJ3LedUJyGaTKtUrq0Ma0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760364901; c=relaxed/simple; bh=/L6PKcFgTFzEsGq20C+fAHYn8KGkkVmm5YQquq5Z0Q4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=byBv09Sp/6LrE6PWWcCe1FZyZJmK5p2WKwQEwcef7IZt/O8lQnsFs14RvS1lBzR4NJfDypjQFKCGewJkstm8ReCLb6gy1+HF5lDFJZS77l+MfAacr437w0NgzNb0zGbVvAe9K2LEyt6t9HREmdsCr0BiFwmzVQT1m9ZpSBW9nLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=R6yq3nz7; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="R6yq3nz7" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-59054fc6a45so1057049e87.3 for ; Mon, 13 Oct 2025 07:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1760364893; x=1760969693; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9T8mO4GmxU6Sp5lObaHqxq0/smUXIq4FXIudPa6OeB0=; b=R6yq3nz7f9fqGCJ0qh+ZB9t2ZFlnNHoGPzkK7FNr2nXORsYaQGAukJ7sqahEtih0Vs Prnnhj2mQtrl+E+vZ/9zeg9kRMMSiwG2qGvjqXzin6SA49tVBrM0ck0kMGp4ZG2QqmAE jkIy2gR09FGBRe6Gy6vgN0S9rVw1D9vSxoImY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760364893; x=1760969693; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9T8mO4GmxU6Sp5lObaHqxq0/smUXIq4FXIudPa6OeB0=; b=GMV3vkOjgem+IZKoEpPxLtasQdo8lYNT9FF8+7z925E68jkAlKOscVZR1gP/8LPHoi rxh4RTYEWLHaU5T60K7gKav3s3OtBWGuR3i991usAO2OaJ3sjjKvdYFZOucmOfhlmBWQ 93zWURGA9IH9qTy8bqNHcLMto/FVDzzytnLsJD5tYMTmrDDgMcQqlPJJXar/1HGVXpe0 IBnRihX4yNb3TerlbU4GUWsjchTi37reiwBM4idvoSn3mBsjwIBRu9nRoUhXJjZ5Lkmb NByH+ytsFeKPA9fVLCd1o13nmDGa4nHBSdE3E/d/qUXCM/VGXkIVv9QLLgRvnFanIjjA bmPg== X-Forwarded-Encrypted: i=1; AJvYcCXAI3hO8y4I6NU6IpURLqlzRygWIkB0GkAeAbhQ0DHfRak/1rDJV5Nkvj3HIbiZXU/i7dwPBnUL9SwF9w==@vger.kernel.org X-Gm-Message-State: AOJu0Yy3HrB6kWmFawgZlcTEWSwtQhloX67o5CFxv7QHH1yxNDTgGm7A vg7VKJg0smH+BmJI/fX5C391Bq/NRr+Eh6lEGAsw4bi61dSZsXy1pnGj28JIehgefQ== X-Gm-Gg: ASbGncsrQghcKUUbZjTuahKsORUtE7sOQp19sF4c9dQZ6LeG7kIQOj+knzrXFGJVMKm naIFxQA0EbUfvE4FS7GQOeVm711C3O4gwl5Z9P3PbiD/eohntAe1DnE8ewqiyQCoj2SYqtmwDyj NK+p1xSLiHY+WmKrwG8jvNCS+KvqZIwyIofzpuiNN5CxJKbu4JMSJ8NTXNC6Mu/UfNIeIacnoiG DjVY/PcSBQ7a/fdMcP1ixwYcWUVDtAyUZlOvxbPCN1oaWshUHbYs6G6j+RqoaDEIKOn1+Nsk6lR EJHeHbxqN2BGirR4m2+UQRsUWoh3rHJNQ4aZOG3FKm7qABO343SKoYCjsimBl5sFZw+QI9ZkYmm 4CR+afomhe0C10hRzjoe/4/PybCCDHQeNrHSPE/JBJ/R3SJouOOoiAqv91EBTRi3H3e8uXnADnr jCICqHEzqm2ty5xfpcLH4aAUVak6By X-Google-Smtp-Source: AGHT+IF29XnVuKewIk2Zn4qpOdHSO/Y/bSkdxJ/SAd2VXfC5cMU7PSQseV2CsRuBBvo11GHLWuTn2Q== X-Received: by 2002:a05:6512:3d14:b0:55f:4633:7b2 with SMTP id 2adb3069b0e04-5906dd73db3mr5724883e87.46.1760364893403; Mon, 13 Oct 2025 07:14:53 -0700 (PDT) Received: from ribalda.c.googlers.com (56.213.88.34.bc.googleusercontent.com. [34.88.213.56]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590881e4e58sm4165256e87.25.2025.10.13.07.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 07:14:53 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 13 Oct 2025 14:14:46 +0000 Subject: [PATCH 06/32] media: ccs: Use %pe format specifier Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251013-ptr_err-v1-6-2c5efbd82952@chromium.org> References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> In-Reply-To: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> To: Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , =?utf-8?q?Krzysztof_Ha=C5=82asa?= , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Niklas_S=C3=B6derlund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.14.2 The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR() This patch fixes this cocci report: ./i2c/ccs/ccs-core.c:3241:3-10: WARNING: Consider using %pe to print PTR_ERR() ./i2c/ccs/ccs-core.c:3298:3-10: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda --- drivers/media/i2c/ccs/ccs-core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c index 1c889c878abd3aeb1b7a887cff29b5eb864ab057..f8523140784c7120eaf018ffa9e3b43ea12ef72f 100644 --- a/drivers/media/i2c/ccs/ccs-core.c +++ b/drivers/media/i2c/ccs/ccs-core.c @@ -3237,8 +3237,8 @@ static int ccs_probe(struct i2c_client *client) dev_info(&client->dev, "no clock defined, continuing...\n"); sensor->ext_clk = NULL; } else if (IS_ERR(sensor->ext_clk)) { - dev_err(&client->dev, "could not get clock (%ld)\n", - PTR_ERR(sensor->ext_clk)); + dev_err(&client->dev, "could not get clock (%pe)\n", + sensor->ext_clk); return -EPROBE_DEFER; } @@ -3294,8 +3294,8 @@ static int ccs_probe(struct i2c_client *client) sensor->regmap = devm_cci_regmap_init_i2c(client, 16); if (IS_ERR(sensor->regmap)) { - dev_err(&client->dev, "can't initialise CCI (%ld)\n", - PTR_ERR(sensor->regmap)); + dev_err(&client->dev, "can't initialise CCI (%pe)\n", + sensor->regmap); return PTR_ERR(sensor->regmap); } -- 2.51.0.760.g7b8bcc2412-goog