From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7343F32E75C; Tue, 4 Nov 2025 14:31:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762266670; cv=none; b=ihvjoGsMpfn59CESregcZnh51DgeLAYzm0vLxuZj36EFDAu8VQNw7fQaM04eAvhJGZbnWvq6lDzmT0pFh3tMrZoN8vEzKXM1lpfHXsngioMjOYU4o0ceX3BaR9mLBpDmmiBsxuw52Ls+Fo7u5UVjmMa5aawc67Z1nHJeuHHCHL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762266670; c=relaxed/simple; bh=hQnCA1BpUcL83RWvOyJVuSNE2JhgRnn1BH5rERpL7MQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pRRB4na/ATiuWJr0mV2FY+YmY1uPj5er0124aQ+Nsq4dAa7XNIT0UCkbBGGcOTfvstuRg2jYDmxPHSDpivIJYA7w7mb0j8KdCtaCrCPh545UPWs9Y6Pl5JqwZgvUM2v9+hdUgY4u+pC9mOtzSLjp2fOrC0+PPxpiP/xQ/mP3+zU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=xqdKTFZi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="xqdKTFZi" Received: by smtp.kernel.org (Postfix) with ESMTPS id 001E1C4AF11; Tue, 4 Nov 2025 14:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux.dev; s=korg; t=1762266670; bh=hQnCA1BpUcL83RWvOyJVuSNE2JhgRnn1BH5rERpL7MQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=xqdKTFZiBJqKvQazLlbVxcFAomvPKuq0wb1UTYHNiMXPQ9FFPkntRpji+usAoiPbE tT9FhbmZCQs/uLtvOx3WyQE0D2H/Jsg7Y9YQNLV/xSxiSC3HBCEgl3fNSfOduqMl6r Yi/I49HmaGt4WYygoGd5aTJIC4D7EOh4s9giz4WE= Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4BDCCFA0C; Tue, 4 Nov 2025 14:31:09 +0000 (UTC) From: Richard Leitner Date: Tue, 04 Nov 2025 15:30:57 +0100 Subject: [PATCH v8 6/8] media: i2c: ov9282: add strobe_duration v4l2 control Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20251104-ov9282-flash-strobe-v8-6-b91dfef1c65a@linux.dev> References: <20251104-ov9282-flash-strobe-v8-0-b91dfef1c65a@linux.dev> In-Reply-To: <20251104-ov9282-flash-strobe-v8-0-b91dfef1c65a@linux.dev> To: Sakari Ailus , Dave Stevenson , Mauro Carvalho Chehab , Lee Jones , Pavel Machek , Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Richard Leitner , Hans Verkuil X-Mailer: b4 0.15-dev-509f5 X-Developer-Signature: v=1; a=ed25519-sha256; t=1762266668; l=3589; i=richard.leitner@linux.dev; s=20250225; h=from:subject:message-id; bh=hQnCA1BpUcL83RWvOyJVuSNE2JhgRnn1BH5rERpL7MQ=; b=Zmmeggqo/l78p1MlJ60sEmT4+2HKmfur7kKZIeAGLwPXs8yu+Car0uYOk2VQVZG3rLKSNm0sd jwfVi7vhbaQB4JEksQX2TD/PeOMcZjNAAzxw9I0Wclm0nereHd8ZTyw X-Developer-Key: i=richard.leitner@linux.dev; a=ed25519; pk=8hZNyyyQFqZ5ruVJsSGBSPIrmJpfDm5HwHU4QVOP1Pk= X-Endpoint-Received: by B4 Relay for richard.leitner@linux.dev/20250225 with auth_id=350 Add V4L2_CID_FLASH_DURATION support using the "strobe_frame_span" feature of the sensor. This is implemented by transforming the given µs value by an interpolated formula to a "span step width" value and writing it to register PWM_CTRL_25, PWM_CTRL_26, PWM_CTRL_27, PWM_CTRL_28 (0x3925, 0x3926, 0x3927, 0x3928). The maximum control value is set to the period of the current default framerate. All register values are based on the OV9281 datasheet v1.53 (jan 2019) and tested using an ov9281 VisionComponents module. Signed-off-by: Richard Leitner --- drivers/media/i2c/ov9282.c | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c index 6afce803a049d..26296dc1d1b95 100644 --- a/drivers/media/i2c/ov9282.c +++ b/drivers/media/i2c/ov9282.c @@ -97,6 +97,10 @@ #define OV9282_REG_MIPI_CTRL00 0x4800 #define OV9282_GATED_CLOCK BIT(5) +/* Flash/Strobe control registers */ +#define OV9282_REG_STROBE_FRAME_SPAN 0x3925 +#define OV9282_STROBE_FRAME_SPAN_DEFAULT 0x0000001a + /* Input clock rate */ #define OV9282_INCLK_RATE 24000000 @@ -687,6 +691,31 @@ static int ov9282_set_ctrl_flash_strobe_oe(struct ov9282 *ov9282, bool enable) return ov9282_write_reg(ov9282, OV9282_REG_OUTPUT_ENABLE6, 1, current_val); } +static int ov9282_set_ctrl_flash_duration(struct ov9282 *ov9282, u32 value) +{ + int ret; + /* + * Calculate "strobe_frame_span" increments from a given value (µs). + * This is quite tricky as "The step width of shift and span is + * programmable under system clock domain.", but it's not documented + * how to program this step width (at least in the datasheet available + * to the author at time of writing). + * The formula below is interpolated from different modes/framerates + * and should work quite well for most settings. + */ + u32 val = value * 192 / (ov9282->cur_mode->width + ov9282->hblank_ctrl->val); + + ret = ov9282_write_reg(ov9282, OV9282_REG_STROBE_FRAME_SPAN, 1, + (val >> 24) & 0xff); + ret |= ov9282_write_reg(ov9282, OV9282_REG_STROBE_FRAME_SPAN + 1, 1, + (val >> 16) & 0xff); + ret |= ov9282_write_reg(ov9282, OV9282_REG_STROBE_FRAME_SPAN + 2, 1, + (val >> 8) & 0xff); + ret |= ov9282_write_reg(ov9282, OV9282_REG_STROBE_FRAME_SPAN + 3, 1, + val & 0xff); + return ret; +} + /** * ov9282_set_ctrl() - Set subdevice control * @ctrl: pointer to v4l2_ctrl structure @@ -756,6 +785,9 @@ static int ov9282_set_ctrl(struct v4l2_ctrl *ctrl) case V4L2_CID_FLASH_STROBE_OE: ret = ov9282_set_ctrl_flash_strobe_oe(ov9282, ctrl->val); break; + case V4L2_CID_FLASH_DURATION: + ret = ov9282_set_ctrl_flash_duration(ov9282, ctrl->val); + break; default: dev_err(ov9282->dev, "Invalid control %d", ctrl->id); ret = -EINVAL; @@ -1345,7 +1377,7 @@ static int ov9282_init_controls(struct ov9282 *ov9282) u32 lpfr; int ret; - ret = v4l2_ctrl_handler_init(ctrl_hdlr, 11); + ret = v4l2_ctrl_handler_init(ctrl_hdlr, 12); if (ret) return ret; @@ -1414,6 +1446,9 @@ static int ov9282_init_controls(struct ov9282 *ov9282) v4l2_ctrl_new_std(ctrl_hdlr, &ov9282_ctrl_ops, V4L2_CID_FLASH_STROBE_OE, 0, 1, 1, 0); + v4l2_ctrl_new_std(ctrl_hdlr, &ov9282_ctrl_ops, V4L2_CID_FLASH_DURATION, + 0, 13900, 1, 8); + ret = v4l2_fwnode_device_parse(ov9282->dev, &props); if (!ret) { /* Failure sets ctrl_hdlr->error, which we check afterwards anyway */ -- 2.47.3