public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Pecio <michal.pecio@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Hans de Goede <hansg@kernel.org>,
	Ricardo Ribalda <ribalda@chromium.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] media: uvcvideo: Return queued buffers on start_streaming() failure
Date: Fri, 14 Nov 2025 08:35:48 +0100	[thread overview]
Message-ID: <20251114083548.54251544.michal.pecio@gmail.com> (raw)
In-Reply-To: <20251113214056.2464-1-laurent.pinchart@ideasonboard.com>

On Thu, 13 Nov 2025 23:40:56 +0200, Laurent Pinchart wrote:
> From: Michal Pecio <michal.pecio@gmail.com>
> 
> Return buffers if streaming fails to start due to uvc_pm_get() error.
> 
> This bug may be responsible for a warning I got running
> 
>     while :; do yavta -c3 /dev/video0; done
> 
> on an xHCI controller which failed under this workload.
> I had no luck reproducing this warning again to confirm.
> 
> xhci_hcd 0000:09:00.0: HC died; cleaning up
> usb 13-2: USB disconnect, device number 2
> WARNING: CPU: 2 PID: 29386 at drivers/media/common/videobuf2/videobuf2-core.c:1803 vb2_start_streaming+0xac/0x120
> 
> Fixes: 7dd56c47784a ("media: uvcvideo: Remove stream->is_streaming field")
> Cc: stable@vger.kernel.org
> Signed-off-by: Michal Pecio <michal.pecio@gmail.com>
> Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Link: https://patch.msgid.link/20251015133642.3dede646.michal.pecio@gmail.com
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v1:
> 
> - Reorganize error path

Look alright, thanks for taking the patch.

      reply	other threads:[~2025-11-14  7:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 21:40 [PATCH v2] media: uvcvideo: Return queued buffers on start_streaming() failure Laurent Pinchart
2025-11-14  7:35 ` Michal Pecio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114083548.54251544.michal.pecio@gmail.com \
    --to=michal.pecio@gmail.com \
    --cc=hansg@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=ribalda@chromium.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox