From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C204123FC41 for ; Sat, 15 Nov 2025 20:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763240365; cv=none; b=ZFJmYDVp70GeIOLEJ9dZixtRnB47i1bJdUMdcpYs3Z7VnPp+UJZBa+/Ryh4DvNt6QZ9S83tyztGI/S9tLJnLHndPctR0o6i239YYt4B8t6QMtTlsVAbCku+b9Jr3yxe6zyAVdgewuYYqMmV5yv32/+P9okTpFDfa8GxIVw/a8y0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763240365; c=relaxed/simple; bh=/11GCS+k8gtmZVz0m7rF5IEQdjT8FPkFQ7e8v/jJ18g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I3WC2lyJioz9CwR7M3E62xoOWozauLaPgdaYWg589jo8N3/pOnhW5sNYYQgoObpN3zvwsIstnkRfhquZszL1edyY6PJMBMj3KwnMCFhlKm+0mBq2b8/2ypA7vbM6WIyAwr+xFJiTVD4furLTFt/o+5t33VZE5Ya8FexT3oHOGqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=OTgbmD6O; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="OTgbmD6O" Received: from pendragon.ideasonboard.com (82-203-165-222.bb.dnainternet.fi [82.203.165.222]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 8061982A; Sat, 15 Nov 2025 21:57:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1763240238; bh=/11GCS+k8gtmZVz0m7rF5IEQdjT8FPkFQ7e8v/jJ18g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OTgbmD6OoVAlAxoABeh/LyF7MDddJuW3gHyMcWCHqioN3pc+WwvA7ONhaTfOY0ux3 JGj3bVGjy4dbZL36UGsrxke+lB8z2HN4pBaKFGHEFhf+343wYCfkRhxQyf/hBKld28 64BhuL8A39DeiddHdByOwDuZ5SmSim82882gUDeg= Date: Sat, 15 Nov 2025 22:59:06 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: hans@jjverkuil.nl, Sakari Ailus , Dan Scally , linux-media@vger.kernel.org Subject: Re: [PATCH] media: mali-c55: Mark pm handlers as __maybe_unused Message-ID: <20251115205906.GC31986@pendragon.ideasonboard.com> References: <20251114201921.562337-1-jacopo.mondi@ideasonboard.com> <20251114204501.GA12160@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Sat, Nov 15, 2025 at 07:07:06PM +0100, Jacopo Mondi wrote: > On Fri, Nov 14, 2025 at 10:45:01PM +0200, Laurent Pinchart wrote: > > On Fri, Nov 14, 2025 at 09:19:20PM +0100, Jacopo Mondi wrote: > > > As the Mali-C55 driver is instrumented to work without depending on > > > CONFIG_PM, mark the two pm_runtime handlers as __maybe_unused to > > > suppress the compiler warning when compiling without CONFIG_PM. > > > > > > Signed-off-by: Jacopo Mondi > > > --- > > > Late fix for Mali C55 PR > > > > > > fixes: > > > https://gitlab.freedesktop.org/linux-media/media-committers/-/jobs/87903226 > > > > > > it's great to have CI, Thanks! > > > > The recommended way to handle this is to replace SET_RUNTIME_PM_OPS with > > RUNTIME_PM_OPS and use pm_ptr(). See commit > > b5ddb9ab3d83fe0d93d38de442c45610a5846d06 for instance. I think you can > > actually use DEFINE_RUNTIME_DEV_PM_OPS() and drop the manual > > SET_SYSTEM_SLEEP_PM_OPS(). > > Thanks, Hans has collected this patch which at least suppress the > compiler warning for v6.19. > > > This being said, it seems PM needs more love, I don't see where > > streaming would get stopped and resumed with system PM. That's something > > to be addressed on top of course. > > We can address both the above suggestions on v6.19! Fine with me. > > > --- > > > drivers/media/platform/arm/mali-c55/mali-c55-core.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c > > > index b23d543cf496..43b834459ccf 100644 > > > --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c > > > +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c > > > @@ -707,7 +707,7 @@ static void __mali_c55_power_off(struct mali_c55 *mali_c55) > > > clk_bulk_disable_unprepare(ARRAY_SIZE(mali_c55->clks), mali_c55->clks); > > > } > > > > > > -static int mali_c55_runtime_suspend(struct device *dev) > > > +static int __maybe_unused mali_c55_runtime_suspend(struct device *dev) > > > { > > > struct mali_c55 *mali_c55 = dev_get_drvdata(dev); > > > > > > @@ -770,7 +770,7 @@ static int __mali_c55_power_on(struct mali_c55 *mali_c55) > > > return 0; > > > } > > > > > > -static int mali_c55_runtime_resume(struct device *dev) > > > +static int __maybe_unused mali_c55_runtime_resume(struct device *dev) > > > { > > > struct mali_c55 *mali_c55 = dev_get_drvdata(dev); > > > int ret; -- Regards, Laurent Pinchart