From: Nathan Chancellor <nathan@kernel.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: drivers/media/i2c/ccs/ccs.o: error: objtool: ccs_set_selection(): unexpected end of section .text.ccs_set_selection
Date: Mon, 24 Nov 2025 11:44:41 -0700 [thread overview]
Message-ID: <20251124184441.GB1084995@ax162> (raw)
In-Reply-To: <aSOKsu3XjLc9GRM-@kekkonen.localdomain>
Hi Sakari,
On Mon, Nov 24, 2025 at 12:29:06AM +0200, Sakari Ailus wrote:
> Thanks for cc'ing me.
>
> I prefer this as there's no guarantee the value read via ccs_get_limit()
> would be non-zero. Presumably it is (and has been so far as no-one has hit
> this to my knowledge), but we shouldn't rely on that.
Ah, that makes sense. I misread some of the other places I thought were
using the value of CCS_LIM() as a divisor, guess I forgot my elementary
order of operations :) This appears to be the only overt one that I can
see.
> I can post a patch as well.
If you have time, that would be great (I am happy to build test and
review it). Otherwise, I can get to it soon.
Cheers,
Nathan
next prev parent reply other threads:[~2025-11-24 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <aSEGwejeD3f7lnUL@rli9-mobl>
[not found] ` <20251122013414.GA3094872@ax162>
[not found] ` <ahukd6b3wonye3zgtptvwzvrxldcruazs2exfvll6etjhmcxyj@vq3eh6pd375b>
2025-11-22 6:29 ` drivers/media/i2c/ccs/ccs.o: error: objtool: ccs_set_selection(): unexpected end of section .text.ccs_set_selection Nathan Chancellor
2025-11-23 22:29 ` Sakari Ailus
2025-11-24 18:44 ` Nathan Chancellor [this message]
2025-11-24 23:00 ` [PATCH 1/1] media: ccs: Avoid possible division by zero Sakari Ailus
2025-11-25 23:24 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124184441.GB1084995@ax162 \
--to=nathan@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox