public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Cc: Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Robert Foss <rfoss@kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Todor Tomov <todor.too@gmail.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: talos-evk-camera: Add DT overlay
Date: Tue, 6 Jan 2026 13:26:09 -0600	[thread overview]
Message-ID: <20260106192609.GA2581379-robh@kernel.org> (raw)
In-Reply-To: <20260106-sm6150_evk-v2-4-bb112cb83d74@oss.qualcomm.com>

On Tue, Jan 06, 2026 at 05:39:56PM +0800, Wenmeng Liu wrote:
> Enable IMX577 via CCI on Taloss EVK Core Kit.
> 
> The Talos EVK board does not include a camera sensor
> by default, this overlay reflects the possibility of
> attaching an optional camera sensor.
> For this reason, the camera sensor configuration is
> placed in talos-evk-camera.dtso, rather than
> modifying the base talos-evk.dts.
> 
> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/Makefile              |  2 +
>  arch/arm64/boot/dts/qcom/talos-evk-camera.dtso | 63 ++++++++++++++++++++++++++
>  2 files changed, 65 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 4258776b71bdba351de8cefa33eb29a0fe3ec6f3..bfaa0b47ab5cabc9aa1c6fba29faa3e6fd18f913 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -333,8 +333,10 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8650-qrd.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8750-mtp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8750-qrd.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= talos-evk.dtb
> +talos-evk-camera-dtbs	:= talos-evk.dtb talos-evk-camera.dtbo

You need to add talos-evk-camera.dtbo to dtb-y if you want it preserved 
and able to be installed (via dtbs_install). If you don't want that, 
then why is it a .dtbo?

Looks like other .dtbo's might have the same issue.

>  talos-evk-lvds-auo,g133han01-dtbs	:= \
>  	talos-evk.dtb talos-evk-lvds-auo,g133han01.dtbo
> +dtb-$(CONFIG_ARCH_QCOM)	+= talos-evk-camera.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= talos-evk-lvds-auo,g133han01.dtb
>  x1e001de-devkit-el2-dtbs	:= x1e001de-devkit.dtb x1-el2.dtbo
>  dtb-$(CONFIG_ARCH_QCOM)	+= x1e001de-devkit.dtb x1e001de-devkit-el2.dtb

  parent reply	other threads:[~2026-01-06 19:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06  9:39 [PATCH v2 0/4] Add CCI and imx577 sensor support for Talos evk Wenmeng Liu
2026-01-06  9:39 ` [PATCH v2 1/4] dt-bindings: i2c: qcom-cci: Document sm6150 compatible Wenmeng Liu
2026-01-07  4:27   ` Vladimir Zapolskiy
2026-01-07  8:00   ` Krzysztof Kozlowski
2026-01-07  8:17     ` Wenmeng Liu
2026-01-07  8:34       ` Krzysztof Kozlowski
2026-01-07 10:07         ` Wenmeng Liu
2026-01-07 10:35           ` Loic Poulain
2026-01-06  9:39 ` [PATCH v2 2/4] arm64: dts: qcom: talos: Add CCI definitions Wenmeng Liu
2026-01-06 18:27   ` Dmitry Baryshkov
2026-01-07  2:47     ` Wenmeng Liu
2026-01-07  4:28   ` Vladimir Zapolskiy
2026-01-06  9:39 ` [PATCH v2 3/4] arm64: dts: qcom: talos: Add camera MCLK pinctrl Wenmeng Liu
2026-01-06 18:29   ` Dmitry Baryshkov
2026-01-07  4:28   ` Vladimir Zapolskiy
2026-01-07 11:51   ` Konrad Dybcio
2026-01-06  9:39 ` [PATCH v2 4/4] arm64: dts: qcom: talos-evk-camera: Add DT overlay Wenmeng Liu
2026-01-06 18:23   ` Dmitry Baryshkov
2026-01-07  3:05     ` Wenmeng Liu
2026-01-07  5:16       ` Vladimir Zapolskiy
2026-01-07  5:55         ` Wenmeng Liu
2026-01-07 21:24           ` Vladimir Zapolskiy
2026-01-06 19:26   ` Rob Herring [this message]
2026-01-07  3:06     ` Wenmeng Liu
2026-01-07 13:28   ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260106192609.GA2581379-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andersson@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=rfoss@kernel.org \
    --cc=todor.too@gmail.com \
    --cc=vladimir.zapolskiy@linaro.org \
    --cc=wenmeng.liu@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox