Re: [PATCH v10 19/64] media: v4l: uapi: Add a control for color pattern flipping effect

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Tue, Jan 13, 2026 at 02:46:13PM +0200, Sakari Ailus wrote:
> Hi Mirela,
> 
> On Wed, Jul 23, 2025 at 01:14:44AM +0300, Mirela Rabulea wrote:
> > Hi Sakari,
> > 
> > On 6/19/25 14:57, Sakari Ailus wrote:
> > > 
> > > 
> > > Add a bitmask control (V4L2_CID_COLOR_PATTERN_FLIP) to tell whether
> > > flipping results in a change in the sensor's color pattern, separately
> > > horizontally and vertically. The information is essential for raw formats
> > > when using generic raw mbus codes.
> > > 
> > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > ---
> > >   .../userspace-api/media/v4l/ext-ctrls-image-source.rst | 10 ++++++++++
> > >   drivers/media/v4l2-core/v4l2-ctrls-defs.c              |  2 ++
> > >   include/uapi/linux/v4l2-controls.h                     |  5 +++++
> > >   3 files changed, 17 insertions(+)
> > > 
> > > diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
> > > index b19aaaffbce0..43a62a85afb8 100644
> > > --- a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
> > > +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
> > > @@ -131,3 +131,13 @@ Image Source Control IDs
> > >         - Raw Bayer, with alternating lines beginning with green, blue pixels and
> > >           red, green pixels.
> > >         - 3
> > > +
> > > +``V4L2_CID_COLOR_PATTERN_FLIP (bitmask)``
> > > +    Whether the horizontal or vertical flipping controls (V4L2_CID_HFLIP and
> > 
> > Maybe "Report whether the horizontal or vertical flipping controls..."
> > sounds more like a sentence?
> 
> How about "This control determines whether..."?

"whether" normally requires a correlative "or". You could write "This
control determines if the horizontal or vertical flipping controls ...".

> > Also, it looks like this is also a read-only control, so it would be nice to
> > mention it also in this doc.
> 
> Agreed.

-- 
Regards,

Laurent Pinchart