Re: [PATCH v8 3/3] media: qcom: camss: tpg: Add TPG support for multiple targets

[kernel test robot <lkp@intel.com>]

Hi Wenmeng,

kernel test robot noticed the following build errors:

[auto build test ERROR on f417b7ffcbef7d76b0d8860518f50dae0e7e5eda]

url:    https://github.com/intel-lab-lkp/linux/commits/Wenmeng-Liu/media-qcom-camss-Add-common-TPG-support/20260113-171032
base:   f417b7ffcbef7d76b0d8860518f50dae0e7e5eda
patch link:    https://lore.kernel.org/r/20260113-camss_tpg-v8-3-fa2cb186a018%40oss.qualcomm.com
patch subject: [PATCH v8 3/3] media: qcom: camss: tpg: Add TPG support for multiple targets
config: parisc-randconfig-002-20260115 (https://download.01.org/0day-ci/archive/20260115/202601152315.fC7ckH9z-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260115/202601152315.fC7ckH9z-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601152315.fC7ckH9z-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/media/platform/qcom/camss/camss-csid-680.c: In function '__csid_configure_rx':
>> drivers/media/platform/qcom/camss/camss-csid-680.c:202:32: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
     202 |                         val |= FIELD_PREP(CSI2_RX_CFG0_TPG_NUM_SEL, phy->csiphy_id + 1);
         |                                ^~~~~~~~~~
   cc1: some warnings being treated as errors
--
   drivers/media/platform/qcom/camss/camss-csid-gen3.c: In function '__csid_configure_rx':
>> drivers/media/platform/qcom/camss/camss-csid-gen3.c:126:32: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
     126 |                         val |= FIELD_PREP(CSI2_RX_CFG0_TPG_NUM_SEL, phy->csiphy_id + 1);
         |                                ^~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/FIELD_PREP +202 drivers/media/platform/qcom/camss/camss-csid-680.c

   185	
   186	static void __csid_configure_rx(struct csid_device *csid,
   187					struct csid_phy_config *phy, int vc)
   188	{
   189		u32 val;
   190		struct camss *camss;
   191		struct tpg_device *tpg;
   192	
   193		camss = csid->camss;
   194		val = (phy->lane_cnt - 1) << CSI2_RX_CFG0_NUM_ACTIVE_LANES;
   195		val |= phy->lane_assign << CSI2_RX_CFG0_DL0_INPUT_SEL;
   196		val |= (phy->csiphy_id + CSI2_RX_CFG0_PHY_SEL_BASE_IDX) << CSI2_RX_CFG0_PHY_NUM_SEL;
   197	
   198		if (camss->tpg) {
   199			tpg = &camss->tpg[phy->csiphy_id];
   200	
   201			if (csid->tpg_linked && tpg->testgen.mode > 0) {
 > 202				val |= FIELD_PREP(CSI2_RX_CFG0_TPG_NUM_SEL, phy->csiphy_id + 1);
   203				val |= CSI2_RX_CFG0_TPG_NUM_EN;
   204			}
   205		}
   206	
   207		writel(val, csid->base + CSID_CSI2_RX_CFG0);
   208	
   209		val = CSI2_RX_CFG1_PACKET_ECC_CORRECTION_EN;
   210		if (vc > 3)
   211			val |= CSI2_RX_CFG1_VC_MODE;
   212		writel(val, csid->base + CSID_CSI2_RX_CFG1);
   213	}
   214	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki